From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59497C11F68 for ; Fri, 2 Jul 2021 17:09:15 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id DC2D5613E8 for ; Fri, 2 Jul 2021 17:09:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC2D5613E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D9FF41363; Fri, 2 Jul 2021 19:09:14 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 7F5CB41353 for ; Fri, 2 Jul 2021 19:09:11 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10033"; a="195927613" X-IronPort-AV: E=Sophos;i="5.83,317,1616482800"; d="scan'208";a="195927613" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2021 10:09:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,317,1616482800"; d="scan'208";a="560100151" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 02 Jul 2021 10:09:07 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 2 Jul 2021 10:09:07 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Fri, 2 Jul 2021 10:09:07 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Fri, 2 Jul 2021 10:08:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E43ugGzogsIflHGIWUFBB0HCEk91yDfOAUVDFBv5NAE37qI8nktqi/mUCnhD28bIP/hqu3ACmsBgzxHq4xm33ocuA5rZKzjkhryoWN/Z0crl/A+iT2rvFhV32hCGz1ZwU9aIkhsdfBR7TB2op9eJByHYwg2XPwLltIwA7nw66zBab8d0wWp3+2qsLb4CBBZ2YR6LPTwg8ZiGUAcFQSrBlH2toy4ZSFyagfQfArqhWrj4nSzQtIsqW+svhF5qQPfiyqYiMA9HVaQjEymUDgqdIPuKJoM2DBO7LwwzxH2fpR7IbvwWgb2mj14q0jCDlIJwgJ98rrl/ixVq4LktyQnymQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r8K7icgksYeaMLxiI/at5fmToCJe8oun3AUAWtOHdgI=; b=lhusu88fuL89ihaVxMvLVVqpe5yo5/pSmMbgXO+AfLl6XZSKokVX5YoGom32RVitk3gl58U5wCqSLBs0AEoRF4rBPXRVLhwydXkE2Fo9yovMRjlbyWmQNRgDdACGlYKEwa9OzrNIEvovEChKdoTTd0VhgT4gUTqNlr1WfCFaoDj6U1qBjBble8Kh5kNdxXWhgw7SMWm24sQOagwOThXTzi3nRAyTgEQVs4KpIilf6wUJ+0emxyVZAvZ+yzzMCtYZd8QI57WQc+wSOIfpRSNoqef5tKicnylEFqIIWjYJbZnxm5rrwZptwqIU4OrDvJmfyDnESn+i/my2XHNqzM7AJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r8K7icgksYeaMLxiI/at5fmToCJe8oun3AUAWtOHdgI=; b=OV0reEIByywXJj9D5jzQAzafIWBqd/WJugDMlwWYdpHNvS4JZGTHOTuRjk8WmqS521TQky1xl43Si0z2Rf3gVEFpwUz6QzJrWZmOlEnWJ031UyUKFmVLwA7ShCPbcRPKWoKc+8p+ecBWYgX/1U/tfTXpcj/hqgH+BQUEXXjmB94= Received: from PH0PR11MB4824.namprd11.prod.outlook.com (2603:10b6:510:38::13) by PH0PR11MB4887.namprd11.prod.outlook.com (2603:10b6:510:30::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Fri, 2 Jul 2021 17:08:52 +0000 Received: from PH0PR11MB4824.namprd11.prod.outlook.com ([fe80::71d4:246:91ea:4df5]) by PH0PR11MB4824.namprd11.prod.outlook.com ([fe80::71d4:246:91ea:4df5%3]) with mapi id 15.20.4287.023; Fri, 2 Jul 2021 17:08:52 +0000 From: "Gujjar, Abhinandan S" To: "dev@dpdk.org" , "jerinj@marvell.com" , "dpdklab@iol.unh.edu" , "aconole@redhat.com" CC: "gakhil@marvell.com" , "Power, Ciara" , "Yigit, Ferruh" Thread-Topic: [PATCH] test: fix crypto_op length for sessionless case Thread-Index: AQHXba4ehMTU0laelUap+7tkfuTf5asv7WYA Date: Fri, 2 Jul 2021 17:08:52 +0000 Message-ID: References: <20210630124637.2987722-1-abhinandan.gujjar@intel.com> In-Reply-To: <20210630124637.2987722-1-abhinandan.gujjar@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4714964f-6f9a-42b5-8491-08d93d7c114a x-ms-traffictypediagnostic: PH0PR11MB4887: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LrAiM3pmr0QdJXf18X2n9WYEK5EGs7H3pu9YaO0Tjw0X6oo+3YWWpuvzxYXh177ogvMACXcfWGG6yDCqlSEbfZlsChqyrHEO4Boj1R7y8gOkQZ5fIFbfO2DmdIJjjIhyEQ3X03jCoGzXvQJRjizFUO55f+R2/ZV5RpnmiruFPGJ6J7Glkx6pOsY7fDI4VL7+Yy38ffxZ/o7eau76KxbSqlZ+EevkUg13Rwzroek5xf108lz6Gn55FAde1vGyJ8vfGluQVSlsrHgtIssOj0bsHrYUxzOYfeGEawDNwARDw9DPVPslZI07iOxHYuhyOhzrMq1Qa5E8IL9R/ycWh/T/JIrGpQHeEjE7kZNuxiafKPS+/tAvYHFA6MLpFjb6Lez3RzVdi0lBUzUm7RdXaAEZBSJuaxe8HiDtT7wNXyVbdvaIKbtBcLSj9SngXoOEPeiSiDKvwJbyGJm/aaWu0/ipkTCsX7iwQqX10mlsaWupHwwg1caGR+qx3xTNU/wAs2g96OggEwv1EhDQE2o+4YwBBPVnUQboZc6oHfgBuigHNHGEXRWSs5pEfn8IgOjLKKKMRun1Bff7TTnMk1e/+kd8mEARR+uPpmXquyn7m1E11nAjYpn3juNbnq1PwCaqVRkGvhReMg30idrIMu1D4FR2gw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4824.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(366004)(136003)(39860400002)(396003)(55236004)(2906002)(6506007)(53546011)(64756008)(76116006)(86362001)(8936002)(83380400001)(66556008)(8676002)(66476007)(33656002)(7696005)(52536014)(66446008)(71200400001)(66946007)(5660300002)(110136005)(55016002)(38100700002)(54906003)(26005)(122000001)(186003)(4326008)(107886003)(478600001)(9686003)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/XLUJjSSbqbC3EN7CdztEy2u4TI8jsxRmxCXAvuvT4jR8aHOZOtMWI93eV1Q?= =?us-ascii?Q?N86J6DIICAiuUGx5NJXxq5cQ3qAsKlGCDoMSuJ1SZt5zYDhmASpLEa5gCKGQ?= =?us-ascii?Q?QC1OVBKnZIaTKqLnI0jFtOUQdj7FQkW/LbKhePFAzfnKvzkAKxIMTIU7koPZ?= =?us-ascii?Q?GnxoPukatskRy642Of38sfQXflN+2ZaHzVkUCy9aM+FeSYUkU8Q0BF3Hk5xj?= =?us-ascii?Q?Ke7SbPj3BJq8nBqINAZzyhQ6+kYE6zs9/yxn61lZ+VFW5HxdD5+pJASmuIj7?= =?us-ascii?Q?nQt568tqA8j708bFLPx90WEXPuVOfJXfPwo7oOMarWE9xXcwWF01e1sN4nsZ?= =?us-ascii?Q?lSTVLTbeVd/O5WzMiatZ51Aea6YA3dImg1yXpKbzZ1TCJ96KaECLcesaij+X?= =?us-ascii?Q?7Yau0dbXqlJF9nPBl+ZyAZPuQ5eprbER1UsgFRiiqCDhvH4kYedoCjs7ZLEr?= =?us-ascii?Q?V5nEfXA5F91QglOl2AfPg1+D9ykbYYpzxfeH0wTT4R3t+Zf+xcV3jGUM8B3r?= =?us-ascii?Q?JtRJG+5kJdHF0SITraJk7ONkS7x8akARMBs5QcKKpq+szuQ4TTQ5HuyA3Vph?= =?us-ascii?Q?gb0QFk149XulR5asSlN2hE4OJeV7HJZTINntpjLD71nFkQbXQ2ygZCTFRduL?= =?us-ascii?Q?Ygmd4LHFrFaHIoZhE6oay3puV0nL6uJyPvtZLmMdemhDcOVT+A9Qx52nCfSB?= =?us-ascii?Q?OFoE/22NbrCoYNqrqLavvd4gjrlyvHpVl+LkF5aEUsEqFAOtMATzeZr8wMOI?= =?us-ascii?Q?IBTU5LMNU5FS96a1TyF1wktJSajRwImfjIGGq5f2FGYSneQ24rDe0RhXR5ax?= =?us-ascii?Q?sTMfCBrtGL5RYw66uMmSHwlam2WZe6ggxVz72iHTLPmxnppJse/NdoBO5u9x?= =?us-ascii?Q?na8akOuBLZqiXn8RvyvY/pIpTLRVwKnAt9BwV2tPqTkVzA34xL/W4JOVyih2?= =?us-ascii?Q?Mth13nyPIurjTXq+Q3bkpvsDeq6D1ynr85WE9uJM+6fOpdPCz4ziDl+wIFvp?= =?us-ascii?Q?skok80/aVuwoCv1COWW3odd00xH3MXTAZPipo7wQT8AAh28Jc9Gwn8qsF0L1?= =?us-ascii?Q?4hwYB1EbE4umZSn2sOWMpkLnEhua5DeXcFKUkqKpFCd1Bk1TqKk+DEhamSN7?= =?us-ascii?Q?G4f1cLglASPYn8bTKRLuH/1VWcC7fAST+ueQbWAOFUFyfTa/5xzF72Sfghpi?= =?us-ascii?Q?lpLsOEArm2eRmaaoOlwDj2co04OoRpgxRNToJOAr24ES6HmG78EOSTPRRIua?= =?us-ascii?Q?PI+nVNitNYg65NreaQPMM0Bx3heolUd2f/8JtdzVu76bppWMY3klGCTTHuy6?= =?us-ascii?Q?a20=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4824.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4714964f-6f9a-42b5-8491-08d93d7c114a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2021 17:08:52.3368 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r5gzlXy5GoTRMNiQ0do0IvEZxHGShsDVEUbBPfK/mQHgznsdb7E6MCYuoVJjSPFq49W86ac4KOn7cZWZun6B4F+KCkW5LPuRa4Et9UZDZKs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4887 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] test: fix crypto_op length for sessionless case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Aaron/dpdklab, This patch's CI seems to have lot of false positive! Ferruh triggered the re-test sometime back. Now, it is reporting less. Could you please check from your end? Thanks! Regards Abhinandan > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Wednesday, June 30, 2021 6:17 PM > To: dev@dpdk.org; jerinj@marvell.com > Cc: gakhil@marvell.com; Gujjar, Abhinandan S > ; Power, Ciara > Subject: [PATCH] test: fix crypto_op length for sessionless case >=20 > Currently, private_data_offset for the sessionless is computed wrongly wh= ich > includes extra bytes added because of using sizeof(struct > rte_crypto_sym_xform) * 2) instead of (sizeof(union > rte_event_crypto_metadata)). Due to this buffer overflow, the corruption = was > leading to test application crash while freeing the ops mempool. >=20 > Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test") > Reported-by: ciara.power@intel.com >=20 > Signed-off-by: Abhinandan Gujjar > --- > app/test/test_event_crypto_adapter.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test/test_event_crypto_adapter.c > b/app/test/test_event_crypto_adapter.c > index f689bc1f2..688ac0b2f 100644 > --- a/app/test/test_event_crypto_adapter.c > +++ b/app/test/test_event_crypto_adapter.c > @@ -229,7 +229,7 @@ test_op_forward_mode(uint8_t session_less) > first_xform =3D &cipher_xform; > sym_op->xform =3D first_xform; > uint32_t len =3D IV_OFFSET + MAXIMUM_IV_LENGTH + > - (sizeof(struct rte_crypto_sym_xform) * 2); > + (sizeof(union rte_event_crypto_metadata)); > op->private_data_offset =3D len; > /* Fill in private data information */ > rte_memcpy(&m_data.response_info, &response_info, @@ - > 424,7 +424,7 @@ test_op_new_mode(uint8_t session_less) > first_xform =3D &cipher_xform; > sym_op->xform =3D first_xform; > uint32_t len =3D IV_OFFSET + MAXIMUM_IV_LENGTH + > - (sizeof(struct rte_crypto_sym_xform) * 2); > + (sizeof(union rte_event_crypto_metadata)); > op->private_data_offset =3D len; > /* Fill in private data information */ > rte_memcpy(&m_data.response_info, &response_info, > -- > 2.25.1