All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Ajish.Koshy@microchip.com>
To: <john.garry@huawei.com>, <linux-scsi@vger.kernel.org>
Cc: <Vasanthalakshmi.Tharmarajan@microchip.com>,
	<Viswas.G@microchip.com>, <damien.lemoal@opensource.wdc.com>,
	<jinpu.wang@cloud.ionos.com>
Subject: RE: [PATCH 2/2] scsi: pm80xx: enable upper inbound, outbound queues
Date: Fri, 1 Apr 2022 09:58:57 +0000	[thread overview]
Message-ID: <PH0PR11MB51128998F4B631845D8956F5ECE09@PH0PR11MB5112.namprd11.prod.outlook.com> (raw)
In-Reply-To: <4b891427-0bce-d672-f8ab-2b1572a0f553@huawei.com>

Hi John,

> I'm not sure if this change was meant to help, but I still see timeouts on my
> 96-core arm64 machine with this change - see log at bottom.
> 
> I still get the feeling that this issue I mention is timing related, as it goes away
> when I enable lots of heavy debug (like kasan, kmemleak, prove_locking, etc.
> 

Thank you for sharing your observation on arm server with respect to these
patches.

It will be difficult to comment right now on arm server and as you said issue is not
observed when debugs are enabled.

Current patch was tested on amd 128 core server x86_64, drives connected to
enclosure. 

Loading driver(without patch) on this 128 core server had issues.

To get better understanding, booted the server in two scenarios, boot arguments
1. nr_cpus=32
2. nr_cpus=34

For #1 nr_cpus=32, was able to load the driver, run fio, unload the driver
without any issue.

But for #2 nr_cpus=34, things were not working properly. Loading had issues.
Error handler was getting triggered. After giving some debug prints, it was visible
that request submitted on IQ31 or less were getting completion whereas for requests
on IQ32 and IQ33 were not receiving completion/interrupt.

Post enabling this E64Q bit in the controller, made a difference. Now driver can be loaded,
run FIO, unload it without observing any issue, including on 128 core default setting.

Thanks,
Ajish

      reply	other threads:[~2022-04-01  9:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28  8:42 [PATCH 0/2] pm80xx updates Ajish Koshy
2022-03-28  8:42 ` [PATCH 1/2] scsi: pm80xx: mask and unmask upper interrupt vectors 32-63 Ajish Koshy
2022-03-28  9:20   ` Damien Le Moal
2022-03-28 10:12     ` Ajish.Koshy
2022-03-28  9:39   ` Jinpu Wang
2022-03-28 10:53     ` Ajish.Koshy
2022-03-28  8:42 ` [PATCH 2/2] scsi: pm80xx: enable upper inbound, outbound queues Ajish Koshy
2022-03-28  9:23   ` Damien Le Moal
2022-03-28 10:48     ` Ajish.Koshy
2022-03-28  9:37   ` Jinpu Wang
2022-03-28 10:51     ` Ajish.Koshy
2022-03-28 14:13   ` John Garry
2022-04-01  9:58     ` Ajish.Koshy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB51128998F4B631845D8956F5ECE09@PH0PR11MB5112.namprd11.prod.outlook.com \
    --to=ajish.koshy@microchip.com \
    --cc=Vasanthalakshmi.Tharmarajan@microchip.com \
    --cc=Viswas.G@microchip.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=john.garry@huawei.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.