Re: [OE-core][PATCH] mesa: Allow building the iris driver

["Yongxin Liu" <yongxin.liu@windriver.com>]

> -----Original Message-----
> From: Böszörményi Zoltán <zboszor@pr.hu>
> Sent: Wednesday, February 24, 2021 13:36
> To: Liu, Yongxin <Yongxin.Liu@windriver.com>; openembedded-
> core@lists.openembedded.org; richard.purdie@linuxfoundation.org
> Subject: Re: [OE-core][PATCH] mesa: Allow building the iris driver
> 
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> Hi,
> 
> 2021. 02. 24. 1:31 keltezéssel, Yongxin Liu írta:
> >
> > Iris driver supports Broadwell and newer (Gen8+) for very low CPU
> overhead.
> >
> > With this patch, user can add PACKAGECONFIG_append = " iris" in their
> bbappend file.
> >
> > And then iris will be added in build options, like "-Dgallium-
> drivers=swrast,virgl,iris".
> > You can check mesa/2_20.3.2-r0/build/meson-logs/meson-log.txt for this.
> >
> > The driver can be found in build directory:
> > mesa/2_20.3.2-r0/image/usr/lib64/dri/iris_dri.so
> >
> >
> > Thanks,
> > Yongxin
> 
> Since VAR_append can appear multiple times, bbappend files can equally do
> 
> GALLIUMDRIVERS_append_x86_class-target = ",iris"
> GALLIUMDRIVERS_append_x86-64_class-target = ",iris"
> 
> instead of this PACKAGECONFIG.
> 
> Anyway, since this MR exists in Mesa:
> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8015
> after a certain point this will have to be used in the upstream recipe
> (pseudo-patch follows):
> 
> ...
> -DRIDRIVERS_append_x86_class-target = ",r100,r200,nouveau,i965,i915"
> -DRIDRIVERS_append_x86-64_class-target = ",r100,r200,nouveau,i965,i915"
> ...
> +GALLIUMDRIVERS_append_x86_class-target = ",nouveau,i915,iris"
> +GALLIUMDRIVERS_append_x86-64_class-target = ",nouveau,i915,iris"
> ...
> 

Great. Thanks for pointing it out.

--Yongxin

> Best regards,
> Zoltán Böszörményi
> 
> >
> >> -----Original Message-----
> >> From: openembedded-core@lists.openembedded.org <openembedded-
> >> core@lists.openembedded.org> On Behalf Of Yongxin Liu
> >> Sent: Thursday, February 18, 2021 16:56
> >> To: openembedded-core@lists.openembedded.org;
> >> richard.purdie@linuxfoundation.org
> >> Subject: [OE-core][PATCH] mesa: Allow building the iris driver
> >>
> >> Signed-off-by: Yongxin Liu <yongxin.liu@windriver.com>
> >> ---
> >>   meta/recipes-graphics/mesa/mesa.inc | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-
> >> graphics/mesa/mesa.inc index cb075a8b89..72e22d654e 100644
> >> --- a/meta/recipes-graphics/mesa/mesa.inc
> >> +++ b/meta/recipes-graphics/mesa/mesa.inc
> >> @@ -168,6 +168,9 @@ GALLIUMDRIVERS_append
> >> ="${@bb.utils.contains('PACKAGECONFIG', 'lima', ',lima', '
> >>   PACKAGECONFIG[panfrost] = ""
> >>   GALLIUMDRIVERS_append ="${@bb.utils.contains('PACKAGECONFIG',
> >> 'panfrost', ',panfrost', '', d)}"
> >>
> >> +PACKAGECONFIG[iris] = ""
> >> +GALLIUMDRIVERS_append ="${@bb.utils.contains('PACKAGECONFIG',
> >> +'iris',
> >> ',iris', '', d)}"
> >> +
> >>   OSMESA = "${@bb.utils.contains('PACKAGECONFIG', 'gallium',
> >> 'gallium', 'classic', d)}"
> >>   PACKAGECONFIG[osmesa] = "-Dosmesa=${OSMESA},-Dosmesa=none"
> >>
> >> --
> >> 2.14.5
> >
> >
> >
> > 
> >