From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44DB0C432BE for ; Thu, 2 Sep 2021 14:11:40 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id B1270610CC for ; Thu, 2 Sep 2021 14:11:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B1270610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7F974013F; Thu, 2 Sep 2021 16:11:38 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 4ECF64003C for ; Thu, 2 Sep 2021 16:11:37 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10094"; a="218831723" X-IronPort-AV: E=Sophos;i="5.84,372,1620716400"; d="scan'208";a="218831723" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2021 07:11:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,372,1620716400"; d="scan'208";a="602399736" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga001.fm.intel.com with ESMTP; 02 Sep 2021 07:11:35 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 2 Sep 2021 07:11:35 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 2 Sep 2021 07:11:35 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 2 Sep 2021 07:11:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y4208P/dw7wOuWZXTzx+Pkte3J40YYVQjcHkJVB/qrW/Gj9uscEYxJZR3vSw6ri/30g5tBYXXyUmYa5EnmODTqHiTWMz0Y4SbDjI5rMBsDIXTrHFMD96Ojuf9im/QusS+m+K//p7i8Cx9k2n6KeWrVCPaARWwxAkYr0GIAuhI8JS6QekWPst04R2W9hTNGMSJzD4lGGesO7wIFWurR0bcQk+tYdTCUEwdn09ZfmSYPxyUPMmhwV3QGAw+dpiBLwOZ2HLtKJatEpXKiEil6yvTd9q4J1BzC1fuToMi09QYIo5rYBlYnni9+9cglvW8wbmNPCl6/bp2VkSTFC7JPhhpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hyuBlecQ4mqjzwiRze6td/Q9eUzbrvlbNBZyeqSY86A=; b=C0CsdFMoadv/xbY28LcclisFZrtzuzx2Xb1mpX7ClhDAsCq269Ruv1PZuXDVRXfoV4N9LNv3Wo2fI9rNZMiLh4fkwUYQRMt8cXqUbGoI4lhm25UCkL8M3LAxynX8llCy/EJvI86qCSbbMc2bGKJUmm87j5L2SfhsWFkJmZrRnNXyhJQxS+ucWkN60vpa49vBPJm5J99lKe+NsOwlzwcaTczm/d4t3q/xWf0Cnx/X0LtNNsgvf6906ryz1FTeF7R7DNQ/Hn+yGOenZv5u854qhk8PIZ+MlHHib58TgREqvZcBhzQDy10d63nLmBjpfsYNboyKZretI0UEtRMQxCGkqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hyuBlecQ4mqjzwiRze6td/Q9eUzbrvlbNBZyeqSY86A=; b=b9huUZPgih95BJUCiZwoKvTIJUAyNGPqsJrYdJP360aDbYNvBtrIs9Vie1YZb1n4Do7kGf+feoKiQIzVsv1vbCLn1+s+WZl6C58Fvw2PJ8lM9m1jge/xVrVmke+WrcwWzvbjmgOdhHWuSEZLYv4/1CCdwfEsWVGwOvEDbYJNo1E= Received: from PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) by PH0PR11MB4984.namprd11.prod.outlook.com (2603:10b6:510:34::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Thu, 2 Sep 2021 14:11:25 +0000 Received: from PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::c42e:f6ab:d4d6:dc8a]) by PH0PR11MB5207.namprd11.prod.outlook.com ([fe80::c42e:f6ab:d4d6:dc8a%6]) with mapi id 15.20.4478.022; Thu, 2 Sep 2021 14:11:24 +0000 From: "Walsh, Conor" To: Chengwen Feng , "thomas@monjalon.net" , "Yigit, Ferruh" , "Richardson, Bruce" , "jerinj@marvell.com" , "jerinjacobk@gmail.com" , "andrew.rybchenko@oktetlabs.ru" CC: "dev@dpdk.org" , "mb@smartsharesystems.com" , "nipun.gupta@nxp.com" , "hemant.agrawal@nxp.com" , "maxime.coquelin@redhat.com" , "honnappa.nagarahalli@arm.com" , "david.marchand@redhat.com" , "sburla@marvell.com" , "pkapoor@marvell.com" , "Ananyev, Konstantin" , "Laatz, Kevin" Thread-Topic: [PATCH v19 7/7] app/test: add dmadev API test Thread-Index: AQHXn/zxJaLXFfFs60u/bHkusfPjb6uQxIhw Date: Thu, 2 Sep 2021 14:11:24 +0000 Message-ID: References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <1630588395-2804-1-git-send-email-fengchengwen@huawei.com> <1630588395-2804-8-git-send-email-fengchengwen@huawei.com> In-Reply-To: <1630588395-2804-8-git-send-email-fengchengwen@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 54b87654-531d-4bec-fdf7-08d96e1b8c7b x-ms-traffictypediagnostic: PH0PR11MB4984: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0MLtnhaPVzeP9c/2K5Gs/Bp6rD2fM92UiHHNN97Ax37O4OlSsqHbmZrOjj1XFeFP1MZwwWPXUe6BRWWx5/KAjSXQOftIopXfyG3Itd3zkdsZLwNfEe2VSzxK/KrohmOPin6LVYFDhSve+jLxSv6OxaqyROEej0iUd9aHmbYrNd/ZjoMXmFKfC49ir7LF8XFZs9TxDoRGTU67ZRPypG0SnahSKPJ0VdXd/PelGAwi3q6rP78x4FGUWRUlFzdlv7gMPSw/5DOlHMEfpIRF8BLyfyfHsAY3QhFJkgvEWSxk48DjXVNs5GGyAN9bkJFAgbB1zNkfjcGjNZX+YaqeVe+OY6AH3xOKu0fzmycbwihJxh2e1wd7XQy3ql7jnyDmi0wcOAfwojEgCasknUzq1Ok6strrlqJr6dlYIDYFGjNgqSwkCzsDZXifP5IHpf1padLBXfB1NHNl8OWNWgdXGPGfDIG0u9nW+wHcj56ip0wqoZZq2kO6btiUl/Z+2D5ZSmtzGdHNAeWzhXsZOVH6n+Mnb3dWpEntwFBSEbu4Fdintqck8jPhghDbrrU7oIrlfo5l1OYicqoIz8CeKsTVJmXcbgwQB2R2aim37/vOBtz4z3iZ53UJR5TclR84uYEca1XNxeGH89Htpu1UnQH2EVBrJ+O0U3SdNeGI97wiaE1G13jnr52AzP7TeJ6sKti/NCjQouGk1Qy4/4h0/d/eyEDurA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5207.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(136003)(346002)(366004)(39860400002)(54906003)(316002)(4326008)(66556008)(52536014)(64756008)(55016002)(110136005)(2906002)(5660300002)(107886003)(71200400001)(66476007)(38070700005)(7696005)(33656002)(66946007)(9686003)(122000001)(8676002)(6506007)(66446008)(76116006)(7416002)(478600001)(38100700002)(26005)(8936002)(86362001)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ivdwxGeac43mc5e7zrl2r1eOHaZnXraZdyNysrcaDFrUYSLhcLiPqIct9Iza?= =?us-ascii?Q?pPYx4hgAxMOUd2g+wWI55JmjlE4R3y/yGrHxiGLG3bJT/l+cByHCBimsEdku?= =?us-ascii?Q?KzgSeP1g5o1gMYwcP1g4oy0RCEVFkRfBIkaYuZL+Obmy/PP7tD0dP+QTv/EA?= =?us-ascii?Q?CuDFS41xOvxkiQOmF9OzYwcwHBNm7m9WcJrfZkMOK8E5xTjMfhUPxxPHXos+?= =?us-ascii?Q?31e+Rf8a4o+mNtQZ6GwKY+dCO6f+mUl7z48vyxMiKyV/yk24D/E/QulikSbV?= =?us-ascii?Q?GCenCKoumpg30yZIA5nGyrCX3bRz2KmfZOj5m4k/cVzVSWl9L6SrdRC0H2P0?= =?us-ascii?Q?iQ6So+mDhPefMFNNHksiI9pj/scp8Iud6wbgAYU+/xA2MEtzMIxxMYA0K936?= =?us-ascii?Q?gNzQlXqC47py0N6pn/ErplPz9aY5m0KSeyGqdEZCyuS9jnxKkcNmy7yO+3EX?= =?us-ascii?Q?/EL23dDAbX0dDPytDAvREVDgQdCxFlkEuVhhWiZ9RLNoa9smJSYGn4/Ovyrt?= =?us-ascii?Q?vkj5Xcuvod+gokpBYP55HV+a31ft2PgCWOJzDppKXa2cyCD9Sha+2zLb4UpL?= =?us-ascii?Q?DvuHOI1jDtcfrGeVSMberiood9r6T05nMn+nkCdG3AT9QH70x9vRO+Cfg5i5?= =?us-ascii?Q?v7koh/0MT/LuxRY36beM/PlzkhhlUC7b2XYwGgrs/F42gfRAQ42spmY5D56h?= =?us-ascii?Q?3If6tf9u+Kq1PJEC13xeZhKFmAFlZarfRetCO2Kgc+PzrjGqTLZY7opRAlZW?= =?us-ascii?Q?ywDF4v2WZFoyhhlAaOrmzkK3LBBz4rcyfxfJgg1P1W3uRBle/8VmpRLiT+xy?= =?us-ascii?Q?UBmnKhCIAVzn/eb2p4VE/9p5S4z0Xxj1hnorwwSV/SqIZN35UOv99HpAMg7u?= =?us-ascii?Q?BXk6yESlH29uJE0JZZglNJwaPM+qRGJa3pPxgthMuRIFmC5+lzucaQiiCcxl?= =?us-ascii?Q?EIPg8efK1rTRzkJgSOH14V5odpX2++ICqJ6MXmLjOeneL7jR9Bi23BQlL76N?= =?us-ascii?Q?OsVHb55Wvvfyy9tOnrZiYJncJ2lbfT7nE1oiyPRKwKMk9zpQtN8VwaxaRqig?= =?us-ascii?Q?rOvICoXK8kVGpiwSZgi/ylVwRp/ctA0BP/kxyGQ1SWbWay8uRPIFbXFNv8qU?= =?us-ascii?Q?ixUtAVYUszn1ctuQm4Y7eHC/Ez3x6SkC9CVEPRVExUee157aCZ6TTcnvXiGz?= =?us-ascii?Q?BwMTBObJllUGo+9BVoHo0wxa3J8Bp5V5/NsjN1+czUiwtD6z+Xe9EkH4lTsD?= =?us-ascii?Q?sRzfSkib65aR7UI/GKc0Fqp7UqlazvPFEJEJD8dQAkRjUUa7zomQnziPgrxL?= =?us-ascii?Q?Zt0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5207.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54b87654-531d-4bec-fdf7-08d96e1b8c7b X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 14:11:24.7653 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nh83ZxsfqJBEuVj6xwHgAo2WykzyTOq5FFGvxrsP9LDdoceDf9JVK/2RY9CQM8XN7JOrjZsiPKphZBTQfmm96w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4984 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v19 7/7] app/test: add dmadev API test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Chengwen, The output from the API tests is not very straightforward to interpret if y= ou are not familiar with these tests. Could we change the log level of the dmadev library before and after the AP= I tests using something similar to=20 The code I have included inline below? > +static int > +testsuite_setup(uint16_t dev_id) > +{ > + test_dev_id =3D dev_id; > + invalid_dev_id =3D RTE_DMADEV_MAX_DEVS; > + > + src =3D rte_malloc("dmadev_test_src", TEST_MEMCPY_SIZE, 0); > + if (src =3D=3D NULL) > + return -ENOMEM; > + dst =3D rte_malloc("dmadev_test_dst", TEST_MEMCPY_SIZE, 0); > + if (dst =3D=3D NULL) > + return -ENOMEM; =09 /* Set dmadev log level to critical to suppress unnecessary output during = API tests. */ rte_log_set_level_pattern("lib.dmadev", RTE_LOG_CRIT); > + > + total =3D 0; > + passed =3D 0; > + failed =3D 0; > + > + return 0; > +} > + > +static void > +testsuite_teardown(void) > +{ > + rte_free(src); > + rte_free(dst); > + /* Ensure the dmadev is stopped. */ > + rte_dmadev_stop(test_dev_id); rte_log_set_level_pattern("lib.dmadev", RTE_LOG_INFO); > +} This change would bring your output down from: ### Test dmadev infrastructure using skeleton driver test_dmadev_get_dev_id Passed test_dmadev_is_valid_dev Passed test_dmadev_count Passed Invalid dev_id=3D64 test_dmadev_info_get Passed Invalid dev_id=3D64 Device 1 configure zero vchans Device 1 configure too many vchans Device 1 don't support silent test_dmadev_configure Passed Invalid dev_id=3D64 Device 1 number of descriptors invalid Device 1 vchan out range! Device 1 direction invalid! Device 1 direction invalid! Device 1 don't support mem2dev transfer Device 1 don't support dev2mem transfer Device 1 don't support dev2dev transfer Device 1 number of descriptors invalid Device 1 number of descriptors invalid Device 1 source port type invalid Device 1 destination port type invalid test_dmadev_vchan_setup Passed Invalid dev_id=3D64 Invalid dev_id=3D64 Device 1 must be stopped to allow configuration Device 1 must be stopped to allow configuration test_dmadev_start_stop Passed Invalid dev_id=3D64 Invalid dev_id=3D64 Invalid dev_id=3D64 Device 1 vchan 1 out of range Device 1 vchan 1 out of range test_dmadev_stats Passed test_dmadev_completed Passed test_dmadev_completed_status Passed Device 1 already stopped Total tests : 10 Passed : 10 Failed : 0 skeldma_remove(): Remove dma_skeleton dmadev To: ### Test dmadev infrastructure using skeleton driver test_dmadev_get_dev_id Passed test_dmadev_is_valid_dev Passed test_dmadev_count Passed test_dmadev_info_get Passed test_dmadev_configure Passed test_dmadev_vchan_setup Passed test_dmadev_start_stop Passed test_dmadev_stats Passed test_dmadev_completed Passed test_dmadev_completed_status Passed Total tests : 10 Passed : 10 Failed : 0 skeldma_remove(): Remove dma_skeleton dmadev Thanks, Conor.