From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5208FC433EF for ; Mon, 2 May 2022 11:08:34 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 533EB40F35; Mon, 2 May 2022 13:08:33 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 044EF40E28 for ; Mon, 2 May 2022 13:08:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651489711; x=1683025711; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=xImBdqR0ZtRpKG6wdXvPrlY2rDEK6Ppu8Dvkso6yP4M=; b=YME0P/1po7doLTViU389FsKXeHepDO30v6zlHhD0W8wYANpYsU17CP+7 qNGkNy7PSnnr0iBIeRxyPebziUHPH7l0oRBrq6BIW6/q9vHMXqi68rtqP 4QGGA5hZ8nWnTs2nbqS6ldfFuX0yPFQxXHqCw5ocujKiILeum6UVYwLio aheRCIwRr+2+cZ0C64Wa6tCWFC7qIJmP9T6SKs2NplLLdSCc6vSHwTHeA h5c/19pLny/zoBbk9X0xWY/Ahf2CY22gRM03jZC63r31wo/deXAGdVapq F+MtgI05uyahN0qAuOQCQfNO1lJi+kEIuRzxFHdYlw3Az6Ffyp7sb6vjn g==; X-IronPort-AV: E=McAfee;i="6400,9594,10334"; a="247733195" X-IronPort-AV: E=Sophos;i="5.91,190,1647327600"; d="scan'208";a="247733195" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2022 04:08:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,190,1647327600"; d="scan'208";a="583645472" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 02 May 2022 04:08:28 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 2 May 2022 04:08:27 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 2 May 2022 04:08:27 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 2 May 2022 04:08:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iPu3p+lCCLFZROAjv2vmn5QuYyLrx2y9sTtXIebWZXLprkkz1GLePp5hx27UAQphu8tJdYNHoN2exH1XRZh5N1OQcyHjrxXwd2lCX9aTHJZ21JcXMFJ+vWItZ02fo9Cwn9thHnFM4E5UbKz25Ou+etsz+qWi1ptUYEEpdeDtfUcNc8BEVxtdn2p918alSlhowwRsLK8WCkERQ5uOLMFXy4rVcMksHogEixSFUltt9z0m+CSioTdyi1aBQt7aunz8J3Re8ZDCFLMDxnXBRVdUKL1468CI80P/U8S1NgWg4u0LUjYp2NZTfw0olWVYZFrPsw34CIhqOxeQUvq2vENCUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U1BEJpXviWLg2bPtn12hnrmotiyPiSn3Lv2aDAk6fm4=; b=nphWhMeN9jsK980T2ALzLLWWwwh2zUXD0R5D6+Vgbkqj/6y2fCRR4dq46jt2a0Dgjf/sWmzR+dC8yyWcOh7g4rb4w3lpGZVvPRlna1BKwp6coFZOYTMm08CQZRSAiYhfiNlG3z3Roswni2FkW6DxUvWkiRp5KgK+uSSN7iRE7inlrETu2fIngNrQ5V+pC54G7smGu/NBgWaWCsjaXihIw/pWDWiEAEL+GtcilNWOVzResjK+W1ZcKMEJUFAkzWB2AimE2KzxzBgxX0rU/xYtdaQUM9vABWqWLXPEHDLqvxlqgSg/4XYidG4Qy5W3/ZZpbq9qVzCuUV8u49iw7KGgkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5832.namprd11.prod.outlook.com (2603:10b6:510:141::7) by MN2PR11MB3694.namprd11.prod.outlook.com (2603:10b6:208:f7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 2 May 2022 11:08:25 +0000 Received: from PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ad86:86fe:a02b:174f]) by PH0PR11MB5832.namprd11.prod.outlook.com ([fe80::ad86:86fe:a02b:174f%5]) with mapi id 15.20.5186.028; Mon, 2 May 2022 11:08:25 +0000 From: "Gujjar, Abhinandan S" To: Akhil Goyal , "dev@dpdk.org" CC: "anoobj@marvell.com" , "jerinj@marvell.com" , "Jayatheerthan, Jay" , "Vangati, Narender" , "vfialko@marvell.com" Subject: RE: [PATCH v4 0/7] Add new cryptodev op for event metadata Thread-Topic: [PATCH v4 0/7] Add new cryptodev op for event metadata Thread-Index: AQHYXZE8aNXApaYgb0CpptaCnKq8+a0Lbrtw Date: Mon, 2 May 2022 11:08:25 +0000 Message-ID: References: <20220421143720.1583062-1-gakhil@marvell.com> <20220501192457.3670278-1-gakhil@marvell.com> In-Reply-To: <20220501192457.3670278-1-gakhil@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.15 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 79ee0b05-40eb-4d2a-0e72-08da2c2c1411 x-ms-traffictypediagnostic: MN2PR11MB3694:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ivfoADRBhESmr5GQinoRbW1CbESoljxOi8/D/SnkENO/WSQxTLUZMcRTytySs3MertZoeZaYJCpeOLUoHehU9j1LN8O2fM85NrXrademlCCtwEfaFjDKfS8GLCfmGh16u6SVYrRNdZJv2/sU4+fUg8kasxDWQIKUKiCeVc1NuZKhXVmTm4oIBn+VJ4MzFo6wWETE80Zu3zBWeJGcINRkx0v1uvlvjTa5jHFfH/4tmxj+MVCF+Ed0dUZgjdo1Es5LUl9xgn5z4A3FArs9f+eK5+lioPhWTQzlJapB5ppuIClhrFCyScORjXPbIl0VNxWPQpLpRRHrKwpJgxxaD8aRri4HcIFJ/C2hMm6kZeVgysVREEAfso8X0kKov5jFnxvjEKSZOs8k5TsVp5urDEKK5DYGFNqqZKjx7gbnHXdN6qpKI5vD74MyqTnHDBE1xh5OPy8KraHVs6rnWo/mBUyjo4sE5XQYjazaKwGDP8peP+9vcRlaCLoQ7IzjB9VcYRWXbyBWroZt1BthNsUqsdSuqjKAM9fA5Nx20FzFkdkbooEx3zrQRwzAlFstgGIlq3FE/nD4vWBfhlMbcZj7TLUz1w+LIrHbHEj9B6tWTMP00OLzAoVRB3cyb50OZ+jC1bkjncfcZaYFWAF8B5wsfB0b08CoahMBW2XPXrJs+Ca3XG1WzGQwUFLl7RcfomyK7AiPrNyzNMHzphzSCAwCifyx8w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5832.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(110136005)(86362001)(33656002)(8676002)(66556008)(4326008)(66476007)(66946007)(76116006)(64756008)(508600001)(66446008)(55016003)(71200400001)(54906003)(316002)(38100700002)(38070700005)(2906002)(83380400001)(186003)(8936002)(5660300002)(9686003)(6506007)(7696005)(122000001)(26005)(53546011)(82960400001)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IggkEoVdnBLgXwc/39axLtaAYfrMLa+bNnCqsmdCzrwh9VCBpmY5BDZkgr1l?= =?us-ascii?Q?8rX1Rm6vbcyVsrNzSGvLVWmjZ84eTMrsFuS/djRapWZSKlsHeaf0fKg2O1zE?= =?us-ascii?Q?Tc+n1eLtRM1RYld/zmX2q7wvdulAVaHK6olE9vQB+4fs57fwDM/vp6D61vsZ?= =?us-ascii?Q?Ec9JAhb5ClcqRT+/qFMyPDk7YBioimofJiohu1D0MG8K+s37rfDQT6RGvmxu?= =?us-ascii?Q?st0yws5btWSFgLk+dk8eSWmNsXyuUgbBGXdsqm4basBCqIJ2NeTFuRzs0kJu?= =?us-ascii?Q?4SCXgbNVpasxJuY8nVsX7ChQRWtFt3RwFB0dPmVstJVtSGuLup37UizacGu5?= =?us-ascii?Q?hJGi8WW69/92QkFi8cc3L9e7cjK3irwsXCP3fKta9oKjoy+tsEv0jq+jWMpB?= =?us-ascii?Q?lYlw01tq7OmBm1Z2i1oZr7dE1DvhTtXigwxWB7NFjEPVzaBRbijj/YcTKqeR?= =?us-ascii?Q?UJju1IRyjWzoti29PHSPrcw/9lk7rl+JjDezLwZzk/YjAWtpX5s8R/hfwXwB?= =?us-ascii?Q?pCg3sHySZGap9VA6YOvO0ddldApVeH/Mp98L3v7I6QYhMVWUzmAQBni8g9AZ?= =?us-ascii?Q?1bSVByZFvhoi7llj15ZFkDFc4SDGM2P9QGKpfotqxCUDutWXWJ0jzU28aCWw?= =?us-ascii?Q?TDJqU4QPd0hK7HWmYX/OqjqZpkUgBwduc1uG8IqfzJIBxeI5k664Ro3rO9c1?= =?us-ascii?Q?NddQ2DJdXQPUy6yTUThkOSJlw7bDkR/pwfjCGYGVrEt9fkb3W9O2uPy9vbj4?= =?us-ascii?Q?Er2PVkjuMJB6p1VbipAPtgKwn0SWAyDuhbS225UxMyOZ/MrWAiRclRZXikPR?= =?us-ascii?Q?Nz4KOZZ7F0p5WFoKUwQnBGsecXK0xp3N6vwjsrf+dTMdyd91vFGY+2ma/5qU?= =?us-ascii?Q?hys+NXUbP3/lS3F846cn0axNzJ4SEAEJ4n9nCbvDcFmzvGVPYhGjOUyBi/bz?= =?us-ascii?Q?6FjSaSn+yMux7S518jh8dFF++whvIo21ob9EZ2qlII8BBP7LvE5Ay3QBn/Ag?= =?us-ascii?Q?mpB9VGfKjFpRSkZ4OP+b22x44YEo43WvaS5YJeQyUrb+b5Zbfr8hvA5RedvZ?= =?us-ascii?Q?RN6cHXU2hcTlOzrDZrWpyQbXn54uN+M15uqnDcy5l6FitMEXpeyyzmFYOqfE?= =?us-ascii?Q?EXEUitB5xfPJsdUckoaMXVMonZnjNQJRnNMgVDPwKlKwq3/wv1rNZA0MyeC2?= =?us-ascii?Q?YrgbKEbow02wZKwLSBc2576CZTbJFq036qjVUIJyEA9YHNLv3cPd/1SfztE4?= =?us-ascii?Q?kWYSivhWY1Wog0Y2pJSriSfOZNUlphn/B7QUgflLEGhAH1taho0rWonpoNro?= =?us-ascii?Q?zF8Wt5gl/wHLyQyagAYSjsAYgDTG1wQqB8S5MRovL1A1+Rm4FYExFa01Vo01?= =?us-ascii?Q?2tkktgh2XJdHksGCoFZyu9hPAgNk5Ez4IVb5tlKr2kdxGVkDOMgnvKyWJ3bq?= =?us-ascii?Q?kiZPgrfbPvY+rv61WxiGnP/SYIjKwSbXByHBuKp8Q3+lRYIPi8rbmbB/Txq8?= =?us-ascii?Q?mBrvrcVziVnyT8qGrR7kWdK+Sl6KKneU6cNcbRFBIMPt2DXTOtIuqQQXTmQu?= =?us-ascii?Q?la+Y7cK4+68/DvMCtBpQlwvFeABps7q06ToyedieLHizOk4o2Q1Eg9vSn3yn?= =?us-ascii?Q?Ef8CBqTSE5LQ/ipvtfvr0oscQ96f+M5bwCxHm59km3+m/YVmz1d7qvqupNqW?= =?us-ascii?Q?TGCwDIJzvutBMfwBmBt3X6yicFb/S2aRtwE4QNFYwiU8K4hP96DKTsH89DjX?= =?us-ascii?Q?DBi3puLpdTAa82F2IdZMmuBJnQuYjOc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5832.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79ee0b05-40eb-4d2a-0e72-08da2c2c1411 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2022 11:08:25.2567 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h6qG+rs0qt/pK25UDIZq4KcSUNXm+MbCi3H5KnqySMA3ZOffBKUWGUtBh9BB6DYvZ5qoPvyq3xZIbHxe7n7k0GRJi45pykMVRMkZHlMvgHQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3694 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Abhinandan Gujjar > -----Original Message----- > From: Akhil Goyal > Sent: Monday, May 2, 2022 12:55 AM > To: dev@dpdk.org > Cc: anoobj@marvell.com; jerinj@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfialko@marvell.com; Akhil Goyal > > Subject: [PATCH v4 0/7] Add new cryptodev op for event metadata >=20 > For using event crypto metadata, event metadata need to be set in session= . For > this session user data was used for symmetric crypto sessions and no supp= ort > was present for asymmetric and security sessions. > The use of userdata to store event metadata (which is dereferenced in PMD= ) is > not correct as it is meant for the application to use it. > Hence, a new API is created to set and get event crypto metadata which is > scalable to all sessions supported by the crypto PMD. > The application can use the set API to set event metadata and the PMD may > store that inside the session private data and PMD need not use the get A= PI as > it would be internal to the PMD. > For the software event crypto adapter implementation, the eventdev librar= y > can use the get API to get the event metadata stored inside the session > structure. > For Asymmetric sessions, a new field is added inside the session struct w= hich is > internal to library. > For symmetric and security sessions, new field cannot be added as it woul= d be > ABI break. Hence, session userdata is being used to store that as it was = used > earlier. In next ABI break release this would be fixed similar to asymmet= ric > crypto case. >=20 > The patchset also add support for asymmetric crypto adapter in the test > applications and the crypto/cnxk implementation of the new cryptodev op a= nd > corresponding changes in the eventdev lib. >=20 > Changes in v4: > - added null checks in set API > - updated check in session destroy > - updated API comments > - fixed test app failure reported by Abhinandan. > - moved event mdata after padding in asym session struct. >=20 > Changes in v3: > - fix SW adapter case of memory allocation/free of mdata. mdata is alloca= ted in > set API and freed in session clear/destroy. > - mark rte_cryptodev_session_event_mdata_get as internal API as it is onl= y > needed for the app or the PMD. >=20 > changes in v2: > - v1 patchset only fixed security sessions and also caused ABI breakage. > This is fixed in v2. > - added new API for setting event metadata. > - added new cryptodev op which can handle all sessions >=20 >=20 > Akhil Goyal (5): > crypto/octeontx: use new API for event metadata > test/event: use new API to set event crypto metadata > eventdev: use new API to get event crypto metadata > test/event: add asymmetric cases for crypto adapter > test-eventdev: support asym ops for crypto adapter >=20 > Volodymyr Fialko (2): > cryptodev: add APIs to get/set event metadata > crypto/cnxk: add event metadata set operation >=20 > app/test-eventdev/evt_common.h | 2 + > app/test-eventdev/evt_options.c | 17 + > app/test-eventdev/evt_options.h | 4 + > app/test-eventdev/test_perf_atq.c | 12 +- > app/test-eventdev/test_perf_common.c | 254 ++++++++-- > app/test-eventdev/test_perf_common.h | 45 +- > app/test-eventdev/test_perf_queue.c | 12 +- > app/test/test_event_crypto_adapter.c | 511 +++++++++++++++++++- > doc/guides/tools/testeventdev.rst | 5 + > drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 144 +++++- > drivers/crypto/cnxk/cn10k_ipsec.h | 2 + > drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 138 +++++- > drivers/crypto/cnxk/cn9k_ipsec.h | 2 + > drivers/crypto/cnxk/cnxk_ae.h | 2 + > drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 18 - > drivers/crypto/cnxk/cnxk_se.h | 2 + > drivers/crypto/octeontx/otx_cryptodev_ops.c | 20 +- > lib/cryptodev/cryptodev_pmd.c | 16 + > lib/cryptodev/cryptodev_pmd.h | 36 ++ > lib/cryptodev/rte_cryptodev.c | 44 ++ > lib/cryptodev/rte_cryptodev.h | 22 + > lib/cryptodev/version.map | 4 + > lib/eventdev/rte_event_crypto_adapter.c | 55 +-- > 23 files changed, 1179 insertions(+), 188 deletions(-) >=20 > -- > 2.25.1