[virtio-comment] RE: [PATCH v1] virtio-network: Clarify VLAN filter table configuration

[Parav Pandit <parav@nvidia.com>]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Tuesday, January 3, 2023 5:56 AM
> 
> > +
> > +When VIRTIO_NET_F_CTRL_VLAN is not negotiated, the device accepts all
> > +VLAN tagged packets which matches  device's filter configuration.
> 
> which match the device's
> 
> > +
> > +When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device starts with
> > +empty
> 
> an empty
> 
> > +VLAN filtering table.
> > +
> > +When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device accepts all the
> 
> all the -> all
> 
> > +VLAN tagged packets whose VLAN tag is found in the VLAN filtering
> > +table; device should drop all VLAN tagged packets whose VLAN tag is
> > +not found
> 
> the device
> 
> > +in the VLAN filtering table.
> > +
> > +When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device accepts all
> > +untagged packets which matches device's
> 
> 
> which match the device's ...
> 
> > filter configuration.
> 
> This confusing, took me several reads to understand.
> E.g. with promisc we accept all packets, it is not necessary about a match.
> I suggest "
> Filtering of untagged packets is not affected by whether
> VIRTIO_NET_F_CTRL_VLAN is or is not negotiated.
> "
>
Make sense.
I simplified the wordings now.
Also fixed above comments in v2.
Thanks.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/