All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hariprasad Kelam <hkelam@marvell.com>
To: "Peter Münster" <pm@a16n.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Michael Chan <michael.chan@broadcom.com>
Subject: [PATCH net v4] net: b44: set pause params only when interface is up
Date: Thu, 25 Apr 2024 05:20:35 +0000	[thread overview]
Message-ID: <PH0PR18MB44741DFBDDF3AA7ADB9F2DDADE172@PH0PR18MB4474.namprd18.prod.outlook.com> (raw)
In-Reply-To: <87y192oolj.fsf@a16n.net>


Understood, this patch fixes the panic issue.
 See inline for few comments,

> b44_free_rings() accesses b44::rx_buffers (and ::tx_buffers) unconditionally,
> but b44::rx_buffers is only valid when the device is up (they get allocated in
> b44_open(), and deallocated again in b44_close()), any other time these are
> just a NULL pointers.
> 
> So if you try to change the pause params while the network interface is
> disabled/administratively down, everything explodes (which likely netifd tries
> to do).
> 
> Link: https://github.com/openwrt/openwrt/issues/13789
> Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2)
> Cc: stable@vger.kernel.org
> Reported-by: Peter Münster <pm@a16n.net>
> Suggested-by: Jonas Gorski <jonas.gorski@gmail.com>
> Signed-off-by: Vaclav Svoboda <svoboda@neng.cz>
> Tested-by: Peter Münster <pm@a16n.net>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Peter Münster <pm@a16n.net>
> ---
>  drivers/net/ethernet/broadcom/b44.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/b44.c
> b/drivers/net/ethernet/broadcom/b44.c
> index 3e4fb3c3e834..1be6d14030bc 100644
> --- a/drivers/net/ethernet/broadcom/b44.c
> +++ b/drivers/net/ethernet/broadcom/b44.c
> @@ -2009,12 +2009,14 @@ static int b44_set_pauseparam(struct net_device
> *dev,
>  		bp->flags |= B44_FLAG_TX_PAUSE;
>  	else
>  		bp->flags &= ~B44_FLAG_TX_PAUSE;
> -	if (bp->flags & B44_FLAG_PAUSE_AUTO) {
> -		b44_halt(bp);
> -		b44_init_rings(bp);
> -		b44_init_hw(bp, B44_FULL_RESET);
> -	} else {
> -		__b44_set_flow_ctrl(bp, bp->flags);
> +	if (netif_running(dev)) {
> +		if (bp->flags & B44_FLAG_PAUSE_AUTO) {
> +			b44_halt(bp);
> +			b44_init_rings(bp);
> +			b44_init_hw(bp, B44_FULL_RESET);
> +		} else {
> +			__b44_set_flow_ctrl(bp, bp->flags);
> +		}
>  	}
The actual register config to enable pause frame is protected with "netif_running", does driver need to
reject the request if interface is down.
Otherwise, there is mismatch if someone reads pause frame status (b44_get_pauseparam).


Thanks,
Hariprasad k
>  	spin_unlock_irq(&bp->lock);
> 
> --
> 2.35.3


  parent reply	other threads:[~2024-04-25  5:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 13:51 [PATCH net v4] net: b44: set pause params only when interface is up Peter Münster
2024-04-24 16:37 ` Michael Chan
2024-04-25  5:20 ` Hariprasad Kelam [this message]
2024-04-25 15:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB44741DFBDDF3AA7ADB9F2DDADE172@PH0PR18MB4474.namprd18.prod.outlook.com \
    --to=hkelam@marvell.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pm@a16n.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.