From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B74C77B7D for ; Thu, 18 May 2023 11:31:19 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A51A40E25; Thu, 18 May 2023 13:31:18 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 060864014F for ; Thu, 18 May 2023 13:31:16 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34I7HHUq004683; Thu, 18 May 2023 04:31:15 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3qmyexbtmh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 May 2023 04:31:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EF3vsdNGTdAMS6MVgv4MB0/idIVaXfAgEfqLkT0G6UZHOjPUqeCLoTcU9urmntQFky50m13+SE54NYd2vPKdh76tB/RBEjpvZoxBUwvIW74D8UFv9H8mAfjd/hZEUSE+Azq8cM+/QCXcY8+Cw7ZnowAkeVFo/vepf68O52iLUpDHTKDo6B2LkZ+skP/FUs792oQ5pYFF/+qlkVmsJS2avntZljpGUD8GfRtKx23ecS0S9hKNJc3n7CScnNewjAaWAFi+CXdAg6T1xQ56LvD5ltWLVv4o0scSsC70AZOWWS+alGcN9HZFSjDcmNJm8WJ4ItBT4CVrLpA51+bWhojzHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fZr2/U0cWujH+hFNHQBxIJl/TSlp6Z+jZ7ZVd8Gg/ss=; b=J7Lvp6N97NWxxar56UowBIj/GsxF28laAv7m8cxVpYnDiwZs2v3GcZf5QBGd5IcR1GF2J4YoeSzI5UwwQ2IoJko/NKqVGQ9SJt4J1z/3A8JINDqejPiGsqxl7oQXiyqJZJ1z3wmHHNHJjj2R+TfFyNNxTHiz5vWYTXJCX8uQOxx4Xp30SYA94rxHer0bYsyt/Z4Hrx8Ne4oAw0///qGjDyaGy3F+tphgOElSMgkrKJpOPO3e2JsW+xhdanz5sPVhgkdNWbHOWwlmMpfaNVFMkWF23J593MRc0ythlwB9hDDgpJp0i3rB+HHpq/Q5oxFB5LDidByq10LnaBEpXiExvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fZr2/U0cWujH+hFNHQBxIJl/TSlp6Z+jZ7ZVd8Gg/ss=; b=WRnXL4Nv6DSwsjdzdPtiIZsDa7q1CJsjVescHCl+dDabCyUshAYRWPoQfg7ZelcV8XN675JgtjET3bS6e7QNmRBE+frGp2xIOAvmVlkCOccvBfyNhSML8owRblUFm1hjTEzZavZ2+2rzA6QUE+AVVu/60Ar7xx7AGfTDv6tfvTE= Received: from PH0PR18MB4672.namprd18.prod.outlook.com (2603:10b6:510:c9::16) by BL0PR18MB2324.namprd18.prod.outlook.com (2603:10b6:207:43::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 11:31:12 +0000 Received: from PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::9225:bda3:4faa:a84b]) by PH0PR18MB4672.namprd18.prod.outlook.com ([fe80::9225:bda3:4faa:a84b%4]) with mapi id 15.20.6411.019; Thu, 18 May 2023 11:31:12 +0000 From: Anoob Joseph To: Akhil Goyal , Thomas Monjalon , Jerin Jacob Kollanukkaran , Konstantin Ananyev , Bernard Iremonger CC: Hemant Agrawal , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Kiran Kumar Kokkilagadda , Volodymyr Fialko , "dev@dpdk.org" , Olivier Matz Subject: RE: [PATCH v2 09/22] app/test: add lib pdcp tests Thread-Topic: [PATCH v2 09/22] app/test: add lib pdcp tests Thread-Index: AQHZiV9CJJXkut22L0qulNM/fp/Yz69f4QbA Date: Thu, 18 May 2023 11:31:11 +0000 Message-ID: References: <20221222092522.1628-1-anoobj@marvell.com> <20230414174512.642-1-anoobj@marvell.com> <20230414174512.642-10-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-rorf: true x-dg-ref: =?iso-8859-1?Q?PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcYW5vb2JqXG?= =?iso-8859-1?Q?FwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0?= =?iso-8859-1?Q?YmEyOWUzNWJcbXNnc1xtc2ctN2I1MTM0NTEtZjU2Zi0xMWVkLTljNTItNG?= =?iso-8859-1?Q?MwMzRmNWY5YjRmXGFtZS10ZXN0XDdiNTEzNDUzLWY1NmYtMTFlZC05YzUy?= =?iso-8859-1?Q?LTRjMDM0ZjVmOWI0ZmJvZHkudHh0IiBzej0iNTE2MCIgdD0iMTMzMjg4OD?= =?iso-8859-1?Q?MwNjg3Nzc0MTIyIiBoPSJ1WTA0Q2JnbXdpOWJZaGlVWk9zazFENjFOaG89?= =?iso-8859-1?Q?IiBpZD0iIiBibD0iMCIgYm89IjEiIGNpPSJjQUFBQUVSSFUxUlNSVUZOQ2?= =?iso-8859-1?Q?dVQUFNZ01BQUNxQmF3OWZJblpBWTBzMkhZckxUWDFqU3pZZGlzdE5mVVVB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBSEFBQUFCWURBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBRUFBUUVCQUFBQTQrVXREQUNBQVFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUo0QUFBQmhBR1FBWkFCeUFHVUFjd0J6QUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQU?= =?iso-8859-1?Q?dNQWRRQnpBSFFBYndCdEFGOEFjQUJsQUhJQWN3QnZBRzRBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFDZUFBQUFZd0IxQUhN?= =?iso-8859-1?Q?QWRBQnZBRzBBWHdCd0FHZ0Fid0J1QUdVQWJnQjFBRzBBWWdCbEFISUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQkFBQUFBQUFBQUFJQUFBQUFBSjRBQUFCakFIVUFjd0IwQUc4QW?= =?iso-8859-1?Q?JRQmZBSE1BY3dCdUFGOEFaQUJoQUhNQWFBQmZBSFlBTUFBeUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-refone: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFBQW5nQU?= =?iso-8859-1?Q?FBR01BZFFCekFIUUFid0J0QUY4QWN3QnpBRzRBWHdCckFHVUFlUUIzQUc4?= =?iso-8859-1?Q?QWNnQmtBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQVl3QjFB?= =?iso-8859-1?Q?SE1BZEFCdkFHMEFYd0J6QUhNQWJnQmZBRzRBYndCa0FHVUFiQUJwQUcwQW?= =?iso-8859-1?Q?FRQjBBR1VBY2dCZkFIWUFNQUF5QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFCQUFBQUFBQUFBQUlBQUFBQUFKNEFBQUJqQUhVQWN3QjBBRz?= =?iso-8859-1?Q?hBYlFCZkFITUFjd0J1QUY4QWN3QndBR0VBWXdCbEFGOEFkZ0F3QURJQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBRUFBQUFBQUFBQUFnQUFBQUFBbmdBQUFHUUFiQUJ3QUY4QWN3QnJBSGtB?= =?iso-8859-1?Q?Y0FCbEFGOEFZd0JvQUdFQWRBQmZBRzBBWlFCekFITUFZUUJuQUdVQVh3Qj?= =?iso-8859-1?Q?JBREFBTWdBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFB?= =?iso-8859-1?Q?QUFBQUFDQUFBQUFBQ2VBQUFBWkFCc0FIQUFYd0J6QUd3QVlRQmpBR3NBWH?= =?iso-8859-1?Q?dCakFHZ0FZUUIwQUY4QWJRQmxBSE1BY3dCaEFHY0FaUUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reftwo: =?iso-8859-1?Q?QUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQmtBR3dBY0FCZk?= =?iso-8859-1?Q?FIUUFaUUJoQUcwQWN3QmZBRzhBYmdCbEFHUUFjZ0JwQUhZQVpRQmZBR1lB?= =?iso-8859-1?Q?YVFCc0FHVUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUdVQWJRQmhBR2tBYkFCZkFH?= =?iso-8859-1?Q?RUFaQUJrQUhJQVpRQnpBSE1BQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQURBQUFBQUFBQUFBQUFBQUFBUUFB?= =?iso-8859-1?Q?QUFBQUFBQUNBQUFBQUFDZUFBQUFiUUJoQUhJQWRnQmxBR3dBWHdCd0FISU?= =?iso-8859-1?Q?Fid0JxQUdVQVl3QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QWNnQmxBSE1BZEFC?= =?iso-8859-1?Q?eUFHa0FZd0IwQUdVQVpBQmZBR0VBYkFCdkFHNEFaUUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQkFBQUFBQUFBQU?= =?iso-8859-1?Q?FJQUFBQUFBSjRBQUFCdEFHRUFjZ0IyQUdVQWJBQmZBSEFBY2dCdkFHb0Fa?= =?iso-8859-1?Q?UUJqQUhRQVh3QnVBR0VBYlFCbEFITUFYd0J5QUdVQWN3QjBBSElBYVFCak?= =?iso-8859-1?Q?FIUUFaUUJrQUY4QWFBQmxBSGdBWXdCdkFHUUFaUUJ6QUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUVBQUFBQUFBQUFBZ0FBQUFB?= =?iso-8859-1?Q?QW5nQUFBRzBBWVFCeUFIWUFaUUJzQUd3QVh3QmhBSElBYlFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFRQUFBQUFBQUFBQ0FBQUFBQUNlQUFBQW?= =?iso-8859-1?Q?JRQmhBSElBZGdCbEFHd0FiQUJmQUhBQWNnQnZBR29BWlFCakFIUUFYd0Jq?= =?iso-8859-1?Q?QUc4QVpBQmxBSE1BQUFBQUFBQUFB?= x-dg-refthree: =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFCQUFBQUFBQU?= =?iso-8859-1?Q?FBQUlBQUFBQUFKNEFBQUJ0QUdFQWNnQjJBR1VBYkFCc0FGOEFjQUJ5QUc4?= =?iso-8859-1?Q?QWFnQmxBR01BZEFCZkFHTUFid0JrQUdVQWN3QmZBR1FBYVFCakFIUUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBRUFBQUFBQUFBQUFnQUFB?= =?iso-8859-1?Q?QUFBbmdBQUFHMEFZUUJ5QUhZQVpRQnNBR3dBWHdCd0FISUFid0JxQUdVQV?= =?iso-8859-1?Q?l3QjBBRjhBYmdCaEFHMEFaUUJ6QUY4QWNnQmxBSE1BZEFCeUFHa0FZd0Iw?= =?iso-8859-1?Q?QUdVQVpBQmZBRzBBWVFCeUFIWUFaUUJzQUd3QUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQVFBQUFBQUFBQUFDQUFBQUFBQ2VBQU?= =?iso-8859-1?Q?FBYlFCaEFISUFkZ0JsQUd3QWJBQmZBSEFBY2dCdkFHb0FaUUJqQUhRQVh3?= =?iso-8859-1?Q?QnVBR0VBYlFCbEFITUFYd0J5QUdVQWN3QjBBSElBYVFCakFIUUFaUUJrQU?= =?iso-8859-1?Q?Y4QWJRQmhBSElBZGdCbEFHd0FiQUJmQUc4QWNnQmZBR0VBY2dCdEFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUJBQUFBQUFBQUFBSUFBQUFBQUo0QUFBQnRBR0VB?= =?iso-8859-1?Q?Y2dCMkFHVUFiQUJzQUY4QWRBQmxBSElBYlFCcEFHNEFkUUJ6QUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFFQUFBQUFBQUFBQWdBQUFBQUFuZ0FBQUcwQVlRQnlBSFlBWl?= =?iso-8859-1?Q?FCc0FHd0FYd0IzQUc4QWNnQmtBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQU?= =?iso-8859-1?Q?FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFB?= =?iso-8859-1?Q?QUFBQUFBQUFBQUFBQUFBQUFBQUFB?= x-dg-reffour: QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBUUFBQUFBQUFBQUNBQUFBQUFBPSIvPjwvbWV0YT4= x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR18MB4672:EE_|BL0PR18MB2324:EE_ x-ms-office365-filtering-correlation-id: 1bc161a7-3873-4274-aee7-08db5793620a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q9HH5QrJ+RkYbCi8LLFVaDqHcfOO7BDLTL78fV3lrlCY1whz02n+qwfVLQyYPH7uGQG4es432iquXkTOwthOjWrCaRzAIvuV8XNEo9QtSoBS1lXwlLYnVKvW6QJUoI9tivjUuEduZ50ICdOxFCYlZJYgYBAQ2axZbf2YNAOhujGfUqS/62OGkiiQHG5sYM0HmgFfbNYYxiljOBdKGqO0ZkYCaUt8qFXPlPNMmgTFsShs+jjlKvAUjsHwgN8kjABR0yakqa0TnL19NgucI/l2sqSQfXRqixznD1x/DBUPq0OoFY76E+CZrOW18NLtCkO6aFch+fny4ZDcYfZb3k0TN1Ks65OY0hTiYuOXuupyJQoh060EH5/Lr4wXr2y5QkYaNu12+GT6nzIsQ9ZG4pQTgEKIbCkZL459zyJMn/USpHW/iDnhqxJGzw4fCS0z50Dnf47w7fzidQvzl0SVGHBf8Fs5ad65HZFKVvSQTzMXRwj74ctN4VlC4SipgXtAmOh5zvjqEqWH1acWTgpjenccBdI2rwEUe1gHXJYRT3u3og9JSMLg0Isth/av+R2vs+6BKirkOX0TFhOzTeL90Ib/CxpuVvnvH5tY+BKC8tB5kd6J6v5uPUONK4dihqdKai3/ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR18MB4672.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(366004)(376002)(346002)(39850400004)(451199021)(316002)(2906002)(478600001)(52536014)(41300700001)(4326008)(8936002)(8676002)(54906003)(110136005)(71200400001)(64756008)(66446008)(66476007)(66556008)(76116006)(66946007)(5660300002)(7696005)(53546011)(9686003)(6506007)(38100700002)(55016003)(122000001)(186003)(83380400001)(66574015)(38070700005)(86362001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?lm8LV225WTXO5VcaqMgaWXGPLrfiHBuNiLBL8d0eS9TTif/bZc9ErBeQIE?= =?iso-8859-1?Q?FdednactzQALdINfBwwQ5uei/ZjU1WxmHUlna47Qr3QvNqg/GxG1xAox5L?= =?iso-8859-1?Q?H9OduhBZ21bxZfqRMAdvTEk74cnJB92kmf09ikicNoneu+ffBAiqryTLcU?= =?iso-8859-1?Q?kdmxrQaTlZQaegP1cwg6QQxivvJyQ1ZxN/pO6xWT7su03NhEkEY5o8nlXY?= =?iso-8859-1?Q?25tK6jDHUoTwX7qLHHMq3+h+Yott+X+giugMVOxyMgeiiSLnDRMlRjIJ4L?= =?iso-8859-1?Q?FBOaGeVYkOuobCGyRJ9KwrRhyLgg1OkzDx11YaKsW0ecmr68ruUyDuh3Ya?= =?iso-8859-1?Q?orgS+83DWoQRCyNFNbKdUFjVjjCvrf3x1qRbQrZS6kPSFZcuXnXSlsp9lb?= =?iso-8859-1?Q?YkMry7KWZZYGA6TfmT/zRh4FMhpTnLkDEDzhpdXhpDM0OidU7AWbsRoQZC?= =?iso-8859-1?Q?cGpABkNHRiCazoJE9wephiF6aLWtNxAAx+d9LSXSdMcHsTtsG6LXZyUFNc?= =?iso-8859-1?Q?/6C1tKebPbe6yhc11KI31tLsiNwgxd275g6yorq5Rr8SNLnHCIekRRk5Hy?= =?iso-8859-1?Q?v+3oInwHdmnZIXZTqZv+ZAYqMeLGQ9X2LGGKkb48hM9MpsE8CI16xTtdcw?= =?iso-8859-1?Q?S98MsLZ6CaXWzDhAqKKbbBRuUWXudhX9LoP/3SXnQrU1gniCg9z2RqE0/v?= =?iso-8859-1?Q?YlnUzC7JhuBxnzDFtn0nEmMLwNjb6BfLWVx41VtFIWfI4N0v/rjCZd6PBz?= =?iso-8859-1?Q?ErVa46WZ9NJqIuVGY5q91lTaW0pqp5gdCnXOivNwl5mmXt10D03ZPC/S9M?= =?iso-8859-1?Q?OqxrBku7BkVRIP4Er75A/LIWm4BI2/oHqipBU+NsS8Hx4Q+vQwn/kqD2X2?= =?iso-8859-1?Q?otdy9Z0J4+NBq5C3Z5x9eNNKcbOineHX9hAA5jK6Htc6N5duuNyKLjoriq?= =?iso-8859-1?Q?gaWAPwUY5PCiyHaIuZLrU5OvhsAgF8Fn19aH6zOBjxe2y/wSOknKx/7NJZ?= =?iso-8859-1?Q?IdrP1xIgTudxV6Sw2d+tDge0vVRAsJAvClm0gSxEuzN8491YNA4QxH7sE9?= =?iso-8859-1?Q?edowbcQ9akCHLrDJlpuMCMAw3i5t6s17p7BSW3I+Bxk4eV3J+eD+hW0nc0?= =?iso-8859-1?Q?oOQ16iZqr89/G8zALW/HkYrEgouPh1z7I5ClTIc0trkNc4L267q9a7xQ13?= =?iso-8859-1?Q?4/t5nrDwIE7Sg9qs0CrpB3x9f1q26R/5pqPNX1JxdE+u3Bb7Tmg0zT1J7v?= =?iso-8859-1?Q?55JbkOLFzc2QtlvFmc5kjNSKSaBFvvOT0+Vt+F5/46aDn7lRDtRZQLciMw?= =?iso-8859-1?Q?K9MdxgMNTPolqfK6LOuoMCrmI/CuRfkYHGrDbK8IUqyGukacAF/Qn6GvxP?= =?iso-8859-1?Q?7EkOHx302WqcSV+UGVALVj2BbeyvaQQ6cul5x0JSvWMHQLrF42rCJgi+tD?= =?iso-8859-1?Q?Uaj9HSHZxKdGioc8KcdwxM7qKiKUJvMIcClDVzMFjeWPmXffxBjoB/+Csp?= =?iso-8859-1?Q?HEoLPGfesil9ohZTWlFEK9/+yQEwRcDIzJN5i7TCfjadmUQh8i2nHTARQz?= =?iso-8859-1?Q?GLgefO0frjaAzDjngAsJOD4j0XjvMv2P2wTn9eske3OShwoQ2g=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4672.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc161a7-3873-4274-aee7-08db5793620a X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2023 11:31:11.9261 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A7s9+wIVNz0yMuwnE7mrtC4ml/ZDSCPqAHmigLpj+iRvIYs63MlMiUPydkqdJCy8lzKMtHnBAEvOuuA5DI27FQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR18MB2324 X-Proofpoint-GUID: f6nTsgKVZKd-ywjqvQXkRLXKvJdnd6WE X-Proofpoint-ORIG-GUID: f6nTsgKVZKd-ywjqvQXkRLXKvJdnd6WE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-18_09,2023-05-17_02,2023-02-09_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, Please see inline. Thanks, Anoob > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, May 18, 2023 1:34 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran ; > Konstantin Ananyev ; Bernard > Iremonger > Cc: Hemant Agrawal ; Mattias R=F6nnblom > ; Kiran Kumar Kokkilagadda > ; Volodymyr Fialko ; > dev@dpdk.org; Olivier Matz > Subject: RE: [PATCH v2 09/22] app/test: add lib pdcp tests >=20 > > diff --git a/app/test/meson.build b/app/test/meson.build index > > 52d9088578..0f658aa2ab 100644 > > --- a/app/test/meson.build > > +++ b/app/test/meson.build > > @@ -96,6 +96,7 @@ test_sources =3D files( > > 'test_meter.c', > > 'test_mcslock.c', > > 'test_mp_secondary.c', > > + 'test_pdcp.c', > > 'test_per_lcore.c', > > 'test_pflock.c', > > 'test_pmd_perf.c', > > diff --git a/app/test/test_cryptodev.h b/app/test/test_cryptodev.h > > index abd795f54a..89057dba22 100644 > > --- a/app/test/test_cryptodev.h > > +++ b/app/test/test_cryptodev.h > > @@ -4,6 +4,9 @@ > > #ifndef TEST_CRYPTODEV_H_ > > #define TEST_CRYPTODEV_H_ > > > > +#include > > +#include > > + >=20 > Can we remove these includes from here and add in test_pdcp.c directly? [Anoob] Why? 'test_cryptodev.h' already has many references to rte_cryptode= v symbols. Not including the dependencies is not correct. >=20 >=20 > > + if (conf->is_integrity_protected) { > > + if (conf->entity.pdcp_xfrm.pkt_dir =3D=3D > > RTE_SECURITY_PDCP_UPLINK) { > > + conf->entity.crypto_xfrm =3D &conf->a_xfrm; > > + > > + a_xfrm.auth.op =3D > RTE_CRYPTO_AUTH_OP_GENERATE; > > + a_xfrm.next =3D &conf->c_xfrm; > > + > > + c_xfrm.cipher.op =3D > > RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > + c_xfrm.next =3D NULL; > > + } else { > > + conf->entity.crypto_xfrm =3D &conf->c_xfrm; > > + > > + c_xfrm.cipher.op =3D > > RTE_CRYPTO_CIPHER_OP_DECRYPT; > > + c_xfrm.next =3D &conf->a_xfrm; > > + > > + a_xfrm.auth.op =3D RTE_CRYPTO_AUTH_OP_VERIFY; > > + a_xfrm.next =3D NULL; > > + } > > + } else { > > + conf->entity.crypto_xfrm =3D &conf->c_xfrm; > > + c_xfrm.next =3D NULL; > > + > > + if (conf->entity.pdcp_xfrm.pkt_dir =3D=3D > > RTE_SECURITY_PDCP_UPLINK) > > + c_xfrm.cipher.op =3D > > RTE_CRYPTO_CIPHER_OP_ENCRYPT; > > + else > > + c_xfrm.cipher.op =3D > > RTE_CRYPTO_CIPHER_OP_DECRYPT; > > + } > > + /* Update xforms to match PDCP requirements */ > > + > > + if ((c_xfrm.cipher.algo =3D=3D RTE_CRYPTO_CIPHER_AES_CTR) || > > + (c_xfrm.cipher.algo =3D=3D RTE_CRYPTO_CIPHER_ZUC_EEA3 || > > + (c_xfrm.cipher.algo =3D=3D RTE_CRYPTO_CIPHER_SNOW3G_UEA2))) > > + c_xfrm.cipher.iv.length =3D 16; > > + else > > + c_xfrm.cipher.iv.length =3D 0; > > + > > + if (conf->is_integrity_protected) { > > + if (a_xfrm.auth.algo =3D=3D RTE_CRYPTO_AUTH_NULL) > > + a_xfrm.auth.digest_length =3D 0; > > + else > > + a_xfrm.auth.digest_length =3D 4; >=20 > This if-else is not needed. If is_integrity_protected, digest_length shou= ld > always be 4. [Anoob] I had explained this in v1 patch set. Will try again. In PDCP, with AUTH_NULL it is expected to have 4 bytes of zeroized digest. With AUTH_NULL, it is lib PDCP which would add zeroized digest. No PMD curr= ently supported in DPDK supports non-zero digest with AUTH-NULL. Also, it i= s not specified what is the digest added in case of AUTH-NULL. > Also define a macro for MAC-I len. It is being used at multiple places. > Similarly for IV length macro can be defined. >=20 [Anoob] Agreed. You want me to introduce RTE_PDCP_MAC_I_LEN or something lo= cal would do? > > + > > + if ((a_xfrm.auth.algo =3D=3D RTE_CRYPTO_AUTH_ZUC_EIA3) || > > + (a_xfrm.auth.algo =3D=3D > RTE_CRYPTO_AUTH_SNOW3G_UIA2)) > > + a_xfrm.auth.iv.length =3D 16; > > + else > > + a_xfrm.auth.iv.length =3D 0; > > + } > > + > > + conf->c_xfrm =3D c_xfrm; > > + conf->a_xfrm =3D a_xfrm; > > + > > + conf->entity.dev_id =3D (uint8_t)cryptodev_id_get(conf- > > >is_integrity_protected, > > + &conf->c_xfrm, &conf->a_xfrm); > > + > > + if (pdcp_test_params[index].domain =3D=3D > > RTE_SECURITY_PDCP_MODE_CONTROL || > > + pdcp_test_params[index].domain =3D=3D > > RTE_SECURITY_PDCP_MODE_DATA) { > > + data =3D pdcp_test_data_in[index]; > > + hfn =3D pdcp_test_hfn[index] << > pdcp_test_data_sn_size[index]; > > + sn =3D pdcp_sn_from_raw_get(data, > > pdcp_test_data_sn_size[index]); > > + count =3D hfn | sn; > > + } >=20 > The above logic can go inside lib PDCP as well. > This is specific to PDCP and not user dependent. > You can reuse the pdcp_xfrm.hfn as well. >=20 [Anoob] Sorry, what exactly can go into lib PDCP? This snippet is reading S= N used in a test vector and constructs the count based on SN & HFN value fr= om vector.=20