All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Tharunkumar.Pasumarthi@microchip.com>
To: <andriy.shevchenko@linux.intel.com>,
	<Kumaravel.Thiagarajan@microchip.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
	<gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <macro@orcam.me.uk>,
	<jay.dolan@accesio.com>, <cang1@live.co.uk>,
	<u.kleine-koenig@pengutronix.de>, <wander@redhat.com>,
	<etremblay@distech-controls.com>, <jk@ozlabs.org>,
	<biju.das.jz@bp.renesas.com>, <geert+renesas@glider.be>,
	<phil.edworthy@renesas.com>, <lukas@wunner.de>,
	<UNGLinuxDriver@microchip.com>, <colin.i.king@gmail.com>
Subject: RE: [PATCH v5 tty-next 1/4] 8250: microchip: pci1xxxx: Add driver for quad-uart support.
Date: Fri, 25 Nov 2022 15:45:01 +0000	[thread overview]
Message-ID: <PH7PR11MB595813B2AB661CD50517DEB89B0E9@PH7PR11MB5958.namprd11.prod.outlook.com> (raw)
In-Reply-To: <Y3Xv6XOwddNq6Gmr@smile.fi.intel.com>

> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Thursday, November 17, 2022 1:55 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>
> Subject: Re: [PATCH v5 tty-next 1/4] 8250: microchip: pci1xxxx: Add driver for
> quad-uart support.
> 
> > +     case PCI_SUBDEVICE_ID_EFAR_PCI11414:
> > +             irq_idx = idx;
> > +             break;
> 
> Try to make this entire switch-case more compact. It's possible.

Hi Andy,
I am planning to use look-up table for this in-order to avoid computation within switch case. Does this approach sound good?

Thanks,
Tharun Kumar P

  parent reply	other threads:[~2022-11-25 15:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17  5:01 [PATCH v5 tty-next 0/4] 8250: microchip: pci1xxxx: Add driver for the pci1xxxx's quad-uart function Kumaravel Thiagarajan
2022-11-17  5:01 ` [PATCH v5 tty-next 1/4] 8250: microchip: pci1xxxx: Add driver for quad-uart support Kumaravel Thiagarajan
2022-11-17  8:25   ` Andy Shevchenko
2022-11-18  9:37     ` Tharunkumar.Pasumarthi
2022-11-18 10:42       ` Andy Shevchenko
2022-11-25 15:45     ` Tharunkumar.Pasumarthi [this message]
2022-11-25 18:03       ` Andy Shevchenko
2022-11-17  5:01 ` [PATCH v5 tty-next 2/4] 8250: microchip: pci1xxxx: Add serial8250_pci_setup_port definition in 8250_pcilib.c Kumaravel Thiagarajan
2022-11-17  6:55   ` Andy Shevchenko
2022-11-18  9:40     ` Tharunkumar.Pasumarthi
2022-11-18 10:43       ` Andy Shevchenko
2022-11-19  3:50         ` Tharunkumar.Pasumarthi
2022-11-19 12:05           ` Andy Shevchenko
2022-11-17 12:26   ` Ilpo Järvinen
2022-11-17  5:01 ` [PATCH v5 tty-next 3/4] 8250: microchip: pci1xxxx: Add RS485 support to quad-uart driver Kumaravel Thiagarajan
2022-11-17 12:24   ` Ilpo Järvinen
2022-11-17  5:01 ` [PATCH v5 tty-next 4/4] 8250: microchip: pci1xxxx: Add power management functions " Kumaravel Thiagarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR11MB595813B2AB661CD50517DEB89B0E9@PH7PR11MB5958.namprd11.prod.outlook.com \
    --to=tharunkumar.pasumarthi@microchip.com \
    --cc=Kumaravel.Thiagarajan@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=cang1@live.co.uk \
    --cc=colin.i.king@gmail.com \
    --cc=etremblay@distech-controls.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jay.dolan@accesio.com \
    --cc=jirislaby@kernel.org \
    --cc=jk@ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=macro@orcam.me.uk \
    --cc=phil.edworthy@renesas.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wander@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.