From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 112C610E1ED for ; Thu, 29 Dec 2022 05:11:11 +0000 (UTC) From: "Gupta, Nidhi1" To: "igt-dev@lists.freedesktop.org" Date: Thu, 29 Dec 2022 05:11:01 +0000 Message-ID: References: In-Reply-To: Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH7PR11MB6006728F645994B9F19B6925C5F39PH7PR11MB6006namp_" MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t v5 42/52] tests/i915/kms_draw_crc: Add support for Bigjoiner List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: --_000_PH7PR11MB6006728F645994B9F19B6925C5F39PH7PR11MB6006namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Tue, 2022-11-15 at 08:43 +0530, Bhanuprakash Modem wrote: >This patch will add a check to Skip the subtest if a selected pipe/output >combo won't support Bigjoiner or 8K mode. > >Example: >* Pipe-D wont support a mode > 5K >* To use 8K mode on a pipe then consecutive pipe must be available & free. > >V2: - Use updated helper name > >Signed-off-by: Bhanuprakash Modem >--- Reviewed-by: Nidhi Gupta >tests/i915/kms_draw_crc.c | 10 ++++------ >1 file changed, 4 insertions(+), 6 deletions(-) >diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c >index c2ac4721..01c3808c 100644 >--- a/tests/i915/kms_draw_crc.c >+++ b/tests/i915/kms_draw_crc.c >@@ -59,16 +59,14 @@ static void find_modeset_params(void) > { > enum pipe pipe; > >- igt_display_reset(&display); >- igt_display_commit(&display); >- > for_each_pipe_with_valid_output(&display, pipe, output) { >- igt_output_set_pipe(output, pipe); >+ igt_display_reset(&display); > >- mode =3D igt_output_get_mode(output); >- if (!mode) >+ igt_output_set_pipe(output, pipe); >+ if (!i915_pipe_output_combo_valid(&display)) > continue; > >+ mode =3D igt_output_get_mode(output); > pipe_crc =3D igt_pipe_crc_new(drm_fd, pipe, IG= T_PIPE_CRC_SOURCE_AUTO); > /*Only one pipe/output is enough*/ > break; --_000_PH7PR11MB6006728F645994B9F19B6925C5F39PH7PR11MB6006namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

On Tue, 2022-11-15 at 08:43 +0530, Bhanuprakash M= odem wrote:

>This patch will add a check to Skip the subtest = if a selected pipe/output

>combo won't support Bigjoiner or 8K mode.

> 

>Example:

>* Pipe-D wont support a mode > 5K<= /p>

>* To use 8K mode on a pipe then consecutive pipe= must be available & free.

> 

>V2: - Use updated helper name

> 

>Signed-off-by: Bhanuprakash Modem <bhanupraka= sh.modem@intel.com>

>---

Reviewed-by: Nidhi Gupta <nidhi1.gupta@intel.com&= gt;

>tests/i915/kms_draw_crc.c | 10 ++++------

>1 file changed, 4 insertions(+), 6 deletions(-)<= o:p>

>diff --git a/tests/i915/kms_draw_crc.c b/tests/i= 915/kms_draw_crc.c

>index c2ac4721..01c3808c 100644

>--- a/tests/i915/kms_draw_crc.c

>+++ b/tests/i915/kms_draw_crc.c

>@@ -59,16 +59,14 @@  static void find_modes= et_params(void)

> {

>         = ;    enum pipe pipe;

> 

>-        = ;   igt_display_reset(&display);

>-        = ;   igt_display_commit(&display);

>-

>         = ;    for_each_pipe_with_valid_output(&display, pipe, out= put) {

>-        = ;            &n= bsp;     igt_output_set_pipe(output, pipe);<= /p>

>+        = ;            &n= bsp;     igt_display_reset(&display);

>

>-        = ;            &n= bsp;     mode =3D igt_output_get_mode(output);

>-        = ;            &n= bsp;     if (!mode)

>+        = ;            &n= bsp;     igt_output_set_pipe(output, pipe);<= /p>

>+        = ;            &n= bsp;     if (!i915_pipe_output_combo_valid(&display= ))

>        =             &nb= sp;            =           continue;=

> 

>+        = ;            &n= bsp;     mode =3D igt_output_get_mode(output);

>        =             &nb= sp;       pipe_crc =3D igt_pipe_crc_new(drm_f= d, pipe, IGT_PIPE_CRC_SOURCE_AUTO);

>        =             &nb= sp;       /*Only one pipe/output is enough*/<= o:p>

>        =             &nb= sp;       break;

--_000_PH7PR11MB6006728F645994B9F19B6925C5F39PH7PR11MB6006namp_--