From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADBD0C433FE for ; Thu, 23 Dec 2021 13:42:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348665AbhLWNmm (ORCPT ); Thu, 23 Dec 2021 08:42:42 -0500 Received: from mail-4018.proton.ch ([185.70.40.18]:36748 "EHLO mail-4018.proton.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348679AbhLWNmf (ORCPT ); Thu, 23 Dec 2021 08:42:35 -0500 Date: Thu, 23 Dec 2021 13:42:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail; t=1640266953; bh=KcpuETzMNMdxDT2q0V4AwCRe4eDh3KXENxpCUjqyk4Q=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc; b=P1Q1DQglL3/H+NbZPwD5FQ5BU9Uxk6pxEJUlWRgkAN0OLEHRoQXT9P6vmQVgI4Shq qswBkVMsLvmRRHD/3SjdYOuBD/GGsV6atIzIAPtvsIcihzg+XQOhNKJ4S5zw4d90GD yw00fU5YY0aXBm/7z9QW1y6keFUYtpbhm6KU5cycwBKvr1TY5EinTkhSnF0bxps/kb vJWQQ7wnICVOxl/imolN69xOrpDSgPFAomrww24G1XS9mkDEk/KWt9aiTZ7c6IFz9B aSiRxt4r6e7O5KrjN0k2a+YJ9Dp9EVAP0/Mu3FzFpyLIEkg43paDmTiPHdA5LXgzCF ZLdjYyzNmAUHg== To: =?utf-8?Q?Ville_Syrj=C3=A4l=C3=A4?= From: Simon Ser Cc: =?utf-8?Q?Jos=C3=A9_Exp=C3=B3sito?= , airlied@linux.ie, alexandre.torgue@foss.st.com, benjamin.gaignard@linaro.org, linux-stm32@st-md-mailman.stormreply.com, marex@denx.de, linux-imx@nxp.com, intel-gfx@lists.freedesktop.org, tzimmermann@suse.de, s.hauer@pengutronix.de, rodrigo.vivi@intel.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, yannick.fertre@foss.st.com, linux-kernel@vger.kernel.org, philippe.cornu@foss.st.com, mcoquelin.stm32@gmail.com, dmitry.baryshkov@linaro.org, shawnguo@kernel.org Reply-To: Simon Ser Subject: =?utf-8?Q?Re:_[PATCH_v2_1/6]_drm/plane:_Make_format=5Fmod=5Fsupported_truly=C2=A0optional?= Message-ID: In-Reply-To: References: <20211222090552.25972-1-jose.exposito89@gmail.com> <20211222090552.25972-2-jose.exposito89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, December 23rd, 2021 at 12:56, Ville Syrj=C3=A4l=C3=A4 wrote: > > -=09/* If we can't determine support, just bail */ > > -=09if (!plane->funcs->format_mod_supported) > > -=09=09goto done; > > - > > =09mod =3D modifiers_ptr(blob_data); > > =09for (i =3D 0; i < plane->modifier_count; i++) { > > =09=09for (j =3D 0; j < plane->format_count; j++) { > > -=09=09=09if (plane->funcs->format_mod_supported(plane, > > +=09=09=09if (!plane->funcs->format_mod_supported || > > +=09=09=09 plane->funcs->format_mod_supported(plane, > > =09=09=09=09=09=09=09 plane->format_types[j], > > =09=09=09=09=09=09=09 plane->modifiers[i])) { > > So instead of skipping the whole loop you just skip doing anything > inside the loop? Can't see how that achieves anything at all. No, the check is skipped when the function isn't populated by the driver. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E10D6C433EF for ; Thu, 23 Dec 2021 13:42:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DD7B010E2AB; Thu, 23 Dec 2021 13:42:36 +0000 (UTC) Received: from mail-4018.proton.ch (mail-4018.proton.ch [185.70.40.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 381AA10E2AB for ; Thu, 23 Dec 2021 13:42:36 +0000 (UTC) Date: Thu, 23 Dec 2021 13:42:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail; t=1640266953; bh=KcpuETzMNMdxDT2q0V4AwCRe4eDh3KXENxpCUjqyk4Q=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc; b=P1Q1DQglL3/H+NbZPwD5FQ5BU9Uxk6pxEJUlWRgkAN0OLEHRoQXT9P6vmQVgI4Shq qswBkVMsLvmRRHD/3SjdYOuBD/GGsV6atIzIAPtvsIcihzg+XQOhNKJ4S5zw4d90GD yw00fU5YY0aXBm/7z9QW1y6keFUYtpbhm6KU5cycwBKvr1TY5EinTkhSnF0bxps/kb vJWQQ7wnICVOxl/imolN69xOrpDSgPFAomrww24G1XS9mkDEk/KWt9aiTZ7c6IFz9B aSiRxt4r6e7O5KrjN0k2a+YJ9Dp9EVAP0/Mu3FzFpyLIEkg43paDmTiPHdA5LXgzCF ZLdjYyzNmAUHg== To: =?utf-8?Q?Ville_Syrj=C3=A4l=C3=A4?= From: Simon Ser Subject: =?utf-8?Q?Re:_[PATCH_v2_1/6]_drm/plane:_Make_format=5Fmod=5Fsupported_truly=C2=A0optional?= Message-ID: In-Reply-To: References: <20211222090552.25972-1-jose.exposito89@gmail.com> <20211222090552.25972-2-jose.exposito89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Simon Ser Cc: marex@denx.de, mcoquelin.stm32@gmail.com, kernel@pengutronix.de, s.hauer@pengutronix.de, tzimmermann@suse.de, airlied@linux.ie, intel-gfx@lists.freedesktop.org, alexandre.torgue@foss.st.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, yannick.fertre@foss.st.com, linux-imx@nxp.com, benjamin.gaignard@linaro.org, rodrigo.vivi@intel.com, dmitry.baryshkov@linaro.org, =?utf-8?Q?Jos=C3=A9_Exp=C3=B3sito?= , shawnguo@kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, philippe.cornu@foss.st.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thursday, December 23rd, 2021 at 12:56, Ville Syrj=C3=A4l=C3=A4 wrote: > > -=09/* If we can't determine support, just bail */ > > -=09if (!plane->funcs->format_mod_supported) > > -=09=09goto done; > > - > > =09mod =3D modifiers_ptr(blob_data); > > =09for (i =3D 0; i < plane->modifier_count; i++) { > > =09=09for (j =3D 0; j < plane->format_count; j++) { > > -=09=09=09if (plane->funcs->format_mod_supported(plane, > > +=09=09=09if (!plane->funcs->format_mod_supported || > > +=09=09=09 plane->funcs->format_mod_supported(plane, > > =09=09=09=09=09=09=09 plane->format_types[j], > > =09=09=09=09=09=09=09 plane->modifiers[i])) { > > So instead of skipping the whole loop you just skip doing anything > inside the loop? Can't see how that achieves anything at all. No, the check is skipped when the function isn't populated by the driver. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0AD1C433EF for ; Thu, 23 Dec 2021 13:42:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1CD610E39A; Thu, 23 Dec 2021 13:42:42 +0000 (UTC) Received: from mail-41103.protonmail.ch (mail-41103.protonmail.ch [185.70.41.103]) by gabe.freedesktop.org (Postfix) with ESMTPS id A413910E39A for ; Thu, 23 Dec 2021 13:42:40 +0000 (UTC) Received: from mail-0301.mail-europe.com (mail-0301.mail-europe.com [188.165.51.139]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail-41103.protonmail.ch (Postfix) with ESMTPS id 4JKWbM0CTsz4x9N8 for ; Thu, 23 Dec 2021 13:42:39 +0000 (UTC) Authentication-Results: mail-41103.protonmail.ch; dkim=pass (2048-bit key) header.d=emersion.fr header.i=@emersion.fr header.b="P1Q1DQgl" Date: Thu, 23 Dec 2021 13:42:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail; t=1640266953; bh=KcpuETzMNMdxDT2q0V4AwCRe4eDh3KXENxpCUjqyk4Q=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc; b=P1Q1DQglL3/H+NbZPwD5FQ5BU9Uxk6pxEJUlWRgkAN0OLEHRoQXT9P6vmQVgI4Shq qswBkVMsLvmRRHD/3SjdYOuBD/GGsV6atIzIAPtvsIcihzg+XQOhNKJ4S5zw4d90GD yw00fU5YY0aXBm/7z9QW1y6keFUYtpbhm6KU5cycwBKvr1TY5EinTkhSnF0bxps/kb vJWQQ7wnICVOxl/imolN69xOrpDSgPFAomrww24G1XS9mkDEk/KWt9aiTZ7c6IFz9B aSiRxt4r6e7O5KrjN0k2a+YJ9Dp9EVAP0/Mu3FzFpyLIEkg43paDmTiPHdA5LXgzCF ZLdjYyzNmAUHg== To: =?utf-8?Q?Ville_Syrj=C3=A4l=C3=A4?= From: Simon Ser Message-ID: In-Reply-To: References: <20211222090552.25972-1-jose.exposito89@gmail.com> <20211222090552.25972-2-jose.exposito89@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] =?utf-8?q?=5BPATCH_v2_1/6=5D_drm/plane=3A_Make_forma?= =?utf-8?q?t=5Fmod=5Fsupported_truly=C2=A0optional?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Simon Ser Cc: marex@denx.de, mcoquelin.stm32@gmail.com, kernel@pengutronix.de, s.hauer@pengutronix.de, tzimmermann@suse.de, airlied@linux.ie, intel-gfx@lists.freedesktop.org, alexandre.torgue@foss.st.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, yannick.fertre@foss.st.com, linux-imx@nxp.com, benjamin.gaignard@linaro.org, dmitry.baryshkov@linaro.org, =?utf-8?Q?Jos=C3=A9_Exp=C3=B3sito?= , shawnguo@kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, philippe.cornu@foss.st.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thursday, December 23rd, 2021 at 12:56, Ville Syrj=C3=A4l=C3=A4 wrote: > > -=09/* If we can't determine support, just bail */ > > -=09if (!plane->funcs->format_mod_supported) > > -=09=09goto done; > > - > > =09mod =3D modifiers_ptr(blob_data); > > =09for (i =3D 0; i < plane->modifier_count; i++) { > > =09=09for (j =3D 0; j < plane->format_count; j++) { > > -=09=09=09if (plane->funcs->format_mod_supported(plane, > > +=09=09=09if (!plane->funcs->format_mod_supported || > > +=09=09=09 plane->funcs->format_mod_supported(plane, > > =09=09=09=09=09=09=09 plane->format_types[j], > > =09=09=09=09=09=09=09 plane->modifiers[i])) { > > So instead of skipping the whole loop you just skip doing anything > inside the loop? Can't see how that achieves anything at all. No, the check is skipped when the function isn't populated by the driver. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55FD3C433EF for ; Thu, 23 Dec 2021 13:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:References: In-Reply-To:Message-ID:Subject:Cc:From:To:Date:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5teNPwZh4pmMxDIopC5UGAkYgPSOIAV3FQx9lLAcXaE=; b=JXKQNM6uS82y03 nmEZyp162b11lt7fBOvUAzMxEIAVflyzDzXiBiW+srCL0cBgpOBn0tSyqkNDst5UCeXnj55zrTRGA a9/p7E87IlfLYXn1GLkfNIvfKtRTniQpphhH/G6nZqtunp7UopWX61WwUd1+iJWsbMgGTWeKl+gB4 eL7K6ZYoUxDRx3MIxMLUQnpgHJr/h4SBFVBoTo6a2Y9GoVkhp/DqempBDOAn0qi5iDT6x0r0eLS6q C95Aw7NNEnnLF6AXH9nFsvRecNIcwqJ+V0f31Jvz/XO17qV3ZxpAmH1jwVginNDEn8aF5shFNNztc 4YpF7MAP6ZW1zrKaSG9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0OMi-00CpUU-Ie; Thu, 23 Dec 2021 13:42:40 +0000 Received: from mail-4018.proton.ch ([185.70.40.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n0OMf-00CpTo-5Y for linux-arm-kernel@lists.infradead.org; Thu, 23 Dec 2021 13:42:39 +0000 Date: Thu, 23 Dec 2021 13:42:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail; t=1640266953; bh=KcpuETzMNMdxDT2q0V4AwCRe4eDh3KXENxpCUjqyk4Q=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc; b=P1Q1DQglL3/H+NbZPwD5FQ5BU9Uxk6pxEJUlWRgkAN0OLEHRoQXT9P6vmQVgI4Shq qswBkVMsLvmRRHD/3SjdYOuBD/GGsV6atIzIAPtvsIcihzg+XQOhNKJ4S5zw4d90GD yw00fU5YY0aXBm/7z9QW1y6keFUYtpbhm6KU5cycwBKvr1TY5EinTkhSnF0bxps/kb vJWQQ7wnICVOxl/imolN69xOrpDSgPFAomrww24G1XS9mkDEk/KWt9aiTZ7c6IFz9B aSiRxt4r6e7O5KrjN0k2a+YJ9Dp9EVAP0/Mu3FzFpyLIEkg43paDmTiPHdA5LXgzCF ZLdjYyzNmAUHg== To: =?utf-8?Q?Ville_Syrj=C3=A4l=C3=A4?= From: Simon Ser Cc: =?utf-8?Q?Jos=C3=A9_Exp=C3=B3sito?= , airlied@linux.ie, alexandre.torgue@foss.st.com, benjamin.gaignard@linaro.org, linux-stm32@st-md-mailman.stormreply.com, marex@denx.de, linux-imx@nxp.com, intel-gfx@lists.freedesktop.org, tzimmermann@suse.de, s.hauer@pengutronix.de, rodrigo.vivi@intel.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, yannick.fertre@foss.st.com, linux-kernel@vger.kernel.org, philippe.cornu@foss.st.com, mcoquelin.stm32@gmail.com, dmitry.baryshkov@linaro.org, shawnguo@kernel.org Subject: =?utf-8?Q?Re:_[PATCH_v2_1/6]_drm/plane:_Make_format=5Fmod=5Fsupported_truly=C2=A0optional?= Message-ID: In-Reply-To: References: <20211222090552.25972-1-jose.exposito89@gmail.com> <20211222090552.25972-2-jose.exposito89@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211223_054237_969155_89803BA1 X-CRM114-Status: UNSURE ( 6.00 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Simon Ser Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1cnNkYXksIERlY2VtYmVyIDIzcmQsIDIwMjEgYXQgMTI6NTYsIFZpbGxlIFN5cmrDpGzD pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgoKPiA+IC0JLyogSWYgd2Ug Y2FuJ3QgZGV0ZXJtaW5lIHN1cHBvcnQsIGp1c3QgYmFpbCAqLwo+ID4gLQlpZiAoIXBsYW5lLT5m dW5jcy0+Zm9ybWF0X21vZF9zdXBwb3J0ZWQpCj4gPiAtCQlnb3RvIGRvbmU7Cj4gPiAtCj4gPiAg CW1vZCA9IG1vZGlmaWVyc19wdHIoYmxvYl9kYXRhKTsKPiA+ICAJZm9yIChpID0gMDsgaSA8IHBs YW5lLT5tb2RpZmllcl9jb3VudDsgaSsrKSB7Cj4gPiAgCQlmb3IgKGogPSAwOyBqIDwgcGxhbmUt PmZvcm1hdF9jb3VudDsgaisrKSB7Cj4gPiAtCQkJaWYgKHBsYW5lLT5mdW5jcy0+Zm9ybWF0X21v ZF9zdXBwb3J0ZWQocGxhbmUsCj4gPiArCQkJaWYgKCFwbGFuZS0+ZnVuY3MtPmZvcm1hdF9tb2Rf c3VwcG9ydGVkIHx8Cj4gPiArCQkJICAgIHBsYW5lLT5mdW5jcy0+Zm9ybWF0X21vZF9zdXBwb3J0 ZWQocGxhbmUsCj4gPiAgCQkJCQkJCSAgICAgICBwbGFuZS0+Zm9ybWF0X3R5cGVzW2pdLAo+ID4g IAkJCQkJCQkgICAgICAgcGxhbmUtPm1vZGlmaWVyc1tpXSkpIHsKPgo+IFNvIGluc3RlYWQgb2Yg c2tpcHBpbmcgdGhlIHdob2xlIGxvb3AgeW91IGp1c3Qgc2tpcCBkb2luZyBhbnl0aGluZwo+IGlu c2lkZSB0aGUgbG9vcD8gQ2FuJ3Qgc2VlIGhvdyB0aGF0IGFjaGlldmVzIGFueXRoaW5nIGF0IGFs bC4KCk5vLCB0aGUgY2hlY2sgaXMgc2tpcHBlZCB3aGVuIHRoZSBmdW5jdGlvbiBpc24ndCBwb3B1 bGF0ZWQgYnkgdGhlIGRyaXZlci4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK