From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Tian Tao <tiantao6@hisilicon.com>,
Support Opensource <Support.Opensource@diasemi.com>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"amitk@kernel.org" <amitk@kernel.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: RE: [PATCH] thermal: da9062/61: fix platform_get_irq.cocci warnings
Date: Mon, 14 Dec 2020 10:03:33 +0000 [thread overview]
Message-ID: <PR3PR10MB4142BA80AE30A6FE17A3810180C70@PR3PR10MB4142.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <1607912820-48593-1-git-send-email-tiantao6@hisilicon.com>
On 14 December 2020 02:27, Tian Tao wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> Line 248 redundant because platform_get_irq() already prints
> an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
I'm not sure stating line 248 is overly helpful in a commit message, especially
if this were to be cherry-picked (not that this is likely given the kind of
change being made).
That aside, the change itself is fine so:
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
next prev parent reply other threads:[~2020-12-14 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 2:27 [PATCH] thermal: da9062/61: fix platform_get_irq.cocci warnings Tian Tao
2020-12-14 10:03 ` Adam Thomson [this message]
2020-12-23 6:57 Tian Tao
2020-12-25 8:44 Tian Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PR3PR10MB4142BA80AE30A6FE17A3810180C70@PR3PR10MB4142.EURPRD10.PROD.OUTLOOK.COM \
--to=adam.thomson.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.