All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Alexandru Ardelean <aardelean@deviqon.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
	Support Opensource <Support.Opensource@diasemi.com>
Subject: RE: [PATCH] gpio: gpio-da9055: remove platform_set_drvdata() + cleanup probe
Date: Fri, 21 May 2021 08:45:47 +0000	[thread overview]
Message-ID: <PR3PR10MB4142D5A98C0B0E4C08CBAE1C80299@PR3PR10MB4142.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210514092332.19966-1-aardelean@deviqon.com>

On 14 May 2021 10:24, Alexandru Ardelean wrote:

> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
> 
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
> 
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>

Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

> ---
>  drivers/gpio/gpio-da9055.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-da9055.c b/drivers/gpio/gpio-da9055.c
> index 6ad0c37b862e..49446a030f10 100644
> --- a/drivers/gpio/gpio-da9055.c
> +++ b/drivers/gpio/gpio-da9055.c
> @@ -133,7 +133,6 @@ static int da9055_gpio_probe(struct platform_device
> *pdev)
>  {
>  	struct da9055_gpio *gpio;
>  	struct da9055_pdata *pdata;
> -	int ret;
> 
>  	gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
>  	if (!gpio)
> @@ -146,15 +145,7 @@ static int da9055_gpio_probe(struct platform_device
> *pdev)
>  	if (pdata && pdata->gpio_base)
>  		gpio->gp.base = pdata->gpio_base;
> 
> -	ret = devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio);
> -	if (ret < 0) {
> -		dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
> -		return ret;
> -	}
> -
> -	platform_set_drvdata(pdev, gpio);
> -
> -	return 0;
> +	return devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio);
>  }
> 
>  static struct platform_driver da9055_gpio_driver = {
> --
> 2.31.1


  reply	other threads:[~2021-05-21  8:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14  9:23 [PATCH] gpio: gpio-da9055: remove platform_set_drvdata() + cleanup probe Alexandru Ardelean
2021-05-21  8:45 ` Adam Thomson [this message]
2021-05-21 12:46 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PR3PR10MB4142D5A98C0B0E4C08CBAE1C80299@PR3PR10MB4142.EURPRD10.PROD.OUTLOOK.COM \
    --to=adam.thomson.opensource@diasemi.com \
    --cc=Support.Opensource@diasemi.com \
    --cc=aardelean@deviqon.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.