All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gpio: gpio-da9055: remove platform_set_drvdata() + cleanup probe
@ 2021-05-14  9:23 Alexandru Ardelean
  2021-05-21  8:45 ` Adam Thomson
  2021-05-21 12:46 ` Bartosz Golaszewski
  0 siblings, 2 replies; 3+ messages in thread
From: Alexandru Ardelean @ 2021-05-14  9:23 UTC (permalink / raw)
  To: linux-gpio, linux-kernel
  Cc: linus.walleij, bgolaszewski, support.opensource, Alexandru Ardelean

The platform_set_drvdata() call is only useful if we need to retrieve back
the private information.
Since the driver doesn't do that, it's not useful to have it.

If this is removed, we can also just do a direct return on
devm_gpiochip_add_data(). We don't need to print that this call failed as
there are other ways to log/see this during probe.

Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
---
 drivers/gpio/gpio-da9055.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/gpio/gpio-da9055.c b/drivers/gpio/gpio-da9055.c
index 6ad0c37b862e..49446a030f10 100644
--- a/drivers/gpio/gpio-da9055.c
+++ b/drivers/gpio/gpio-da9055.c
@@ -133,7 +133,6 @@ static int da9055_gpio_probe(struct platform_device *pdev)
 {
 	struct da9055_gpio *gpio;
 	struct da9055_pdata *pdata;
-	int ret;
 
 	gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
 	if (!gpio)
@@ -146,15 +145,7 @@ static int da9055_gpio_probe(struct platform_device *pdev)
 	if (pdata && pdata->gpio_base)
 		gpio->gp.base = pdata->gpio_base;
 
-	ret = devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio);
-	if (ret < 0) {
-		dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
-		return ret;
-	}
-
-	platform_set_drvdata(pdev, gpio);
-
-	return 0;
+	return devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio);
 }
 
 static struct platform_driver da9055_gpio_driver = {
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] gpio: gpio-da9055: remove platform_set_drvdata() + cleanup probe
  2021-05-14  9:23 [PATCH] gpio: gpio-da9055: remove platform_set_drvdata() + cleanup probe Alexandru Ardelean
@ 2021-05-21  8:45 ` Adam Thomson
  2021-05-21 12:46 ` Bartosz Golaszewski
  1 sibling, 0 replies; 3+ messages in thread
From: Adam Thomson @ 2021-05-21  8:45 UTC (permalink / raw)
  To: Alexandru Ardelean, linux-gpio, linux-kernel
  Cc: linus.walleij, bgolaszewski, Support Opensource

On 14 May 2021 10:24, Alexandru Ardelean wrote:

> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
> 
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
> 
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>

Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

> ---
>  drivers/gpio/gpio-da9055.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-da9055.c b/drivers/gpio/gpio-da9055.c
> index 6ad0c37b862e..49446a030f10 100644
> --- a/drivers/gpio/gpio-da9055.c
> +++ b/drivers/gpio/gpio-da9055.c
> @@ -133,7 +133,6 @@ static int da9055_gpio_probe(struct platform_device
> *pdev)
>  {
>  	struct da9055_gpio *gpio;
>  	struct da9055_pdata *pdata;
> -	int ret;
> 
>  	gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
>  	if (!gpio)
> @@ -146,15 +145,7 @@ static int da9055_gpio_probe(struct platform_device
> *pdev)
>  	if (pdata && pdata->gpio_base)
>  		gpio->gp.base = pdata->gpio_base;
> 
> -	ret = devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio);
> -	if (ret < 0) {
> -		dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
> -		return ret;
> -	}
> -
> -	platform_set_drvdata(pdev, gpio);
> -
> -	return 0;
> +	return devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio);
>  }
> 
>  static struct platform_driver da9055_gpio_driver = {
> --
> 2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gpio: gpio-da9055: remove platform_set_drvdata() + cleanup probe
  2021-05-14  9:23 [PATCH] gpio: gpio-da9055: remove platform_set_drvdata() + cleanup probe Alexandru Ardelean
  2021-05-21  8:45 ` Adam Thomson
@ 2021-05-21 12:46 ` Bartosz Golaszewski
  1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2021-05-21 12:46 UTC (permalink / raw)
  To: Alexandru Ardelean; +Cc: linux-gpio, LKML, Linus Walleij, Support Opensource

On Fri, May 14, 2021 at 11:23 AM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
>  drivers/gpio/gpio-da9055.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-da9055.c b/drivers/gpio/gpio-da9055.c
> index 6ad0c37b862e..49446a030f10 100644
> --- a/drivers/gpio/gpio-da9055.c
> +++ b/drivers/gpio/gpio-da9055.c
> @@ -133,7 +133,6 @@ static int da9055_gpio_probe(struct platform_device *pdev)
>  {
>         struct da9055_gpio *gpio;
>         struct da9055_pdata *pdata;
> -       int ret;
>
>         gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
>         if (!gpio)
> @@ -146,15 +145,7 @@ static int da9055_gpio_probe(struct platform_device *pdev)
>         if (pdata && pdata->gpio_base)
>                 gpio->gp.base = pdata->gpio_base;
>
> -       ret = devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio);
> -       if (ret < 0) {
> -               dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
> -               return ret;
> -       }
> -
> -       platform_set_drvdata(pdev, gpio);
> -
> -       return 0;
> +       return devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio);
>  }
>
>  static struct platform_driver da9055_gpio_driver = {
> --
> 2.31.1
>

Patch applied, thanks!

Bart

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-21 12:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14  9:23 [PATCH] gpio: gpio-da9055: remove platform_set_drvdata() + cleanup probe Alexandru Ardelean
2021-05-21  8:45 ` Adam Thomson
2021-05-21 12:46 ` Bartosz Golaszewski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.