All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Carl Holtje ;021;vcsg6;" <cwh0803@cs.rit.edu>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: Breakage in -unstable for Transmeta -- Solution
Date: Fri, 24 Jun 2005 15:22:08 -0400 (EDT)	[thread overview]
Message-ID: <Pine.GSO.4.58.0506241513430.17433@queeg.cs.rit.edu> (raw)
In-Reply-To: <50b68f3ddc1ff3db9893e0d7ad10b884@cl.cam.ac.uk>

Keir-

In xen/include/asm/page.h, revision 1.53 changed a line from:
  #define PAGE_MASK           (~(PAGE_SIZE-1))
to:
  #define PAGE_MASK           (~(intpte_t)(PAGE_SIZE-1))
and caused Bad Things for Transmeta..

Which leads me to my next question...

It seems to me, and please correct me if I'm wrong, the Best Way to fix
this is with something like a #ifndef CONFIG_X86_TRANSMETA {ver 1.53 code}
#else {earlier code} #endif around this. This is what I've done for my other
changes, and seems to work pretty well. So.. where would
CONFIG_X86_TRANSMETA get defined? I've currently got it in xen/Rules.mk as
"CFLAGS += -DCONFIG_X86_TRANSMETA", and am sure it's not the Right Way to
do it..

Thanks!

(Transmeta patch coming RSN.. I'm sure everybody is salivating for it, so
I'll try to keep the wait short... :) )

Carl

- --

"There are 10 types of people in the world: Those who understand binary
and those that don't."

  reply	other threads:[~2005-06-24 19:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-22 18:50 Breakage in -unstable for Transmeta Carl Holtje ;021;vcsg6;
2005-06-23 10:22 ` Keir Fraser
2005-06-23 20:45   ` Carl Holtje ;021;vcsg6;
2005-06-23 22:18     ` Keir Fraser
2005-06-24  0:23       ` Carl Holtje ;021;vcsg6;
2005-06-24  9:33         ` Keir Fraser
2005-06-24 13:30           ` Carl Holtje ;021;vcsg6;
2005-06-24 13:55             ` Keir Fraser
2005-06-24 15:57               ` Carl Holtje ;021;vcsg6;
2005-06-24 16:15                 ` Keir Fraser
2005-06-24 19:22                   ` Carl Holtje ;021;vcsg6; [this message]
2005-06-24 20:33                     ` Breakage in -unstable for Transmeta -- Solution Keir Fraser
2005-06-25  1:57                       ` Carl Holtje ;021;vcsg6;
2005-06-25  9:21                         ` Keir Fraser
2005-06-27 15:55                           ` Carl Holtje ;021;vcsg6;

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.58.0506241513430.17433@queeg.cs.rit.edu \
    --to=cwh0803@cs.rit.edu \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.