From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilija Hadzic Subject: Re: [PATCH 04/16] drm: initial multiple nodes ioctl work. Date: Thu, 29 Mar 2012 12:22:20 -0500 (CDT) Message-ID: References: <1333039298-2520-1-git-send-email-ihadzic@research.bell-labs.com> <1333039298-2520-5-git-send-email-ihadzic@research.bell-labs.com> <20120329171542.GR4917@intel.com> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-559023410-684387517-1333041740=:10254" Return-path: Received: from ihemail2.lucent.com (ihemail2.lucent.com [135.245.0.35]) by gabe.freedesktop.org (Postfix) with ESMTP id F1B809E88F for ; Thu, 29 Mar 2012 10:22:23 -0700 (PDT) In-Reply-To: <20120329171542.GR4917@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Dave Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---559023410-684387517-1333041740=:10254 Content-Type: TEXT/PLAIN; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Thu, 29 Mar 2012, Ville [iso-8859-1] Syrj=E4l=E4 wrote: >> +/* render node create and remove functions >> + if crtc/encoders/connectors all =3D=3D 0 then gpgpu node */ >> +struct drm_render_node_create { >> +=09__u32 node_minor_id; >> +=09__u32 num_crtc; >> +=09__u32 num_encoder; >> +=09__u32 num_connector; > > num_plane is missing > Probably because at the time the original patch was created, there was no= =20 support for planes. I agree, we need to throw planes into this, but I'd=20 prefer to do this as a follow-on patch series, rather than amending old=20 patches. If for no better reason, than to keep simple relationship between= =20 the code and it's author (this particular patch is original Dave's patch=20 from the days when we had no planes, only rebased to current HEAD). -- Ilija ---559023410-684387517-1333041740=:10254 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel ---559023410-684387517-1333041740=:10254--