From: Urban Widmark <urban@teststation.com>
To: "Ivan G." <ivangurdiev@yahoo.com>
Cc: Jeff Garzik <garzik@havoc.gtf.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Via-rhine minor issues
Date: Mon, 22 Apr 2002 21:33:12 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.33.0204222056480.9063-100000@cola.teststation.com> (raw)
In-Reply-To: <02042117254803.01262@cobra.linux>
On Sun, 21 Apr 2002, Ivan G. wrote:
> As for the Interrupts:
> Actually, RxNoBuf is handled by calling via_rhine_rx
> but not enabled when setting interrupt mask. My patch will fix that.
>
> However, RxOverflow is never handled at all and neither is RxEarly.
> Nor are they enabled when setting interrupt mask (patch enables).
>
> How should RxOverflow be handled?
The public docs don't say.
You should probably add them to the list of reasons to call
via_rhine_error, and let them be caught by the "wicked" error rule. A
reason to use a term that doesn't try to be specific is that we don't
really know what is causing the event.
Before your patch IntrTxUnderrun would raise the tx threshold AND issue a
CmdTxDemand. After it will only do the first. Do you know that this is an
improvement?
Does merging this error handling change into the main kernel really help
you test other things for your timeout problem? Can't you just include
this bit in your other work?
/Urban
next prev parent reply other threads:[~2002-04-22 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-21 21:16 Ivan G.
2002-04-21 23:02 ` your mail Jeff Garzik
2002-04-21 23:25 ` [PATCH] Via-rhine minor issues Ivan G.
2002-04-22 19:33 ` Urban Widmark [this message]
2002-04-23 4:07 ` Ivan G.
2002-04-23 13:44 ` Urban Widmark
-- strict thread matches above, loose matches on Subject: below --
2002-04-21 7:02 Ivan G.
2002-04-21 10:00 ` Martin Eriksson
2002-04-21 10:19 ` Urban Widmark
2002-04-21 16:07 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33.0204222056480.9063-100000@cola.teststation.com \
--to=urban@teststation.com \
--cc=garzik@havoc.gtf.org \
--cc=ivangurdiev@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.