From: Hugh Dickins <hugh@veritas.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-mm@kvack.org, ak@suse.de
Subject: Re: [patch] kill off ARCH_HAS_ATOMIC_UNSIGNED (take 2)
Date: Fri, 17 Dec 2004 18:17:55 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.44.0412171814050.10470-100000@localhost.localdomain> (raw)
In-Reply-To: <E1CfLrg-0007VC-00@kernel.beaverton.ibm.com>
On Fri, 17 Dec 2004, Dave Hansen wrote:
> --- apw2/mm/page_alloc.c~000-CONFIG_ARCH_HAS_ATOMIC_UNSIGNED 2004-12-17 09:19:30.000000000 -0800
> +++ apw2-dave/mm/page_alloc.c 2004-12-17 09:19:48.000000000 -0800
> @@ -85,7 +85,7 @@ static void bad_page(const char *functio
> printk(KERN_EMERG "Bad page state at %s (in process '%s', page %p)\n",
> function, current->comm, page);
> printk(KERN_EMERG "flags:0x%0*lx mapping:%p mapcount:%d count:%d\n",
> - (int)(2*sizeof(page_flags_t)), (unsigned long)page->flags,
> + (int)(2*sizeof(unsigned long)), (unsigned long)page->flags,
^^^^^^^^^^^^^^^
> page->mapping, page_mapcount(page), page_count(page));
> printk(KERN_EMERG "Backtrace:\n");
> dump_stack();
Teensy nit: better not to cast to unsigned long when it's unsigned long.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-12-17 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-17 17:26 [patch] kill off ARCH_HAS_ATOMIC_UNSIGNED (take 2) Dave Hansen
2004-12-17 18:17 ` Hugh Dickins [this message]
2004-12-17 18:27 ` Dave Hansen
2004-12-17 18:38 ` Hugh Dickins
2004-12-17 23:54 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0412171814050.10470-100000@localhost.localdomain \
--to=hugh@veritas.com \
--cc=ak@suse.de \
--cc=haveblue@us.ibm.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.