All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH (resend)]: SCSI: fix /proc memory leak in the SCSI core
Date: Sun, 22 Feb 2009 14:34:09 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.0902221431170.30449-100000@netrider.rowland.org> (raw)
In-Reply-To: <1235324436.4531.54.camel@localhost.localdomain>

On Sun, 22 Feb 2009, James Bottomley wrote:

> OK, but resending a patch you expressed reservations about putting in
> without testing doesn't really help me.  I need a way to get comfortable
> with its safety.
> 
> So, what about this alternative fix instead: if the removal were moved
> to scsi_host_put(), that would address all the problems and have the
> advantage that everyone will test it ...

I thought of doing it that way too.  It has the disadvantage of
exposing part of the proc interface to userspace before the host is
registered.  Now, since all we're adding is the host's directory, maybe 
this doesn't matter.  But it didn't seem like a good idea.

Alan Stern


  reply	other threads:[~2009-02-22 19:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18 15:52 [PATCH (resend)]: SCSI: fix /proc memory leak in the SCSI core Alan Stern
2009-02-22 17:40 ` James Bottomley
2009-02-22 19:34   ` Alan Stern [this message]
2009-02-22 19:46     ` James Bottomley
2009-02-23  0:56       ` Alan Stern
2009-02-27 15:09 Tony Battersby
2009-02-27 21:50 ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44L0.0902221431170.30449-100000@netrider.rowland.org \
    --to=stern@rowland.harvard.edu \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.