All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: pm list <linux-pm@lists.linux-foundation.org>,
	Greg KH <gregkh@suse.de>, LKML <linux-kernel@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Dave Young <hidave.darkstar@gmail.com>
Subject: Re: [PATCH, fix] Re: [Regression] 2.6.31-git: tty change broke resume from hibernation on MSI Wind U100
Date: Sun, 27 Sep 2009 13:32:31 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.0909271329400.5871-100000__31457.003291189$1254072817$gmane$org@netrider.rowland.org> (raw)
In-Reply-To: <200909271800.43066.rjw@sisk.pl>

On Sun, 27 Sep 2009, Rafael J. Wysocki wrote:

> Tested, works.
> 
> Greg, could you please consider taking the patch below?  It fixes a recent
> hibernation regression for me, so if not this one, another fix is necessary.

This patch has a mistake.

> Index: linux-2.6/drivers/usb/serial/usb-serial.c
> ===================================================================
> --- linux-2.6.orig/drivers/usb/serial/usb-serial.c
> +++ linux-2.6/drivers/usb/serial/usb-serial.c
> @@ -1210,7 +1210,7 @@ static const struct tty_operations seria
>  	.chars_in_buffer =	serial_chars_in_buffer,
>  	.tiocmget =		serial_tiocmget,
>  	.tiocmset =		serial_tiocmset,
> -	.shutdown = 		serial_release,
> +	.cleanup = 		serial_release,
>  	.install = 		serial_install,
>  	.proc_fops =		&serial_proc_fops,
>  };

It isn't enough to change the method pointer.  The code in 
serial_release() has to be changed too; it must not call tty_shutdown() 
any more.

Alan Stern

  reply	other threads:[~2009-09-27 17:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-25 22:38 [Regression] 2.6.31-git: tty change broke resume from hibernation on MSI Wind U100 Rafael J. Wysocki
2009-09-27 11:47 ` Alan Cox
2009-09-27 11:47 ` Alan Cox
2009-09-27 15:00   ` Rafael J. Wysocki
2009-09-27 15:00     ` Rafael J. Wysocki
2009-09-27 16:00     ` [PATCH, fix] " Rafael J. Wysocki
2009-09-27 16:00     ` Rafael J. Wysocki
2009-09-27 17:32       ` Alan Stern [this message]
2009-09-27 17:32       ` [linux-pm] " Alan Stern
2009-09-27 18:16         ` Rafael J. Wysocki
2009-09-27 18:16         ` [linux-pm] " Rafael J. Wysocki
2009-09-28  5:03           ` Dave Young
2009-09-28  5:03           ` [linux-pm] " Dave Young
2009-09-28  6:07             ` Alan Stern
2009-09-28 20:20               ` Rafael J. Wysocki
2009-09-29  0:39                 ` Dave Young
2009-09-29  0:39                 ` [linux-pm] " Dave Young
2009-09-28 20:20               ` Rafael J. Wysocki
2009-09-28  6:07             ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='Pine.LNX.4.44L0.0909271329400.5871-100000__31457.003291189$1254072817$gmane$org@netrider.rowland.org' \
    --to=stern@rowland.harvard.edu \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=hidave.darkstar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.