From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Stern Subject: Re: [PATCH] PM: Prevent waiting forever on asynchronous resume after abort Date: Thu, 2 Sep 2010 16:45:25 -0400 (EDT) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Colin Cross Cc: Randy Dunlap , Len Brown , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org, Andrew Morton List-Id: linux-pm@vger.kernel.org On Thu, 2 Sep 2010, Colin Cross wrote: > >> I think it would be better to change device_pm_init() and add a > >> complete_all(). > > > > I agree. > That would work, and was my first solution, but it increases the > reliance on the completion variable being left completed between state > transitions, which is undocumented and unnecessary. It seems more > straightforward to me to only wait on the parent if the parent is > suspended. How about calling complete_all() from within dpm_prepare() as well? Then it will get initialized properly at the beginning of every sleep transition. Alan Stern