From: Alan Stern <stern@rowland.harvard.edu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Linux-pm mailing list <linux-pm@lists.linux-foundation.org>
Subject: [PATCH] PM: prevent runtime_resume from racing with probe
Date: Fri, 1 Jul 2011 17:13:51 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1107011132070.1988-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1107011045160.1988-100000@iolanthe.rowland.org>
This patch (as1475) adds device_lock() and device_unlock() calls to
the store methods for the power/control and power/autosuspend_delay_ms
sysfs attribute files. We don't want badly timed writes to these
files to cause runtime_resume callbacks to occur while a driver is
being probed for a device.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
---
drivers/base/power/sysfs.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Index: usb-3.0/drivers/base/power/sysfs.c
===================================================================
--- usb-3.0.orig/drivers/base/power/sysfs.c
+++ usb-3.0/drivers/base/power/sysfs.c
@@ -116,12 +116,14 @@ static ssize_t control_store(struct devi
cp = memchr(buf, '\n', n);
if (cp)
len = cp - buf;
+ device_lock(dev);
if (len == sizeof ctrl_auto - 1 && strncmp(buf, ctrl_auto, len) == 0)
pm_runtime_allow(dev);
else if (len == sizeof ctrl_on - 1 && strncmp(buf, ctrl_on, len) == 0)
pm_runtime_forbid(dev);
else
- return -EINVAL;
+ n = -EINVAL;
+ device_unlock(dev);
return n;
}
@@ -205,7 +207,9 @@ static ssize_t autosuspend_delay_ms_stor
if (strict_strtol(buf, 10, &delay) != 0 || delay != (int) delay)
return -EINVAL;
+ device_lock(dev);
pm_runtime_set_autosuspend_delay(dev, delay);
+ device_unlock(dev);
return n;
}
next prev parent reply other threads:[~2011-07-01 21:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 22:19 runtime PM usage_count during driver_probe_device()? Kevin Hilman
2011-07-01 0:09 ` Kevin Hilman
2011-07-01 0:09 ` Kevin Hilman
2011-07-01 0:33 ` Rafael J. Wysocki
2011-07-01 0:33 ` [linux-pm] " Rafael J. Wysocki
2011-07-01 5:57 ` Ohad Ben-Cohen
2011-07-01 14:46 ` Kevin Hilman
2011-07-01 14:46 ` Kevin Hilman
2011-07-01 5:57 ` Ohad Ben-Cohen
2011-07-01 11:32 ` Ming Lei
2011-07-01 11:32 ` [linux-pm] " Ming Lei
2011-07-01 14:54 ` Alan Stern
2011-07-01 21:13 ` Alan Stern [this message]
2011-07-01 21:42 ` [PATCH] PM: prevent runtime_resume from racing with probe Rafael J. Wysocki
2011-07-01 14:54 ` runtime PM usage_count during driver_probe_device()? Alan Stern
2011-07-01 14:43 ` [linux-pm] " Alan Stern
2011-07-01 14:43 ` Alan Stern
2011-07-01 14:44 ` Kevin Hilman
2011-07-01 15:25 ` Alan Stern
2011-07-01 15:25 ` [linux-pm] " Alan Stern
2011-07-01 15:45 ` Kevin Hilman
2011-07-01 15:59 ` Alan Stern
2011-07-01 16:54 ` Kevin Hilman
2011-07-01 16:54 ` Kevin Hilman
2011-07-01 15:59 ` Alan Stern
2011-07-01 20:53 ` Rafael J. Wysocki
2011-07-01 20:53 ` [linux-pm] " Rafael J. Wysocki
2011-07-01 21:12 ` Alan Stern
2011-07-01 21:44 ` Rafael J. Wysocki
2011-07-01 21:44 ` [linux-pm] " Rafael J. Wysocki
2011-07-01 22:12 ` [PATCH] PM / Runtime: Update documentation regarding driver removal Rafael J. Wysocki
2011-07-01 22:49 ` Kevin Hilman
2011-07-01 22:49 ` Kevin Hilman
2011-07-01 22:12 ` Rafael J. Wysocki
2011-07-01 21:12 ` runtime PM usage_count during driver_probe_device()? Alan Stern
2011-07-01 15:45 ` Kevin Hilman
2011-07-01 14:44 ` Kevin Hilman
2011-07-01 21:42 ` Rafael J. Wysocki
2011-07-01 21:42 ` [linux-pm] " Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1107011132070.1988-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.