From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755406Ab1HSO5f (ORCPT ); Fri, 19 Aug 2011 10:57:35 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:35909 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751832Ab1HSO5d (ORCPT ); Fri, 19 Aug 2011 10:57:33 -0400 Date: Fri, 19 Aug 2011 10:57:32 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Michal Nazarewicz cc: Sebastian Andrzej Siewior , Sergei Shtylyov , Felipe Balbi , Yang Rui Rui , Greg Kroah-Hartman , USB list , Kernel development list Subject: Re: [PATCHv2] usb: gadget: get rid of USB_GADGET_DUALSPEED and USB_GADGET_SUPERSPEED In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Aug 2011, Michal Nazarewicz wrote: > > I don't quite understand that sentence. However, it is definitely true > > that all UDC drivers _must_ avoid connecting at speeds that are faster > > than the usb_gadget_driver's .speed field. > > Yang has brought up an issue that musb_gadget_start() checks if > driver->speed > equals USB_SPEED_HIGH. This means that if a gadget driver supports super > speed > it'll set driver->speed to USB_SPEED_SUPER and musb_gadget_start() will > complain. > > My understanding is that this is a bug in musb driver as it should allow > the > gadget driver to start but never set super speed. That's right. It should also allow driver->speed to be USB_SPEED_FULL, in which case it should never connect at high speed (see gmidi.c). Alan Stern