From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Stern Subject: Re: ehci_hcd related S3 lockup on ASUS laptops, again Date: Thu, 12 Apr 2012 21:03:02 -0400 (EDT) Message-ID: References: <20120412202132.GH12852@belkar.wrar.name> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120412202132.GH12852@belkar.wrar.name> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Andrey Rahmatullin Cc: jrnieder@gmail.com, Greg KH , USB list , Steven Rostedt , linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org On Fri, 13 Apr 2012, Andrey Rahmatullin wrote: > On Thu, Apr 12, 2012 at 04:09:43PM -0400, Alan Stern wrote: > > > Do this with the ehci_reset added and all the other changes present as > > > well. > > > > More precisely, keep the ehci_reset call (in both places), > Which both places? > > > the dev_info call, and the pci_prepare_to_sleep call. You don't need to > > set the configflag register to 0; the reset will do that anyway. Sorry, that was an editing error. I meant to say the pci_prepare_to_sleep calls should be kept in both places: the existing on in hcd-pci.c and the one added to pci-driver.c. You got the right idea, though. Alan Stern