From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Stern Subject: Re: [PATCH] hid: usbhid: fix possible deadlock in __usbhid_submit_report Date: Fri, 20 Apr 2012 20:37:35 -0400 (EDT) Message-ID: References: <201204201245.44981.oneukum@suse.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <201204201245.44981.oneukum-l3A5Bk7waGM@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Oliver Neukum Cc: Ming Lei , Greg Kroah-Hartman , Jiri Kosina , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-input@vger.kernel.org On Fri, 20 Apr 2012, Oliver Neukum wrote: > As I said, I'd very much appreciate sane semantics for usb_unlink_urb(). Aside from the practicality issue of altering a large number of existing drivers, changing the semantics the way you want would be difficult because it would force the HCDs to defer some giveback operations to a bottom half or timer routine. Think about what happens if the URB being unlinked hasn't been presented to the hardware yet. Once it has been removed from the HCD's internal lists, there's no reason not to give it back right away. And there's no natural time to give it back later. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html