From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934101Ab3BTQhd (ORCPT ); Wed, 20 Feb 2013 11:37:33 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:34793 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S933743Ab3BTQhc (ORCPT ); Wed, 20 Feb 2013 11:37:32 -0500 Date: Wed, 20 Feb 2013 11:37:31 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Manjunath Goudar cc: linux-usb@vger.kernel.org, , , , , Greg KH , Tony Prisk , Alexey Charkov , Subject: Re: [V2 5/8] USB: EHCI: make ehci-vt8500 a separate driver In-Reply-To: <1360923853-7875-6-git-send-email-manjunath.goudar@linaro.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Feb 2013, Manjunath Goudar wrote: > Separate the vt8500 host controller driver from ehci-hcd host code > into its own driver module. > > In V2: > Change the GPL to GPL v2 MODULE_LICENSE Same comments as for the other patches. You know, when you submit a series of patches all doing basically the same sort of thing, and somebody makes a suggestion to improve one of them, you should always consider whether that suggestion could also apply to the other patches in the series. It's silly for us to send you 8 separate emails, each telling you to make the same change to one particular patch in the series. Therefore you should consider each of the problems I have described in the last several emails, and think about which of your patches they apply to. Some of them do apply to more than one patch, even though I didn't say so explicitly at the time. Alan Stern From mboxrd@z Thu Jan 1 00:00:00 1970 From: stern@rowland.harvard.edu (Alan Stern) Date: Wed, 20 Feb 2013 11:37:31 -0500 (EST) Subject: [V2 5/8] USB: EHCI: make ehci-vt8500 a separate driver In-Reply-To: <1360923853-7875-6-git-send-email-manjunath.goudar@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 15 Feb 2013, Manjunath Goudar wrote: > Separate the vt8500 host controller driver from ehci-hcd host code > into its own driver module. > > In V2: > Change the GPL to GPL v2 MODULE_LICENSE Same comments as for the other patches. You know, when you submit a series of patches all doing basically the same sort of thing, and somebody makes a suggestion to improve one of them, you should always consider whether that suggestion could also apply to the other patches in the series. It's silly for us to send you 8 separate emails, each telling you to make the same change to one particular patch in the series. Therefore you should consider each of the problems I have described in the last several emails, and think about which of your patches they apply to. Some of them do apply to more than one patch, even though I didn't say so explicitly at the time. Alan Stern