From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755262AbaHAOlK (ORCPT ); Fri, 1 Aug 2014 10:41:10 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:57844 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755200AbaHAOlH (ORCPT ); Fri, 1 Aug 2014 10:41:07 -0400 Date: Fri, 1 Aug 2014 10:41:06 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Thomas Gleixner cc: "Rafael J. Wysocki" , Peter Zijlstra , , Linux PM list , Dmitry Torokhov Subject: Re: [PATCH 1/3] irq / PM: New driver interface for wakeup interrupts In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Aug 2014, Thomas Gleixner wrote: > Anyone who thinks that this can and should be solved at the driver > level is simply taking the wrong drugs or ran out of supply of the > proper ones. Either call your shrink or your drug dealer to get out of > that. That's absolutely true, but there is a counterpoint: Some of the problems in this area _must_ be fixed at the driver level. In particular, any driver that: doesn't prevent its device from generating interrupt requests while the system is suspended and allows its device to share an IRQ line with a wakeup source has to be fixed. The situation is even worse if the driver's interrupt handler blows up when called at an inopportune time (such as when clocks or power supplies are off). Unfortunately, the only reasonable way to find such drivers is to wait and see when the bad combination of events happens. Alan Stern From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Stern Subject: Re: [PATCH 1/3] irq / PM: New driver interface for wakeup interrupts Date: Fri, 1 Aug 2014 10:41:06 -0400 (EDT) Message-ID: References: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: "Rafael J. Wysocki" , Peter Zijlstra , linux-kernel@vger.kernel.org, Linux PM list , Dmitry Torokhov List-Id: linux-pm@vger.kernel.org On Fri, 1 Aug 2014, Thomas Gleixner wrote: > Anyone who thinks that this can and should be solved at the driver > level is simply taking the wrong drugs or ran out of supply of the > proper ones. Either call your shrink or your drug dealer to get out of > that. That's absolutely true, but there is a counterpoint: Some of the problems in this area _must_ be fixed at the driver level. In particular, any driver that: doesn't prevent its device from generating interrupt requests while the system is suspended and allows its device to share an IRQ line with a wakeup source has to be fixed. The situation is even worse if the driver's interrupt handler blows up when called at an inopportune time (such as when clocks or power supplies are off). Unfortunately, the only reasonable way to find such drivers is to wait and see when the bad combination of events happens. Alan Stern