From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from iolanthe.rowland.org ([192.131.102.54]:33991 "HELO
	iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with SMTP id S1751370AbbFVOpr (ORCPT
	<rfc822;stable@vger.kernel.org>); Mon, 22 Jun 2015 10:45:47 -0400
Date: Mon, 22 Jun 2015 10:45:46 -0400 (EDT)
From: Alan Stern <stern@rowland.harvard.edu>
To: Michal Nazarewicz <mina86@mina86.com>
cc: Krzysztof Opasiak <k.opasiak@samsung.com>, <balbi@ti.com>,
	<stable@vger.kernel.org>, <david.fisher1@synopsys.com>,
	<gregkh@linuxfoundation.org>, <andrzej.p@samsung.com>,
	<m.szyprowski@samsung.com>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 2/5] usb: gadget: mass_storage: Enforce contiguous LUN
 ids
In-Reply-To: <xa1tfv5jizm2.fsf@mina86.com>
Message-ID: <Pine.LNX.4.44L0.1506221044500.1799-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Mon, 22 Jun 2015, Michal Nazarewicz wrote:

> On Mon, Jun 22 2015, Krzysztof Opasiak wrote:
> > According to mass storage specification:
> >
> > "Logical Unit Numbers on the device shall be numbered contiguously
> >  starting from LUN 0 to a maximum LUN of 15 (Fh)"
> >
> > So don't allow to bind ms function unless we have at least LUN0
> > and LUNs ids are contiguous.
> >
> > Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
> 
> Acked-by: Michal Nazarewicz <mina86@mina86.com>
> 
> but then again I think that we should let user space shoot themselves in
> the foot if they want to, especially as letting them to that is less
> code. ;)

How about logging a warning message if the LUNs aren't contiguous but 
then continuing on?  Like we do if the serial number string isn't 
provided.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe stable" in