From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752180AbcAEQGm (ORCPT ); Tue, 5 Jan 2016 11:06:42 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:60520 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751798AbcAEQG1 (ORCPT ); Tue, 5 Jan 2016 11:06:27 -0500 Date: Tue, 5 Jan 2016 11:06:26 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Joe Perches cc: "Geyslan G. Bem" , LKML , Greg Kroah-Hartman , Subject: Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions In-Reply-To: <1452007408.4334.136.camel@perches.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Jan 2016, Joe Perches wrote: > On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote: > > On Mon, 4 Jan 2016, Geyslan G. Bem wrote: > > > > > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd *ehci, __hc32 token) > > > >>       return '/'; > > > >>  } > > > >> > > > >> -static void qh_lines( > > > >> -     struct ehci_hcd *ehci, > > > >> -     struct ehci_qh *qh, > > > >> -     char **nextp, > > > >> -     unsigned *sizep > > > >> -) > > > >> +static void qh_lines(struct ehci_hcd *ehci, struct ehci_qh *qh, > > > >> +                     char **nextp, unsigned *sizep) > > > >>  { > > > >>       u32                     scratch; > > > >>       u32                     hw_curr; > > > >> > > > > > > > And about that style? Should be done? > > > > You mean squeezing the function parameters into two lines?  That's  > > okay. > > > > However, the style in this file is to indent continuation lines by two > > extra tab stops, not to line things up with an open paren on the first > > line. > > It's not consistent. > It's a bit of a mix of 1 and 2 tabs, and some others. I know. That's because the files were written by various people at various times and nobody tried to enforce a rigid consistent style. I'm not even consistent all the time in the things that I write. There are places (see drivers/usb/core/config.c) where I indented continuation lines by 4 spaces instead of 2 tab stops. And there are places where a continuation of a continuation gets indented even farther. Trying to come up with hard-and-fast rules for this sort of thing is pretty hopeless. Even "Maximize readability" doesn't work too well, because different people find different things most readable. Alan Stern