From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759928AbcCDQEc (ORCPT ); Fri, 4 Mar 2016 11:04:32 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:35276 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1759455AbcCDQE2 (ORCPT ); Fri, 4 Mar 2016 11:04:28 -0500 Date: Fri, 4 Mar 2016 11:04:26 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Sedat Dilek cc: Steven Rostedt , Jiri Kosina , Tejun Heo , Lai Jiangshan , Benjamin Tissoires , Paul McKenney , Andy Lutomirski , LKML , USB list , Greg Kroah-Hartman , Peter Zijlstra , Ingo Molnar Subject: Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Mar 2016, Sedat Dilek wrote: > On 3/1/16, Alan Stern wrote: > > On Tue, 1 Mar 2016, Sedat Dilek wrote: > > > >> On Tue, Oct 13, 2015 at 2:57 AM, Steven Rostedt > >> wrote: > >> > On Sat, 3 Oct 2015 12:05:42 +0200 > >> > Sedat Dilek wrote: > >> > > >> >> So, at the beginning... dunno WTF is causing the problems - no > >> >> workaround for CLANG. > >> > > >> > Probably need to compile with gcc and with clang and look at the binary > >> > differences. Or at least what objdump shows. > >> > > >> > >> [ Hope to address this issue to the correct people - CCed some people > >> I taped on their nerves ] > >> > >> Not sure if I should open a new thread? > >> Please, some clear statements on this. > >> Thanks. > >> > >> The issue is still visible and alive. I think it would be worthwhile to doublecheck the time at which interrupts get disabled. Sedat, please try your plug/unplug the USB mouse test with the patch below. Alan Stern Index: usb-4.4/drivers/hid/usbhid/hid-core.c =================================================================== --- usb-4.4.orig/drivers/hid/usbhid/hid-core.c +++ usb-4.4/drivers/hid/usbhid/hid-core.c @@ -1393,8 +1393,11 @@ static void usbhid_disconnect(struct usb static void hid_cancel_delayed_stuff(struct usbhid_device *usbhid) { + if (raw_irqs_disabled()) pr_info("usbhid irqs disabled A\n"); del_timer_sync(&usbhid->io_retry); + if (raw_irqs_disabled()) pr_info("usbhid irqs disabled B\n"); cancel_work_sync(&usbhid->reset_work); + if (raw_irqs_disabled()) pr_info("usbhid irqs disabled C\n"); } static void hid_cease_io(struct usbhid_device *usbhid)