From: Alan Stern <stern@rowland.harvard.edu>
To: Felipe Balbi <balbi@kernel.org>
Cc: Baolin Wang <baolin.wang@linaro.org>,
Greg KH <gregkh@linuxfoundation.org>,
USB <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase
Date: Tue, 28 Feb 2017 13:34:05 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1702281327230.2075-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <87tw7ettoo.fsf@linux.intel.com>
On Tue, 28 Feb 2017, Felipe Balbi wrote:
>
> Hi,
>
> Alan Stern <stern@rowland.harvard.edu> writes:
> >> So I am not sure how the Gadget driver can figure out that it needs to
> >> usb_ep_queue() another request for status stage when handling the
> >> no-data control?
> >
> > Gadget drivers already queue status-stage requests for no-data
> > control-OUT requests. The difficulty comes when you want to handle an
> > IN request or an OUT request with a data stage.
>
> I don't see a difficulty there. Gadget driver will see wLength and
> notice it needs both data and status stages, then it does:
>
> usb_ep_queue(ep0, data_req, GFP_KERNEL);
> usb_ep_queue(ep0, status_req, GFP_KERNEL);
The main difficulty is that all the gadget/function drivers will have
to be audited to add the status requests.
> Just needs to prepare both requests and queue them both ahead of
> time. UDC drivers should hold both requests in their own private list
> and process one at a time.
Or the gadget driver should queue the status request after the
data stage has been fully processed, in the case of an OUT transfer.
There is still a possible race. The host might send another SETUP
packet before the status request has been queued, or after it has been
queued but before the UDC driver has completed it. (Of course, that's
already true now for the data request...)
Alan Stern
next prev parent reply other threads:[~2017-02-28 18:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 8:40 [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase Baolin Wang
2017-01-16 10:56 ` Felipe Balbi
2017-01-16 11:29 ` Baolin Wang
2017-01-16 11:29 ` Felipe Balbi
2017-01-16 12:00 ` Baolin Wang
2017-01-16 12:06 ` Felipe Balbi
2017-01-16 17:53 ` Alan Stern
2017-01-16 19:18 ` Felipe Balbi
2017-01-17 15:54 ` Alan Stern
2017-01-23 11:57 ` Felipe Balbi
2017-02-17 5:41 ` Baolin Wang
2017-02-17 8:04 ` Felipe Balbi
2017-02-20 2:27 ` Baolin Wang
2017-02-21 9:18 ` Baolin Wang
2017-02-27 22:11 ` Alan Stern
2017-02-28 11:56 ` Felipe Balbi
2017-02-28 18:34 ` Alan Stern [this message]
2017-03-02 10:43 ` Felipe Balbi
2017-03-02 10:15 ` Baolin Wang
2017-03-02 10:48 ` Felipe Balbi
2017-01-17 7:02 ` Baolin Wang
2017-01-17 10:39 ` Felipe Balbi
2017-01-17 11:40 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1702281327230.2075-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=balbi@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.