All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: gregkh@linuxfoundation.org, <linux-usb@vger.kernel.org>,
	<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] usb: host: [eo]hci-plat: set hcd->phy to avoid phy_get_() in usb_add_hcd()
Date: Mon, 13 Mar 2017 21:59:15 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.1703132158350.17987-100000@netrider.rowland.org> (raw)
In-Reply-To: <1489386324-31353-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>

On Mon, 13 Mar 2017, Yoshihiro Shimoda wrote:

> The usb_add_hcd() will call phy_{get,init,power_on}() if hcd->phy is not set.
> After the usb_add_hcd() call phy_power_on(), it keeps until usb_remove_hcd().
> And then, even if the system turns suspend, the usb core keeps the phy power.
> I think that each host driver should handle the phy power. So, this patch
> sets hcd->phy before usb_add_hcd() to avoid phy_get() in usb_add_hcd().
> 
> Changes from v1 (as RFC):
>  - Fix the usage condition about priv->phys[].
>  - Remove RFC.
> 
> Yoshihiro Shimoda (2):
>   usb: host: ehci-platform: set hcd->phy to avoid phy_get() in
>     usb_add_hcd()
>   usb: host: ohci-platform: set hcd->phy to avoid phy_get() in
>     usb_add_hcd()
> 
>  drivers/usb/host/ehci-platform.c | 3 +++
>  drivers/usb/host/ohci-platform.c | 3 +++
>  2 files changed, 6 insertions(+)

For both patches:

Acked-by: Alan Stern <stern@rowland.harvard.edu>

      parent reply	other threads:[~2017-03-14  1:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13  6:25 [PATCH v2 0/2] usb: host: [eo]hci-plat: set hcd->phy to avoid phy_get_() in usb_add_hcd() Yoshihiro Shimoda
2017-03-13  6:25 ` [PATCH v2 1/2] usb: host: ehci-platform: set hcd->phy to avoid phy_get() " Yoshihiro Shimoda
2017-03-13  6:25 ` [PATCH v2 2/2] usb: host: ohci-platform: " Yoshihiro Shimoda
2017-03-14  1:59 ` Alan Stern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44L0.1703132158350.17987-100000@netrider.rowland.org \
    --to=stern@rowland.harvard.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.