From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751383AbdEBSZc (ORCPT ); Tue, 2 May 2017 14:25:32 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:48154 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750850AbdEBSZa (ORCPT ); Tue, 2 May 2017 14:25:30 -0400 Date: Tue, 2 May 2017 14:25:28 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: "Gustavo A. R. Silva" cc: Greg Kroah-Hartman , , Subject: Re: [PATCH] usb: host: remove unnecessary null check In-Reply-To: <20170502160910.GA25433@embeddedgus> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 May 2017, Gustavo A. R. Silva wrote: > Remove unnecessary null check. udev->tt cannot ever be NULL when this > section of code runs. > > Addresses-Coverity-ID: 100828 > Cc: Alan Stern > Signed-off-by: Gustavo A. R. Silva > --- > drivers/usb/host/ehci-sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c > index 980a6b3..6bc6304 100644 > --- a/drivers/usb/host/ehci-sched.c > +++ b/drivers/usb/host/ehci-sched.c > @@ -1105,7 +1105,7 @@ iso_stream_init( > addr |= epnum << 8; > addr |= dev->devnum; > stream->ps.usecs = HS_USECS_ISO(maxp); > - think_time = dev->tt ? dev->tt->think_time : 0; > + think_time = dev->tt->think_time; > stream->ps.tt_usecs = NS_TO_US(think_time + usb_calc_bus_time( > dev->speed, is_input, 1, maxp)); > hs_transfers = max(1u, (maxp + 187) / 188); Acked-by: Alan Stern