From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752785AbdLFQpi (ORCPT ); Wed, 6 Dec 2017 11:45:38 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:57620 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752705AbdLFQpd (ORCPT ); Wed, 6 Dec 2017 11:45:33 -0500 Date: Wed, 6 Dec 2017 11:45:31 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: SF Markus Elfring cc: linux-usb@vger.kernel.org, Daniel Drake , Dmitry Fleytman , Eugene Korenevsky , Geert Uytterhoeven , Greg Kroah-Hartman , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , Johan Hovold , Mathias Nyman , Peter Chen , LKML , Subject: Re: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() In-Reply-To: <659939f3-da51-0cfd-2eb2-8a726cb1a42f@users.sourceforge.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Dec 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 6 Dec 2017 17:00:18 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/usb/core/hub.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index 7ccdd3d4db84..9fbb908e9552 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -829,7 +829,6 @@ int usb_hub_clear_tt_buffer(struct urb *urb) > */ > clear = kmalloc(sizeof *clear, GFP_ATOMIC); > if (clear == NULL) { > - dev_err(&udev->dev, "can't save CLEAR_TT_BUFFER state\n"); > /* FIXME recover somehow ... RESET_TT? */ > return -ENOMEM; > } Does the existing memory allocation error message include the &udev->dev device name and driver name? If it doesn't, there will be no way for the user to tell that the error message is related to the device failure. Alan Stern From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Stern Date: Wed, 06 Dec 2017 16:45:31 +0000 Subject: Re: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buf Message-Id: List-Id: References: <659939f3-da51-0cfd-2eb2-8a726cb1a42f@users.sourceforge.net> In-Reply-To: <659939f3-da51-0cfd-2eb2-8a726cb1a42f@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-usb@vger.kernel.org, Daniel Drake , Dmitry Fleytman , Eugene Korenevsky , Geert Uytterhoeven , Greg Kroah-Hartman , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , Johan Hovold , Mathias Nyman , Peter Chen , LKML , kernel-janitors@vger.kernel.org On Wed, 6 Dec 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 6 Dec 2017 17:00:18 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/usb/core/hub.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index 7ccdd3d4db84..9fbb908e9552 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -829,7 +829,6 @@ int usb_hub_clear_tt_buffer(struct urb *urb) > */ > clear = kmalloc(sizeof *clear, GFP_ATOMIC); > if (clear = NULL) { > - dev_err(&udev->dev, "can't save CLEAR_TT_BUFFER state\n"); > /* FIXME recover somehow ... RESET_TT? */ > return -ENOMEM; > } Does the existing memory allocation error message include the &udev->dev device name and driver name? If it doesn't, there will be no way for the user to tell that the error message is related to the device failure. Alan Stern From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() From: Alan Stern Message-Id: Date: Wed, 6 Dec 2017 11:45:31 -0500 (EST) To: SF Markus Elfring Cc: linux-usb@vger.kernel.org, Daniel Drake , Dmitry Fleytman , Eugene Korenevsky , Geert Uytterhoeven , Greg Kroah-Hartman , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , Johan Hovold , Mathias Nyman , Peter Chen , LKML , kernel-janitors@vger.kernel.org List-ID: T24gV2VkLCA2IERlYyAyMDE3LCBTRiBNYXJrdXMgRWxmcmluZyB3cm90ZToKCj4gRnJvbTogTWFy a3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0Pgo+IERhdGU6IFdlZCwg NiBEZWMgMjAxNyAxNzowMDoxOCArMDEwMAo+IAo+IE9taXQgYW4gZXh0cmEgbWVzc2FnZSBmb3Ig YSBtZW1vcnkgYWxsb2NhdGlvbiBmYWlsdXJlIGluIHRoaXMgZnVuY3Rpb24uCj4gCj4gVGhpcyBp c3N1ZSB3YXMgZGV0ZWN0ZWQgYnkgdXNpbmcgdGhlIENvY2NpbmVsbGUgc29mdHdhcmUuCj4gCj4g U2lnbmVkLW9mZi1ieTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2Uu bmV0Pgo+IC0tLQo+ICBkcml2ZXJzL3VzYi9jb3JlL2h1Yi5jIHwgMSAtCj4gIDEgZmlsZSBjaGFu Z2VkLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2NvcmUvaHVi LmMgYi9kcml2ZXJzL3VzYi9jb3JlL2h1Yi5jCj4gaW5kZXggN2NjZGQzZDRkYjg0Li45ZmJiOTA4 ZTk1NTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvY29yZS9odWIuYwo+ICsrKyBiL2RyaXZl cnMvdXNiL2NvcmUvaHViLmMKPiBAQCAtODI5LDcgKzgyOSw2IEBAIGludCB1c2JfaHViX2NsZWFy X3R0X2J1ZmZlcihzdHJ1Y3QgdXJiICp1cmIpCj4gIAkgKi8KPiAgCWNsZWFyID0ga21hbGxvYyhz aXplb2YgKmNsZWFyLCBHRlBfQVRPTUlDKTsKPiAgCWlmIChjbGVhciA9PSBOVUxMKSB7Cj4gLQkJ ZGV2X2VycigmdWRldi0+ZGV2LCAiY2FuJ3Qgc2F2ZSBDTEVBUl9UVF9CVUZGRVIgc3RhdGVcbiIp Owo+ICAJCS8qIEZJWE1FIHJlY292ZXIgc29tZWhvdyAuLi4gUkVTRVRfVFQ/ICovCj4gIAkJcmV0 dXJuIC1FTk9NRU07Cj4gIAl9CgpEb2VzIHRoZSBleGlzdGluZyBtZW1vcnkgYWxsb2NhdGlvbiBl cnJvciBtZXNzYWdlIGluY2x1ZGUgdGhlIAomdWRldi0+ZGV2IGRldmljZSBuYW1lIGFuZCBkcml2 ZXIgbmFtZT8gIElmIGl0IGRvZXNuJ3QsIHRoZXJlIHdpbGwgYmUgCm5vIHdheSBmb3IgdGhlIHVz ZXIgdG8gdGVsbCB0aGF0IHRoZSBlcnJvciBtZXNzYWdlIGlzIHJlbGF0ZWQgdG8gdGhlIApkZXZp Y2UgZmFpbHVyZS4KCkFsYW4gU3Rlcm4KLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0 OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEg bWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8g YXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo=