From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73242ECDFB0 for ; Fri, 13 Jul 2018 20:24:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 277FD208A4 for ; Fri, 13 Jul 2018 20:24:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 277FD208A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731932AbeGMUki (ORCPT ); Fri, 13 Jul 2018 16:40:38 -0400 Received: from netrider.rowland.org ([192.131.102.5]:57299 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1731500AbeGMUkh (ORCPT ); Fri, 13 Jul 2018 16:40:37 -0400 X-Greylist: delayed 402 seconds by postgrey-1.27 at vger.kernel.org; Fri, 13 Jul 2018 16:40:37 EDT Received: (qmail 14772 invoked by uid 500); 13 Jul 2018 16:17:46 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 13 Jul 2018 16:17:46 -0400 Date: Fri, 13 Jul 2018 16:17:46 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Colin King cc: Greg Kroah-Hartman , , , Subject: Re: [PATCH] usb: host: ehci-sched: remove redundant pointer dev In-Reply-To: <20180713092956.13247-1-colin.king@canonical.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Jul 2018, Colin King wrote: > From: Colin Ian King > > Pointer dev is being assigned but is never used hence it is > redundant and can be removed. > > Cleans up clang warning: > warning: variable 'dev' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King > --- > drivers/usb/host/ehci-sched.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c > index 1d87295682b8..da7b00a6110b 100644 > --- a/drivers/usb/host/ehci-sched.c > +++ b/drivers/usb/host/ehci-sched.c > @@ -1835,7 +1835,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd) > unsigned uframe; > int urb_index = -1; > struct ehci_iso_stream *stream = itd->stream; > - struct usb_device *dev; > bool retval = false; > > /* for each uframe with a packet */ > @@ -1886,7 +1885,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd) > */ > > /* give urb back to the driver; completion often (re)submits */ > - dev = urb->dev; > ehci_urb_done(ehci, urb, 0); > retval = true; > urb = NULL; > @@ -2230,7 +2228,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd) > u32 t; > int urb_index; > struct ehci_iso_stream *stream = sitd->stream; > - struct usb_device *dev; > bool retval = false; > > urb_index = sitd->index; > @@ -2268,7 +2265,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd) > */ > > /* give urb back to the driver; completion often (re)submits */ > - dev = urb->dev; > ehci_urb_done(ehci, urb, 0); > retval = true; > urb = NULL; Acked-by: Alan Stern From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Stern Date: Fri, 13 Jul 2018 20:17:46 +0000 Subject: Re: [PATCH] usb: host: ehci-sched: remove redundant pointer dev Message-Id: List-Id: References: <20180713092956.13247-1-colin.king@canonical.com> In-Reply-To: <20180713092956.13247-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, 13 Jul 2018, Colin King wrote: > From: Colin Ian King > > Pointer dev is being assigned but is never used hence it is > redundant and can be removed. > > Cleans up clang warning: > warning: variable 'dev' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King > --- > drivers/usb/host/ehci-sched.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c > index 1d87295682b8..da7b00a6110b 100644 > --- a/drivers/usb/host/ehci-sched.c > +++ b/drivers/usb/host/ehci-sched.c > @@ -1835,7 +1835,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd) > unsigned uframe; > int urb_index = -1; > struct ehci_iso_stream *stream = itd->stream; > - struct usb_device *dev; > bool retval = false; > > /* for each uframe with a packet */ > @@ -1886,7 +1885,6 @@ static bool itd_complete(struct ehci_hcd *ehci, struct ehci_itd *itd) > */ > > /* give urb back to the driver; completion often (re)submits */ > - dev = urb->dev; > ehci_urb_done(ehci, urb, 0); > retval = true; > urb = NULL; > @@ -2230,7 +2228,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd) > u32 t; > int urb_index; > struct ehci_iso_stream *stream = sitd->stream; > - struct usb_device *dev; > bool retval = false; > > urb_index = sitd->index; > @@ -2268,7 +2265,6 @@ static bool sitd_complete(struct ehci_hcd *ehci, struct ehci_sitd *sitd) > */ > > /* give urb back to the driver; completion often (re)submits */ > - dev = urb->dev; > ehci_urb_done(ehci, urb, 0); > retval = true; > urb = NULL; Acked-by: Alan Stern From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: host: ehci-sched: remove redundant pointer dev From: Alan Stern Message-Id: Date: Fri, 13 Jul 2018 16:17:46 -0400 (EDT) To: Colin King Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gRnJpLCAxMyBKdWwgMjAxOCwgQ29saW4gS2luZyB3cm90ZToKCj4gRnJvbTogQ29saW4gSWFu IEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4KPiAKPiBQb2ludGVyIGRldiBpcyBiZWlu ZyBhc3NpZ25lZCBidXQgaXMgbmV2ZXIgdXNlZCBoZW5jZSBpdCBpcwo+IHJlZHVuZGFudCBhbmQg Y2FuIGJlIHJlbW92ZWQuCj4gCj4gQ2xlYW5zIHVwIGNsYW5nIHdhcm5pbmc6Cj4gd2FybmluZzog dmFyaWFibGUgJ2Rldicgc2V0IGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJs ZV0KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmlj YWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3VzYi9ob3N0L2VoY2ktc2NoZWQuYyB8IDQgLS0tLQo+ ICAxIGZpbGUgY2hhbmdlZCwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy91c2IvaG9zdC9laGNpLXNjaGVkLmMgYi9kcml2ZXJzL3VzYi9ob3N0L2VoY2ktc2NoZWQuYwo+ IGluZGV4IDFkODcyOTU2ODJiOC4uZGE3YjAwYTYxMTBiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv dXNiL2hvc3QvZWhjaS1zY2hlZC5jCj4gKysrIGIvZHJpdmVycy91c2IvaG9zdC9laGNpLXNjaGVk LmMKPiBAQCAtMTgzNSw3ICsxODM1LDYgQEAgc3RhdGljIGJvb2wgaXRkX2NvbXBsZXRlKHN0cnVj dCBlaGNpX2hjZCAqZWhjaSwgc3RydWN0IGVoY2lfaXRkICppdGQpCj4gIAl1bnNpZ25lZAkJCQl1 ZnJhbWU7Cj4gIAlpbnQJCQkJCXVyYl9pbmRleCA9IC0xOwo+ICAJc3RydWN0IGVoY2lfaXNvX3N0 cmVhbQkJCSpzdHJlYW0gPSBpdGQtPnN0cmVhbTsKPiAtCXN0cnVjdCB1c2JfZGV2aWNlCQkJKmRl djsKPiAgCWJvb2wJCQkJCXJldHZhbCA9IGZhbHNlOwo+ICAKPiAgCS8qIGZvciBlYWNoIHVmcmFt ZSB3aXRoIGEgcGFja2V0ICovCj4gQEAgLTE4ODYsNyArMTg4NSw2IEBAIHN0YXRpYyBib29sIGl0 ZF9jb21wbGV0ZShzdHJ1Y3QgZWhjaV9oY2QgKmVoY2ksIHN0cnVjdCBlaGNpX2l0ZCAqaXRkKQo+ ICAJICovCj4gIAo+ICAJLyogZ2l2ZSB1cmIgYmFjayB0byB0aGUgZHJpdmVyOyBjb21wbGV0aW9u IG9mdGVuIChyZSlzdWJtaXRzICovCj4gLQlkZXYgPSB1cmItPmRldjsKPiAgCWVoY2lfdXJiX2Rv bmUoZWhjaSwgdXJiLCAwKTsKPiAgCXJldHZhbCA9IHRydWU7Cj4gIAl1cmIgPSBOVUxMOwo+IEBA IC0yMjMwLDcgKzIyMjgsNiBAQCBzdGF0aWMgYm9vbCBzaXRkX2NvbXBsZXRlKHN0cnVjdCBlaGNp X2hjZCAqZWhjaSwgc3RydWN0IGVoY2lfc2l0ZCAqc2l0ZCkKPiAgCXUzMgkJCQkJdDsKPiAgCWlu dAkJCQkJdXJiX2luZGV4Owo+ICAJc3RydWN0IGVoY2lfaXNvX3N0cmVhbQkJCSpzdHJlYW0gPSBz aXRkLT5zdHJlYW07Cj4gLQlzdHJ1Y3QgdXNiX2RldmljZQkJCSpkZXY7Cj4gIAlib29sCQkJCQly ZXR2YWwgPSBmYWxzZTsKPiAgCj4gIAl1cmJfaW5kZXggPSBzaXRkLT5pbmRleDsKPiBAQCAtMjI2 OCw3ICsyMjY1LDYgQEAgc3RhdGljIGJvb2wgc2l0ZF9jb21wbGV0ZShzdHJ1Y3QgZWhjaV9oY2Qg KmVoY2ksIHN0cnVjdCBlaGNpX3NpdGQgKnNpdGQpCj4gIAkgKi8KPiAgCj4gIAkvKiBnaXZlIHVy YiBiYWNrIHRvIHRoZSBkcml2ZXI7IGNvbXBsZXRpb24gb2Z0ZW4gKHJlKXN1Ym1pdHMgKi8KPiAt CWRldiA9IHVyYi0+ZGV2Owo+ICAJZWhjaV91cmJfZG9uZShlaGNpLCB1cmIsIDApOwo+ICAJcmV0 dmFsID0gdHJ1ZTsKPiAgCXVyYiA9IE5VTEw7CgpBY2tlZC1ieTogQWxhbiBTdGVybiA8c3Rlcm5A cm93bGFuZC5oYXJ2YXJkLmVkdT4KLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBz ZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVz c2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQg IGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo=