From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BCCCC282C8 for ; Mon, 28 Jan 2019 15:33:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 375632147A for ; Mon, 28 Jan 2019 15:33:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbfA1Pdy (ORCPT ); Mon, 28 Jan 2019 10:33:54 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:57014 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726694AbfA1Pdy (ORCPT ); Mon, 28 Jan 2019 10:33:54 -0500 Received: (qmail 3364 invoked by uid 2102); 28 Jan 2019 10:33:53 -0500 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 28 Jan 2019 10:33:53 -0500 Date: Mon, 28 Jan 2019 10:33:53 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Yinbo Zhu cc: Xiaobo Xie , Jerry Huang , Ran Wang , Greg Kroah-Hartman , Ramneek Mehresh , Nikhil Badola , Suresh Gupta , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 1/5] usb: fsl: Set USB_EN bit to select ULPI phy In-Reply-To: <20190125060356.14294-1-yinbo.zhu@nxp.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Jan 2019, Yinbo Zhu wrote: > From: Nikhil Badola > > Set USB_EN bit to select ULPI phy for USB controller version 2.5 > > Signed-off-by: Nikhil Badola > Signed-off-by: Yinbo Zhu > --- Acked-by: Alan Stern > Change in v4: > Incorrect indentation of the continuation line > > drivers/usb/host/ehci-fsl.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c > index e3d0c1c..38674b7 100644 > --- a/drivers/usb/host/ehci-fsl.c > +++ b/drivers/usb/host/ehci-fsl.c > @@ -122,6 +122,12 @@ static int fsl_ehci_drv_probe(struct platform_device *pdev) > tmp |= 0x4; > iowrite32be(tmp, hcd->regs + FSL_SOC_USB_CTRL); > } > + > + /* Set USB_EN bit to select ULPI phy for USB controller version 2.5 */ > + if (pdata->controller_ver == FSL_USB_VER_2_5 && > + pdata->phy_mode == FSL_USB2_PHY_ULPI) > + iowrite32be(USB_CTRL_USB_EN, hcd->regs + FSL_SOC_USB_CTRL); > + > /* > * Enable UTMI phy and program PTS field in UTMI mode before asserting > * controller reset for USB Controller version 2.5 > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,1/5] usb: fsl: Set USB_EN bit to select ULPI phy From: Alan Stern Message-Id: Date: Mon, 28 Jan 2019 10:33:53 -0500 (EST) To: Yinbo Zhu Cc: Xiaobo Xie , Jerry Huang , Ran Wang , Greg Kroah-Hartman , Ramneek Mehresh , Nikhil Badola , Suresh Gupta , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gRnJpLCAyNSBKYW4gMjAxOSwgWWluYm8gWmh1IHdyb3RlOgoKPiBGcm9tOiBOaWtoaWwgQmFk b2xhIDxuaWtoaWwuYmFkb2xhQGZyZWVzY2FsZS5jb20+Cj4gCj4gU2V0IFVTQl9FTiBiaXQgdG8g c2VsZWN0IFVMUEkgcGh5IGZvciBVU0IgY29udHJvbGxlciB2ZXJzaW9uIDIuNQo+IAo+IFNpZ25l ZC1vZmYtYnk6IE5pa2hpbCBCYWRvbGEgPG5pa2hpbC5iYWRvbGFAZnJlZXNjYWxlLmNvbT4KPiBT aWduZWQtb2ZmLWJ5OiBZaW5ibyBaaHUgPHlpbmJvLnpodUBueHAuY29tPgo+IC0tLQoKQWNrZWQt Ynk6IEFsYW4gU3Rlcm4gPHN0ZXJuQHJvd2xhbmQuaGFydmFyZC5lZHU+Cgo+IENoYW5nZSBpbiB2 NDoKPiAJCUluY29ycmVjdCBpbmRlbnRhdGlvbiBvZiB0aGUgY29udGludWF0aW9uIGxpbmUKPiAK PiAgZHJpdmVycy91c2IvaG9zdC9laGNpLWZzbC5jIHwgICAgNiArKysrKysKPiAgMSBmaWxlcyBj aGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvdXNiL2hvc3QvZWhjaS1mc2wuYyBiL2RyaXZlcnMvdXNiL2hvc3QvZWhjaS1mc2wu Ywo+IGluZGV4IGUzZDBjMWMuLjM4Njc0YjcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvaG9z dC9laGNpLWZzbC5jCj4gKysrIGIvZHJpdmVycy91c2IvaG9zdC9laGNpLWZzbC5jCj4gQEAgLTEy Miw2ICsxMjIsMTIgQEAgc3RhdGljIGludCBmc2xfZWhjaV9kcnZfcHJvYmUoc3RydWN0IHBsYXRm b3JtX2RldmljZSAqcGRldikKPiAgCQl0bXAgfD0gMHg0Owo+ICAJCWlvd3JpdGUzMmJlKHRtcCwg aGNkLT5yZWdzICsgRlNMX1NPQ19VU0JfQ1RSTCk7Cj4gIAl9Cj4gKwo+ICsJLyogU2V0IFVTQl9F TiBiaXQgdG8gc2VsZWN0IFVMUEkgcGh5IGZvciBVU0IgY29udHJvbGxlciB2ZXJzaW9uIDIuNSAq Lwo+ICsJaWYgKHBkYXRhLT5jb250cm9sbGVyX3ZlciA9PSBGU0xfVVNCX1ZFUl8yXzUgJiYKPiAr CSAgICBwZGF0YS0+cGh5X21vZGUgPT0gRlNMX1VTQjJfUEhZX1VMUEkpCj4gKwkJaW93cml0ZTMy YmUoVVNCX0NUUkxfVVNCX0VOLCBoY2QtPnJlZ3MgKyBGU0xfU09DX1VTQl9DVFJMKTsKPiArCj4g IAkvKgo+ICAJICogRW5hYmxlIFVUTUkgcGh5IGFuZCBwcm9ncmFtIFBUUyBmaWVsZCBpbiBVVE1J IG1vZGUgYmVmb3JlIGFzc2VydGluZwo+ICAJICogY29udHJvbGxlciByZXNldCBmb3IgVVNCIENv bnRyb2xsZXIgdmVyc2lvbiAyLjUKPgo=