From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D002C282C8 for ; Mon, 28 Jan 2019 15:38:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22C702148E for ; Mon, 28 Jan 2019 15:38:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726867AbfA1PiM (ORCPT ); Mon, 28 Jan 2019 10:38:12 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:57062 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726775AbfA1PiL (ORCPT ); Mon, 28 Jan 2019 10:38:11 -0500 Received: (qmail 3465 invoked by uid 2102); 28 Jan 2019 10:38:11 -0500 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 28 Jan 2019 10:38:11 -0500 Date: Mon, 28 Jan 2019 10:38:11 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Yinbo Zhu cc: Xiaobo Xie , Jerry Huang , Ran Wang , Greg Kroah-Hartman , Ramneek Mehresh , Nikhil Badola , Suresh Gupta , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 4/5] usb: host: Stops USB controller init if PLL fails to lock In-Reply-To: <20190125060356.14294-4-yinbo.zhu@nxp.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Jan 2019, Yinbo Zhu wrote: > From: Ramneek Mehresh > > USB erratum-A006918 workaround tries to start internal PHY inside > uboot (when PLL fails to lock). However, if the workaround also > fails, then USB initialization is also stopped inside Linux. > Erratum-A006918 workaround failure creates "fsl,erratum_a006918" > node in device-tree. Presence of this node in device-tree is > used to stop USB controller initialization in Linux > > Signed-off-by: Ramneek Mehresh > Signed-off-by: Suresh Gupta > Signed-off-by: Yinbo Zhu > --- > drivers/usb/host/ehci-fsl.c | 5 +++++ > drivers/usb/host/fsl-mph-dr-of.c | 3 ++- > 2 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c > index 373a816..8b47277 100644 > --- a/drivers/usb/host/ehci-fsl.c > +++ b/drivers/usb/host/ehci-fsl.c > @@ -236,6 +236,11 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd, > portsc |= PORT_PTS_PTW; > /* fall through */ > case FSL_USB2_PHY_UTMI: > + if (pdata->has_fsl_erratum_a006918) { > + pr_warn("fsl-ehci: USB PHY clock invalid\n"); Again, you should use dev_warn() instead of pr_warn(). Alan Stern > + return -EINVAL; > + } > + > case FSL_USB2_PHY_UTMI_DUAL: > /* PHY_CLK_VALID bit is de-featured from all controller > * versions below 2.4 and is to be checked only for > diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c > index 4f8b8a0..762b976 100644 > --- a/drivers/usb/host/fsl-mph-dr-of.c > +++ b/drivers/usb/host/fsl-mph-dr-of.c > @@ -224,13 +224,14 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev) > of_property_read_bool(np, "fsl,usb-erratum-a005275"); > pdata->has_fsl_erratum_a005697 = > of_property_read_bool(np, "fsl,usb_erratum-a005697"); > + pdata->has_fsl_erratum_a006918 = > + of_property_read_bool(np, "fsl,usb_erratum-a006918"); > > if (of_get_property(np, "fsl,usb_erratum_14", NULL)) > pdata->has_fsl_erratum_14 = 1; > else > pdata->has_fsl_erratum_14 = 0; > > - > /* > * Determine whether phy_clk_valid needs to be checked > * by reading property in device tree > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4,4/5] usb: host: Stops USB controller init if PLL fails to lock From: Alan Stern Message-Id: Date: Mon, 28 Jan 2019 10:38:11 -0500 (EST) To: Yinbo Zhu Cc: Xiaobo Xie , Jerry Huang , Ran Wang , Greg Kroah-Hartman , Ramneek Mehresh , Nikhil Badola , Suresh Gupta , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gRnJpLCAyNSBKYW4gMjAxOSwgWWluYm8gWmh1IHdyb3RlOgoKPiBGcm9tOiBSYW1uZWVrIE1l aHJlc2ggPHJhbW5lZWsubWVocmVzaEBmcmVlc2NhbGUuY29tPgo+IAo+IFVTQiBlcnJhdHVtLUEw MDY5MTggd29ya2Fyb3VuZCB0cmllcyB0byBzdGFydCBpbnRlcm5hbCBQSFkgaW5zaWRlCj4gdWJv b3QgKHdoZW4gUExMIGZhaWxzIHRvIGxvY2spLiBIb3dldmVyLCBpZiB0aGUgd29ya2Fyb3VuZCBh bHNvCj4gZmFpbHMsIHRoZW4gVVNCIGluaXRpYWxpemF0aW9uIGlzIGFsc28gc3RvcHBlZCBpbnNp ZGUgTGludXguCj4gRXJyYXR1bS1BMDA2OTE4IHdvcmthcm91bmQgZmFpbHVyZSBjcmVhdGVzICJm c2wsZXJyYXR1bV9hMDA2OTE4Igo+IG5vZGUgaW4gZGV2aWNlLXRyZWUuIFByZXNlbmNlIG9mIHRo aXMgbm9kZSBpbiBkZXZpY2UtdHJlZSBpcwo+IHVzZWQgdG8gc3RvcCBVU0IgY29udHJvbGxlciBp bml0aWFsaXphdGlvbiBpbiBMaW51eAo+IAo+IFNpZ25lZC1vZmYtYnk6IFJhbW5lZWsgTWVocmVz aCA8cmFtbmVlay5tZWhyZXNoQGZyZWVzY2FsZS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogU3VyZXNo IEd1cHRhIDxzdXJlc2guZ3VwdGFAZnJlZXNjYWxlLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBZaW5i byBaaHUgPHlpbmJvLnpodUBueHAuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3VzYi9ob3N0L2VoY2kt ZnNsLmMgICAgICB8ICAgIDUgKysrKysKPiAgZHJpdmVycy91c2IvaG9zdC9mc2wtbXBoLWRyLW9m LmMgfCAgICAzICsrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvaG9zdC9laGNpLWZzbC5jIGIv ZHJpdmVycy91c2IvaG9zdC9laGNpLWZzbC5jCj4gaW5kZXggMzczYTgxNi4uOGI0NzI3NyAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi9ob3N0L2VoY2ktZnNsLmMKPiArKysgYi9kcml2ZXJzL3Vz Yi9ob3N0L2VoY2ktZnNsLmMKPiBAQCAtMjM2LDYgKzIzNiwxMSBAQCBzdGF0aWMgaW50IGVoY2lf ZnNsX3NldHVwX3BoeShzdHJ1Y3QgdXNiX2hjZCAqaGNkLAo+ICAJCXBvcnRzYyB8PSBQT1JUX1BU U19QVFc7Cj4gIAkJLyogZmFsbCB0aHJvdWdoICovCj4gIAljYXNlIEZTTF9VU0IyX1BIWV9VVE1J Ogo+ICsJCWlmIChwZGF0YS0+aGFzX2ZzbF9lcnJhdHVtX2EwMDY5MTgpIHsKPiArCQkJcHJfd2Fy bigiZnNsLWVoY2k6IFVTQiBQSFkgY2xvY2sgaW52YWxpZFxuIik7CgpBZ2FpbiwgeW91IHNob3Vs ZCB1c2UgZGV2X3dhcm4oKSBpbnN0ZWFkIG9mIHByX3dhcm4oKS4KCkFsYW4gU3Rlcm4KCj4gKwkJ CXJldHVybiAtRUlOVkFMOwo+ICsJCX0KPiArCj4gIAljYXNlIEZTTF9VU0IyX1BIWV9VVE1JX0RV QUw6Cj4gIAkJLyogUEhZX0NMS19WQUxJRCBiaXQgaXMgZGUtZmVhdHVyZWQgZnJvbSBhbGwgY29u dHJvbGxlcgo+ICAJCSAqIHZlcnNpb25zIGJlbG93IDIuNCBhbmQgaXMgdG8gYmUgY2hlY2tlZCBv bmx5IGZvcgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9ob3N0L2ZzbC1tcGgtZHItb2YuYyBi L2RyaXZlcnMvdXNiL2hvc3QvZnNsLW1waC1kci1vZi5jCj4gaW5kZXggNGY4YjhhMC4uNzYyYjk3 NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi9ob3N0L2ZzbC1tcGgtZHItb2YuYwo+ICsrKyBi L2RyaXZlcnMvdXNiL2hvc3QvZnNsLW1waC1kci1vZi5jCj4gQEAgLTIyNCwxMyArMjI0LDE0IEBA IHN0YXRpYyBpbnQgZnNsX3VzYjJfbXBoX2RyX29mX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZp Y2UgKm9mZGV2KQo+ICAJCW9mX3Byb3BlcnR5X3JlYWRfYm9vbChucCwgImZzbCx1c2ItZXJyYXR1 bS1hMDA1Mjc1Iik7Cj4gIAlwZGF0YS0+aGFzX2ZzbF9lcnJhdHVtX2EwMDU2OTcgPQo+ICAJCW9m X3Byb3BlcnR5X3JlYWRfYm9vbChucCwgImZzbCx1c2JfZXJyYXR1bS1hMDA1Njk3Iik7Cj4gKwlw ZGF0YS0+aGFzX2ZzbF9lcnJhdHVtX2EwMDY5MTggPQo+ICsJCW9mX3Byb3BlcnR5X3JlYWRfYm9v bChucCwgImZzbCx1c2JfZXJyYXR1bS1hMDA2OTE4Iik7Cj4gIAo+ICAJaWYgKG9mX2dldF9wcm9w ZXJ0eShucCwgImZzbCx1c2JfZXJyYXR1bV8xNCIsIE5VTEwpKQo+ICAJCXBkYXRhLT5oYXNfZnNs X2VycmF0dW1fMTQgPSAxOwo+ICAJZWxzZQo+ICAJCXBkYXRhLT5oYXNfZnNsX2VycmF0dW1fMTQg PSAwOwo+ICAKPiAtCj4gIAkvKgo+ICAJICogRGV0ZXJtaW5lIHdoZXRoZXIgcGh5X2Nsa192YWxp ZCBuZWVkcyB0byBiZSBjaGVja2VkCj4gIAkgKiBieSByZWFkaW5nIHByb3BlcnR5IGluIGRldmlj ZSB0cmVlCj4K