From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86084C43381 for ; Thu, 28 Mar 2019 14:38:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B794217F9 for ; Thu, 28 Mar 2019 14:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbfC1OiE (ORCPT ); Thu, 28 Mar 2019 10:38:04 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:53422 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726243AbfC1OiD (ORCPT ); Thu, 28 Mar 2019 10:38:03 -0400 Received: (qmail 2706 invoked by uid 2102); 28 Mar 2019 10:38:02 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 28 Mar 2019 10:38:02 -0400 Date: Thu, 28 Mar 2019 10:38:02 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Bartosz Golaszewski cc: Sekhar Nori , Kevin Hilman , Greg Kroah-Hartman , Linux ARM , Linux Kernel Mailing List , , Bartosz Golaszewski Subject: Re: [PATCH 0/3] ARM: davinci: ohci-da8xx: model the vbus GPIO as a fixed regulator In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Mar 2019, Bartosz Golaszewski wrote: > czw., 28 mar 2019 o 15:11 Alan Stern napisał(a): > > > > On Thu, 28 Mar 2019, Sekhar Nori wrote: > > > > > >> Can you document why the current solution is not optimal? Is it to make > > > >> future device-tree conversion for these boards easier? Or? > > > >> > > > > > > > > It's sub-optimal from the HW modeling in SW PoV - it is in fact a > > > > regulator enabled/disabled by a GPIO. Also: it's code duplication as > > > > currently we check if the vbus GPIO exists and then use it or check if > > > > the regulator exists and use this as the second choice. The third > > > > patch actually shrinks the driver. > > > > > > I see now that the driver supports controlling the VBUS gpio as > > > regulator already. Something I should have caught in review last time > > > around. > > > > > > I agree this patch is an improvement. Lets see what Alan feels. > > > > I'm not an expert on this stuff, but the patch looks reasonable. > > However, I do wish that in the devm_request_threaded_irq() call, the > > indentation of the continuation lines was left unchanged. > > > > I don't think it's possible - the function name is longer and the > first line exceeds the 80 characters limit. I can put all the > parameters below the function name if you prefer that? Which line the arguments go on doesn't matter. But increasing the amount of indentation, like the patch did, makes the whole thing less readable, IMO. It makes everything end up crammed against the right margin. Alan Stern From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B4D1C43381 for ; Thu, 28 Mar 2019 14:38:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25E92217F9 for ; Thu, 28 Mar 2019 14:38:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aabvGNqL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25E92217F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=oK44thTLZZuR1zsDAmCIuCZlmeJRPV00yoltYuLQTeI=; b=aabvGNqLyyCeJt UAlQFPgktXVkVdHcCsbgWDAZjnlP+ZoqyXWNQDn6TmbBvTjzRPwZbhHqTtXRt4FTM2XuaLibwF+4d c7wTPsHW3txAGZny2h6ykTYtFYztV09oeMogFk4WzoeASuo8JP4BYknPqvYvn7GYXEjwunAaFozyf VNgf8hWMj43C/rEpxVg1MAv2MhKvn4E1UtcNmRdMkAGE4kBWsbb8vYIR9arQGELia69z1buM9KJYl TiC8plh1zwBrh2dXRj57Do3GWLrU16ASAfTfE4UICx6X0tpqSv1uCY3/CwIz4Rhm1jSyFoGN6rsoU 3oSPngbevJ4SZJPMMdZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9WAR-00021J-0E; Thu, 28 Mar 2019 14:38:07 +0000 Received: from iolanthe.rowland.org ([192.131.102.54]) by bombadil.infradead.org with smtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9WAN-00020m-RU for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2019 14:38:05 +0000 Received: (qmail 2706 invoked by uid 2102); 28 Mar 2019 10:38:02 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 28 Mar 2019 10:38:02 -0400 Date: Thu, 28 Mar 2019 10:38:02 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Bartosz Golaszewski Subject: Re: [PATCH 0/3] ARM: davinci: ohci-da8xx: model the vbus GPIO as a fixed regulator In-Reply-To: Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_073804_038188_282ACD0C X-CRM114-Status: GOOD ( 17.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Hilman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Sekhar Nori , Linux Kernel Mailing List , Bartosz Golaszewski , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyOCBNYXIgMjAxOSwgQmFydG9zeiBHb2xhc3pld3NraSB3cm90ZToKCj4gY3p3Liwg MjggbWFyIDIwMTkgbyAxNToxMSBBbGFuIFN0ZXJuIDxzdGVybkByb3dsYW5kLmhhcnZhcmQuZWR1 PiBuYXBpc2HFgihhKToKPiA+Cj4gPiBPbiBUaHUsIDI4IE1hciAyMDE5LCBTZWtoYXIgTm9yaSB3 cm90ZToKPiA+Cj4gPiA+ID4+IENhbiB5b3UgZG9jdW1lbnQgd2h5IHRoZSBjdXJyZW50IHNvbHV0 aW9uIGlzIG5vdCBvcHRpbWFsPyBJcyBpdCB0byBtYWtlCj4gPiA+ID4+IGZ1dHVyZSBkZXZpY2Ut dHJlZSBjb252ZXJzaW9uIGZvciB0aGVzZSBib2FyZHMgZWFzaWVyPyBPcj8KPiA+ID4gPj4KPiA+ ID4gPgo+ID4gPiA+IEl0J3Mgc3ViLW9wdGltYWwgZnJvbSB0aGUgSFcgbW9kZWxpbmcgaW4gU1cg UG9WIC0gaXQgaXMgaW4gZmFjdCBhCj4gPiA+ID4gcmVndWxhdG9yIGVuYWJsZWQvZGlzYWJsZWQg YnkgYSBHUElPLiBBbHNvOiBpdCdzIGNvZGUgZHVwbGljYXRpb24gYXMKPiA+ID4gPiBjdXJyZW50 bHkgd2UgY2hlY2sgaWYgdGhlIHZidXMgR1BJTyBleGlzdHMgYW5kIHRoZW4gdXNlIGl0IG9yIGNo ZWNrIGlmCj4gPiA+ID4gdGhlIHJlZ3VsYXRvciBleGlzdHMgYW5kIHVzZSB0aGlzIGFzIHRoZSBz ZWNvbmQgY2hvaWNlLiBUaGUgdGhpcmQKPiA+ID4gPiBwYXRjaCBhY3R1YWxseSBzaHJpbmtzIHRo ZSBkcml2ZXIuCj4gPiA+Cj4gPiA+IEkgc2VlIG5vdyB0aGF0IHRoZSBkcml2ZXIgc3VwcG9ydHMg Y29udHJvbGxpbmcgdGhlIFZCVVMgZ3BpbyBhcwo+ID4gPiByZWd1bGF0b3IgYWxyZWFkeS4gU29t ZXRoaW5nIEkgc2hvdWxkIGhhdmUgY2F1Z2h0IGluIHJldmlldyBsYXN0IHRpbWUKPiA+ID4gYXJv dW5kLgo+ID4gPgo+ID4gPiBJIGFncmVlIHRoaXMgcGF0Y2ggaXMgYW4gaW1wcm92ZW1lbnQuIExl dHMgc2VlIHdoYXQgQWxhbiBmZWVscy4KPiA+Cj4gPiBJJ20gbm90IGFuIGV4cGVydCBvbiB0aGlz IHN0dWZmLCBidXQgdGhlIHBhdGNoIGxvb2tzIHJlYXNvbmFibGUuCj4gPiBIb3dldmVyLCBJIGRv IHdpc2ggdGhhdCBpbiB0aGUgZGV2bV9yZXF1ZXN0X3RocmVhZGVkX2lycSgpIGNhbGwsIHRoZQo+ ID4gaW5kZW50YXRpb24gb2YgdGhlIGNvbnRpbnVhdGlvbiBsaW5lcyB3YXMgbGVmdCB1bmNoYW5n ZWQuCj4gPgo+IAo+IEkgZG9uJ3QgdGhpbmsgaXQncyBwb3NzaWJsZSAtIHRoZSBmdW5jdGlvbiBu YW1lIGlzIGxvbmdlciBhbmQgdGhlCj4gZmlyc3QgbGluZSBleGNlZWRzIHRoZSA4MCBjaGFyYWN0 ZXJzIGxpbWl0LiBJIGNhbiBwdXQgYWxsIHRoZQo+IHBhcmFtZXRlcnMgYmVsb3cgdGhlIGZ1bmN0 aW9uIG5hbWUgaWYgeW91IHByZWZlciB0aGF0PwoKV2hpY2ggbGluZSB0aGUgYXJndW1lbnRzIGdv IG9uIGRvZXNuJ3QgbWF0dGVyLiAgQnV0IGluY3JlYXNpbmcgdGhlIAphbW91bnQgb2YgaW5kZW50 YXRpb24sIGxpa2UgdGhlIHBhdGNoIGRpZCwgbWFrZXMgdGhlIHdob2xlIHRoaW5nIGxlc3MgCnJl YWRhYmxlLCBJTU8uICBJdCBtYWtlcyBldmVyeXRoaW5nIGVuZCB1cCBjcmFtbWVkIGFnYWluc3Qg dGhlIHJpZ2h0IAptYXJnaW4uCgpBbGFuIFN0ZXJuCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=