All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: "Bollinger, Seth" <Seth.Bollinger@digi.com>
Cc: Ming Lei <tom.leiming@gmail.com>, Jens Axboe <axboe@kernel.dk>,
	USB list <linux-usb@vger.kernel.org>,
	linux-block <linux-block@vger.kernel.org>
Subject: Re: Bug: VHCI + USB 3.0
Date: Tue, 9 Apr 2019 15:57:15 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.1904091552331.1599-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <6FA377F5-595C-4197-850C-5DD8C1B172D5@digi.com>

On Tue, 9 Apr 2019, Bollinger, Seth wrote:

> > Seth, you can try adding:
> >
> >  blk_queue_virt_boundary(sdev->request_queue, 1024 - 1)
> >
> > in drivers/usb/storage/scsiglue.c:slave_alloc(), just after the call to
> > blk_queue_update_dma_alignment().  Perhaps that will help
> >
> 
> I will do that as a test.  However, I’m concerned that we’re solving only a specific case.  Won’t it fail in a similar way if a different subsystem does the same thing (USB modem or video drivers, etc.)?

Those other drivers don't use the block device interface, as far as I 
know.  So they would have to use other methods for addressing the 
potential problems in any case.  usb-storage is perhaps distinct in 
that it doesn't generate the scatter-gather lists that it uses, but 
instead has to work with whatever the block layer provides.

Alan Stern


  reply	other threads:[~2019-04-09 19:57 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05 19:19 Bug: VHCI + USB 3.0 Bollinger, Seth
2019-04-05 21:01 ` Alan Stern
2019-04-05 21:30   ` Bollinger, Seth
2019-04-06 15:34     ` Alan Stern
2019-04-06 15:57       ` Bollinger, Seth
2019-04-06 16:08         ` Alan Stern
2019-04-08 12:39           ` Bollinger, Seth
2019-04-08 14:33             ` Alan Stern
2019-04-08 14:48               ` Bollinger, Seth
2019-04-08 16:29               ` Bollinger, Seth
2019-04-08 17:23                 ` Alan Stern
2019-04-08 18:28                   ` Bollinger, Seth
2019-04-08 18:59                     ` Alan Stern
2019-04-08 19:12                       ` Bollinger, Seth
2019-04-08 19:50                         ` Alan Stern
2019-04-09 13:30                         ` Bollinger, Seth
2019-04-09 14:51                           ` Bollinger, Seth
2019-04-09 13:30                         ` Bollinger, Seth
2019-04-09 15:19                           ` Alan Stern
2019-04-09 15:56                             ` Ming Lei
2019-04-09 19:06                               ` Alan Stern
2019-04-09 19:13                                 ` Bollinger, Seth
2019-04-09 19:57                                   ` Alan Stern [this message]
2019-04-10  8:02                                     ` Oliver Neukum
2019-04-10 14:22                                       ` Alan Stern
2019-04-10 13:50                                   ` Bollinger, Seth
2019-04-10 14:52                                     ` Alan Stern
2019-04-10 14:52                                       ` Alan Stern
2019-04-08 18:39                   ` Bollinger, Seth
2019-04-12 18:01 Alan Stern
2019-04-12 18:01 ` Alan Stern
2019-04-13 11:37 Bollinger, Seth
2019-04-13 11:37 ` Bollinger, Seth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44L0.1904091552331.1599-100000@iolanthe.rowland.org \
    --to=stern@rowland.harvard.edu \
    --cc=Seth.Bollinger@digi.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.