From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: WARNING in usb_submit_urb (4) From: Alan Stern Message-Id: Date: Tue, 16 Apr 2019 13:39:33 -0400 (EDT) To: Andrey Konovalov Cc: syzbot , syzkaller-bugs , USB list List-ID: T24gTW9uLCAxNSBBcHIgMjAxOSwgQW5kcmV5IEtvbm92YWxvdiB3cm90ZToKCj4gT24gTW9uLCBB cHIgMTUsIDIwMTkgYXQgNToxNiBQTSBBbmRyZXkgS29ub3ZhbG92IDxhbmRyZXlrbnZsQGdvb2ds ZS5jb20+IHdyb3RlOgo+ID4KPiA+IE9uIE1vbiwgQXByIDE1LCAyMDE5IGF0IDI6MzQgUE0gc3l6 Ym90Cj4gPiA8c3l6Ym90Kzc2MzRlZGFlYTRkMGIzNDFjNjI1QHN5emthbGxlci5hcHBzcG90bWFp bC5jb20+IHdyb3RlOgo+ID4gPgo+ID4gPiBIZWxsbywKPiA+ID4KPiA+ID4gc3l6Ym90IGhhcyB0 ZXN0ZWQgdGhlIHByb3Bvc2VkIHBhdGNoIGFuZCB0aGUgcmVwcm9kdWNlciBkaWQgbm90IHRyaWdn ZXIKPiA+ID4gY3Jhc2g6Cj4gPiA+Cj4gPiA+IFJlcG9ydGVkLWFuZC10ZXN0ZWQtYnk6Cj4gPiA+ IHN5emJvdCs3NjM0ZWRhZWE0ZDBiMzQxYzYyNUBzeXprYWxsZXIuYXBwc3BvdG1haWwuY29tCj4g Pgo+ID4gSG0sIEkgdGhpbmsgdGhpcyBpcyBzb21lIGtpbmQgb2YgcmFjZSBhbmQgdGhlIHBhdGNo IGFmZmVjdHMgdGhlCj4gPiB0aW1pbmdzLCBzbyB0aGlzIGNhbid0IGJlIHJlcHJvZHVjZWQgdGhh dCBlYXNpbHkuIEknbGwgdHJ5IHRvIGRvIGl0Cj4gPiBtYW51YWxseS4KPiAKPiBIbSwgbm93IEkn bSBoYXZpbmcgdHJvdWJsZXMgdG8gcmVwcm9kdWNlIGl0IG1hbnVhbGx5LiBMZXQncyB0cnkgeW91 cgo+IGRlYnVnIHBhdGNoIG9uY2UgbW9yZSBvbiB0aGUgZXhhY3QgY29tbWl0IHRoaXMgd2FzIHJl cG9ydGVkLiBJZiBpdAo+IGRvZXNuJ3QgdHJpZ2dlciwgSSB0aGluayB0aGUgYmVzdCB0aGluZyB3 b3VsZCBiZSB0byBjbG9zZSB0aGlzIHJlcG9ydAo+IGFzIGludmFsaWQsIGFuZCB3YWl0IGZvciBz eXpib3QgdG8gKGhvcGVmdWxseSkgZ2VuZXJhdGUgYSBmcmVzaAo+IHJlcHJvZHVjZXIuCj4gCj4g I3N5eiB0ZXN0OiBnaXQ6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQv dG9ydmFsZHMvbGludXguZ2l0Cj4gZTEyZTAwZTM4OGRlCgpPa2F5LCBsZXQncyB0cnkgYSBzaW1w bGVyIGFuZCBsZXNzIGludHJ1c2l2ZSBkZWJ1Z2dpbmcgcGF0Y2guCgpBbGFuIFN0ZXJuCgoKI3N5 eiB0ZXN0OiBnaXQ6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdG9y dmFsZHMvbGludXguZ2l0IGUxMmUwMGUzODhkZQoKLS0tIGEvZHJpdmVycy91c2IvY29yZS9odWIu YworKysgYi9kcml2ZXJzL3VzYi9jb3JlL2h1Yi5jCkBAIC0xMDE2LDYgKzEwMTYsOCBAQCBzdGF0 aWMgdm9pZCBodWJfYWN0aXZhdGUoc3RydWN0IHVzYl9odWIKIAlib29sIG5lZWRfZGVib3VuY2Vf ZGVsYXkgPSBmYWxzZTsKIAl1bnNpZ25lZCBkZWxheTsKIAorCWRldl9pbmZvKGh1Yi0+aW50ZmRl diwgIiVzIHR5cGUgJWRcbiIsIF9fZnVuY19fLCB0eXBlKTsKKwogCS8qIENvbnRpbnVlIGEgcGFy dGlhbCBpbml0aWFsaXphdGlvbiAqLwogCWlmICh0eXBlID09IEhVQl9JTklUMiB8fCB0eXBlID09 IEhVQl9JTklUMykgewogCQlkZXZpY2VfbG9jaygmaGRldi0+ZGV2KTsKQEAgLTEyNTQsNiArMTI1 Niw3IEBAIHN0YXRpYyB2b2lkIGh1Yl9hY3RpdmF0ZShzdHJ1Y3QgdXNiX2h1YgogIGluaXQzOgog CWh1Yi0+cXVpZXNjaW5nID0gMDsKIAorCWRldl9pbmZvKGh1Yi0+aW50ZmRldiwgIlN1Ym1pdHRp bmcgc3RhdHVzIFVSQlxuIik7CiAJc3RhdHVzID0gdXNiX3N1Ym1pdF91cmIoaHViLT51cmIsIEdG UF9OT0lPKTsKIAlpZiAoc3RhdHVzIDwgMCkKIAkJZGV2X2VycihodWItPmludGZkZXYsICJhY3Rp dmF0ZSAtLT4gJWRcbiIsIHN0YXR1cyk7CkBAIC0zNzExLDcgKzM3MTQsNyBAQCBzdGF0aWMgaW50 IGh1Yl9zdXNwZW5kKHN0cnVjdCB1c2JfaW50ZXJmCiAJCX0KIAl9CiAKLQlkZXZfZGJnKCZpbnRm LT5kZXYsICIlc1xuIiwgX19mdW5jX18pOworCWRldl9pbmZvKCZpbnRmLT5kZXYsICIlc1xuIiwg X19mdW5jX18pOwogCiAJLyogc3RvcCBodWJfd3EgYW5kIHJlbGF0ZWQgYWN0aXZpdHkgKi8KIAlo dWJfcXVpZXNjZShodWIsIEhVQl9TVVNQRU5EKTsKQEAgLTM3NTYsNyArMzc1OSw3IEBAIHN0YXRp YyBpbnQgaHViX3Jlc3VtZShzdHJ1Y3QgdXNiX2ludGVyZmEKIHsKIAlzdHJ1Y3QgdXNiX2h1YiAq aHViID0gdXNiX2dldF9pbnRmZGF0YShpbnRmKTsKIAotCWRldl9kYmcoJmludGYtPmRldiwgIiVz XG4iLCBfX2Z1bmNfXyk7CisJZGV2X2luZm8oJmludGYtPmRldiwgIiVzXG4iLCBfX2Z1bmNfXyk7 CiAJaHViX2FjdGl2YXRlKGh1YiwgSFVCX1JFU1VNRSk7CiAKIAkvKgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B6D9C10F14 for ; Tue, 16 Apr 2019 17:39:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46A8F2073F for ; Tue, 16 Apr 2019 17:39:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730200AbfDPRjg (ORCPT ); Tue, 16 Apr 2019 13:39:36 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:43380 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1730180AbfDPRjf (ORCPT ); Tue, 16 Apr 2019 13:39:35 -0400 Received: (qmail 9004 invoked by uid 2102); 16 Apr 2019 13:39:33 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 16 Apr 2019 13:39:33 -0400 Date: Tue, 16 Apr 2019 13:39:33 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Andrey Konovalov cc: syzbot , syzkaller-bugs , USB list Subject: Re: WARNING in usb_submit_urb (4) In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Message-ID: <20190416173933.nCwptaerMtg0zawl4OKz0JVcoeOny12raLmTxDrAOKs@z> On Mon, 15 Apr 2019, Andrey Konovalov wrote: > On Mon, Apr 15, 2019 at 5:16 PM Andrey Konovalov wrote: > > > > On Mon, Apr 15, 2019 at 2:34 PM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot has tested the proposed patch and the reproducer did not trigger > > > crash: > > > > > > Reported-and-tested-by: > > > syzbot+7634edaea4d0b341c625@syzkaller.appspotmail.com > > > > Hm, I think this is some kind of race and the patch affects the > > timings, so this can't be reproduced that easily. I'll try to do it > > manually. > > Hm, now I'm having troubles to reproduce it manually. Let's try your > debug patch once more on the exact commit this was reported. If it > doesn't trigger, I think the best thing would be to close this report > as invalid, and wait for syzbot to (hopefully) generate a fresh > reproducer. > > #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > e12e00e388de Okay, let's try a simpler and less intrusive debugging patch. Alan Stern #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e12e00e388de --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1016,6 +1016,8 @@ static void hub_activate(struct usb_hub bool need_debounce_delay = false; unsigned delay; + dev_info(hub->intfdev, "%s type %d\n", __func__, type); + /* Continue a partial initialization */ if (type == HUB_INIT2 || type == HUB_INIT3) { device_lock(&hdev->dev); @@ -1254,6 +1256,7 @@ static void hub_activate(struct usb_hub init3: hub->quiescing = 0; + dev_info(hub->intfdev, "Submitting status URB\n"); status = usb_submit_urb(hub->urb, GFP_NOIO); if (status < 0) dev_err(hub->intfdev, "activate --> %d\n", status); @@ -3711,7 +3714,7 @@ static int hub_suspend(struct usb_interf } } - dev_dbg(&intf->dev, "%s\n", __func__); + dev_info(&intf->dev, "%s\n", __func__); /* stop hub_wq and related activity */ hub_quiesce(hub, HUB_SUSPEND); @@ -3756,7 +3759,7 @@ static int hub_resume(struct usb_interfa { struct usb_hub *hub = usb_get_intfdata(intf); - dev_dbg(&intf->dev, "%s\n", __func__); + dev_info(&intf->dev, "%s\n", __func__); hub_activate(hub, HUB_RESUME); /*