All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: mathias.nyman@intel.com, <gregkh@linuxfoundation.org>,
	<linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: host: fix implicit declaration error
Date: Sun, 19 Jan 2020 10:45:12 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.2001191040560.28587-100000@netrider.rowland.org> (raw)
In-Reply-To: <20200118235828.14131-1-ansuelsmth@gmail.com>

On Sun, 19 Jan 2020, Ansuel Smith wrote:

> If USB_PCI is not enabled, this error is triggered.
> drivers/usb/host/ehci-pci.c:152:7:
> error: implicit declaration of function 'usb_amd_quirk_pll_check';
>   152 |   if (usb_amd_quirk_pll_check())
>       |       ^~~~~~~~~~~~~~~~~~~~~~~
>       |       usb_amd_quirk_pll_enable
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>

I'm a little confused by this.  ehci-pci.c doesn't get compiled 
unless CONFIG_USB_EHCI_PCI is set, and that symbol depends on 
CONFIG_USB_PCI.  So how can this situation ever occur?

Alan Stern


      parent reply	other threads:[~2020-01-19 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-18 23:58 [PATCH] usb: host: fix implicit declaration error Ansuel Smith
2020-01-19 12:53 ` Greg KH
2020-01-19 13:19   ` ansuelsmth
2020-01-22  7:01     ` 'Greg KH'
2020-01-19 15:45 ` Alan Stern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44L0.2001191040560.28587-100000@netrider.rowland.org \
    --to=stern@rowland.harvard.edu \
    --cc=ansuelsmth@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.