All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Tim Schumacher <timschumi@gmx.de>
Cc: linux-usb@vger.kernel.org, <stable@vger.kernel.org>
Subject: Re: [PATCH] USB: uas: Add the no-UAS quirk for JMicron JMS561U
Date: Sat, 25 Jan 2020 11:10:35 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.2001251107370.20113-100000@netrider.rowland.org> (raw)
In-Reply-To: <20200125064838.2511-1-timschumi@gmx.de>

On Sat, 25 Jan 2020, Tim Schumacher wrote:

> The JMicron JMS561U (notably used in the Sabrent SATA-to-USB
> bridge) appears to have UAS-related issues when copying large
> amounts of data, causing it to stall.
> 
> Disabling the advertised UAS (either through a command-line
> quirk or through this patch) mitigates those issues.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Tim Schumacher <timschumi@gmx.de>
> ---
>  drivers/usb/storage/unusual_uas.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index 1b23741036ee..eaec7d4973b7 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -97,6 +97,13 @@ UNUSUAL_DEV(0x357d, 0x7788, 0x0000, 0x9999,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_NO_REPORT_OPCODES | US_FL_IGNORE_UAS),
> 
> +/* Reported-by: Tim Schumacher <timschumi@gmx.de> */
> +UNUSUAL_DEV(0x152d, 0x1561, 0x0000, 0x9999,
> +		"JMicron",
> +		"JMS561U",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_IGNORE_UAS),
> +
>  /* Reported-by: Hans de Goede <hdegoede@redhat.com> */
>  UNUSUAL_DEV(0x4971, 0x1012, 0x0000, 0x9999,
>  		"Hitachi",

This entry was added in the wrong place; entries should be sorted by 
Vendor ID and Product ID, as described at the start of the file.  
Please move it to the proper location and resubmit.

Alan Stern


  reply	other threads:[~2020-01-25 16:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-25  6:48 [PATCH] USB: uas: Add the no-UAS quirk for JMicron JMS561U Tim Schumacher
2020-01-25 16:10 ` Alan Stern [this message]
2020-01-25 17:00 ` [PATCH v2] " Tim Schumacher
2020-01-25 18:37   ` Hans de Goede
2020-01-25 19:59     ` Tim Schumacher
2020-01-26 15:21       ` Hans de Goede
2020-01-26 20:46         ` Tim Schumacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44L0.2001251107370.20113-100000@netrider.rowland.org \
    --to=stern@rowland.harvard.edu \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=timschumi@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.