From: Alan Stern <stern@rowland.harvard.edu>
To: Tang Bin <tangbin@cmss.chinamobile.com>
Cc: gregkh@linuxfoundation.org, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe()
Date: Fri, 8 May 2020 09:51:22 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.2005080950180.19653-100000@netrider.rowland.org> (raw)
In-Reply-To: <20200508114453.15436-1-tangbin@cmss.chinamobile.com>
On Fri, 8 May 2020, Tang Bin wrote:
> The function ehci_mxc_drv_probe() does not perform sufficient error
> checking after executing platform_get_irq(), thus fix it.
Aside from the "irq <= 0" issue, the Subject: line should say
"ehci-mxc", not "ehci".
Alan Stern
> Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards")
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/usb/host/ehci-mxc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> index a1eb5ee77..a0b42ba59 100644
> --- a/drivers/usb/host/ehci-mxc.c
> +++ b/drivers/usb/host/ehci-mxc.c
> @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> + if (irq < 0)
> + return irq;
>
> hcd = usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev));
> if (!hcd)
>
next prev parent reply other threads:[~2020-05-08 13:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 11:44 [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() Tang Bin
2020-05-08 11:48 ` Greg KH
2020-05-08 13:55 ` [PATCH] USB: host: ehci: Add error handling inehci_mxc_drv_probe() Tang Bin
2020-05-08 14:31 ` Greg KH
2020-05-08 15:03 ` [PATCH] USB: host: ehci: Add error handlinginehci_mxc_drv_probe() Tang Bin
2020-05-08 20:27 ` Sergei Shtylyov
2020-05-09 1:13 ` Tang Bin
2020-05-08 20:30 ` [PATCH] USB: host: ehci: Add error handling in ehci_mxc_drv_probe() Sergei Shtylyov
2020-05-08 13:51 ` Alan Stern [this message]
2020-05-13 12:55 ` Tang Bin
2020-05-13 13:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.2005080950180.19653-100000@netrider.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.