From: Zwane Mwaikambo <zwane@arm.linux.org.uk>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: bcollins@debian.org
Subject: [PATCH][2.6] Fix warning in iee1394 dma.c
Date: Wed, 16 Jul 2003 02:01:38 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.53.0307160156480.32541@montezuma.mastecende.com> (raw)
I also removed the panic, the BUG should shaft things bad enough.
drivers/ieee1394/dma.c: In function `dma_region_find':
drivers/ieee1394/dma.c:161: warning: control reaches end of non-void function
Index: linux-2.5/drivers/ieee1394/dma.c
===================================================================
RCS file: /home/cvs/linux-2.5/drivers/ieee1394/dma.c,v
retrieving revision 1.5
diff -u -p -B -r1.5 dma.c
--- linux-2.5/drivers/ieee1394/dma.c 27 Jun 2003 04:49:52 -0000 1.5
+++ linux-2.5/drivers/ieee1394/dma.c 16 Jul 2003 03:46:10 -0000
@@ -157,7 +157,9 @@ static inline int dma_region_find(struct
off -= sg_dma_len(&dma->sglist[i]);
}
- panic("dma_region_find: offset %lu beyond end of DMA mapping\n", offset);
+ printk("dma_region_find: offset %lu beyond end of DMA mapping\n", offset);
+ BUG();
+ return -ENOENT;
}
dma_addr_t dma_region_offset_to_bus(struct dma_region *dma, unsigned long offset)
reply other threads:[~2003-07-16 5:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.53.0307160156480.32541@montezuma.mastecende.com \
--to=zwane@arm.linux.org.uk \
--cc=bcollins@debian.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.