From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: Re: Changeset "acpi: disable PCI links at boot again, fix ELCR" -> on-board nic adapter not working Date: Sat, 2 Jul 2005 10:33:15 -0700 (PDT) Message-ID: References: <42B7CF33.5090501@neoware.com> <42BA6639.9090402@neoware.com> <200506241231.55760.bjorn.helgaas@hp.com> <1120300498.1171.3.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <1120300498.1171.3.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> Sender: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: acpi-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Alexander Nyberg Cc: Bjorn Helgaas , acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Norbert Federa , Len Brown , al_pavel-aPYA7nAdAYY@public.gmane.org List-Id: linux-acpi@vger.kernel.org On Sat, 2 Jul 2005, Alexander Nyberg wrote: > > It appears this change: > > diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c > --- a/drivers/acpi/pci_irq.c > +++ b/drivers/acpi/pci_irq.c > @@ -435,6 +435,7 @@ acpi_pci_irq_enable ( > /* Interrupt Line values above 0xF are forbidden */ > if (dev->irq >= 0 && (dev->irq <= 0xF)) { > printk(" - using IRQ %d\n", dev->irq); > + acpi_register_gsi(dev->irq, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW); > return_VALUE(0); > } Yes, that guy has: ACPI: PCI Interrupt 0000:00:10.0[A]: no GSI - using IRQ 0 and the fix is obvious: we should _not_ consider "irq 0" to be a valid irq, it's a sign that we don't have any irq at all. I bet the correct thing to do is to change the "dev->irq >= 0" to "dev->irq > 0". Linus ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click