From: Anton Altaparmakov <aia21@cam.ac.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Junio C Hamano <junkio@cox.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: git full diff output issues..
Date: Thu, 26 May 2005 20:53:31 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.60.0505262036500.16829@hermes-1.csi.cam.ac.uk> (raw)
In-Reply-To: <Pine.LNX.4.58.0505261223240.2307@ppc970.osdl.org>
On Thu, 26 May 2005, Linus Torvalds wrote:
> On Thu, 26 May 2005, Linus Torvalds wrote:
> >
> > So we'd change it from
> >
> > deleted file mode 100644
> >
> > to
> >
> > deleted file mode 100644 arch/um/kernel/checksum.c
> >
> > in this case..
>
> I just realized that this same thing is equally true of just plain mode
> changes, where wif we don't have any content we just get
>
> diff --git a/name b/name
> old mode xxxx
> new mode yyyy
>
> so I might as well parse the diff header here (I don't want to repeat the
> name twice for mode changes). Oh well.
Given that git already has the metadata lines in the diff ("old mode",
"deleted file mode", etc) why not simply add another metadata line "name"
and what follows that is the name until an end of line character (or a NUL
if you want file names with embedded new lines). You can then only emit
the "name" metadata line when no actual diff is present and hence the name
is uncertain.
Best regards,
Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
next prev parent reply other threads:[~2005-05-26 19:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 19:19 git full diff output issues Linus Torvalds
2005-05-26 19:25 ` Linus Torvalds
2005-05-26 19:36 ` Junio C Hamano
2005-05-26 19:46 ` Junio C Hamano
2005-05-26 19:53 ` Anton Altaparmakov [this message]
2005-05-26 20:33 ` Linus Torvalds
2005-05-26 20:56 ` Junio C Hamano
2005-05-26 21:09 ` Linus Torvalds
2005-05-26 21:33 ` Junio C Hamano
2005-06-05 8:46 ` Junio C Hamano
2005-06-05 15:11 ` Linus Torvalds
2005-05-26 23:34 ` Chris Wedgwood
2005-05-26 23:49 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.60.0505262036500.16829@hermes-1.csi.cam.ac.uk \
--to=aia21@cam.ac.uk \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.