From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261832AbULQN0f (ORCPT ); Fri, 17 Dec 2004 08:26:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262061AbULQN0d (ORCPT ); Fri, 17 Dec 2004 08:26:33 -0500 Received: from scrub.xs4all.nl ([194.109.195.176]:14517 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S261832AbULQN0a (ORCPT ); Fri, 17 Dec 2004 08:26:30 -0500 Date: Fri, 17 Dec 2004 14:26:11 +0100 (CET) From: Roman Zippel X-X-Sender: roman@scrub.home To: Dave Hansen cc: Linux Kernel Mailing List , geert@linux-m68k.org, ralf@linux-mips.org, linux-mm Subject: Re: [patch] [RFC] make WANT_PAGE_VIRTUAL a config option In-Reply-To: <1103257482.13614.2817.camel@localhost> Message-ID: References: <1103244171.13614.2525.camel@localhost> <1103246050.13614.2571.camel@localhost> <1103257482.13614.2817.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, 16 Dec 2004, Dave Hansen wrote: > Sorry I didn't provide this. My recent effort started to clean up some > ugliness in some current patches that worked around this actually > happening a few months ago. The original example didn't survive :) There are two points, which did originally catch my attention. 1) Where/why do you want to remove the dependency on asm/page.h? 2) Does every structure really needs its own header? If you want to do such a cleanup, it would be helpful to have some more information about where you want to go, otherwise you may create a more twisted maze of header files. The big question here is what further cleanups are possible in this area? What basically needs to be done is to separate the definitions from its users, that doesn't mean every definition needs its own header file. Why not create a single header file which collects a number of mm related definitions? E.g. struct vm_area_struct is also used by a number of header files, although its main users have already been separated into asm/tlbflush.h and so created even more headers. So to allow further header cleanup, we should look what other definitions can be pulled out of mm.h and related headers. mm.h should probably stay a high level header, but I'd also like to see a cleanup of asm/page.h. The page table definitions in there should be available to every mm related header. I had to look closer at this, but I did this for struct task_struct and making it available for lowlevel header files. I rediffed the patches and put them at http://www.xs4all.nl/~zippel/task_patches/ bye, Roman From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 17 Dec 2004 14:26:11 +0100 (CET) From: Roman Zippel Subject: Re: [patch] [RFC] make WANT_PAGE_VIRTUAL a config option In-Reply-To: <1103257482.13614.2817.camel@localhost> Message-ID: References: <1103244171.13614.2525.camel@localhost> <1103246050.13614.2571.camel@localhost> <1103257482.13614.2817.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Dave Hansen Cc: Linux Kernel Mailing List , geert@linux-m68k.org, ralf@linux-mips.org, linux-mm List-ID: Hi, On Thu, 16 Dec 2004, Dave Hansen wrote: > Sorry I didn't provide this. My recent effort started to clean up some > ugliness in some current patches that worked around this actually > happening a few months ago. The original example didn't survive :) There are two points, which did originally catch my attention. 1) Where/why do you want to remove the dependency on asm/page.h? 2) Does every structure really needs its own header? If you want to do such a cleanup, it would be helpful to have some more information about where you want to go, otherwise you may create a more twisted maze of header files. The big question here is what further cleanups are possible in this area? What basically needs to be done is to separate the definitions from its users, that doesn't mean every definition needs its own header file. Why not create a single header file which collects a number of mm related definitions? E.g. struct vm_area_struct is also used by a number of header files, although its main users have already been separated into asm/tlbflush.h and so created even more headers. So to allow further header cleanup, we should look what other definitions can be pulled out of mm.h and related headers. mm.h should probably stay a high level header, but I'd also like to see a cleanup of asm/page.h. The page table definitions in there should be available to every mm related header. I had to look closer at this, but I did this for struct task_struct and making it available for lowlevel header files. I rediffed the patches and put them at http://www.xs4all.nl/~zippel/task_patches/ bye, Roman -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org