Re: git-fast-import

From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Horst H. von Brand" <vonbrand@inf.utfsm.cl>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	Andy Parkins <andyparkins@gmail.com>,
	git@vger.kernel.org
Subject: Re: git-fast-import
Date: Thu, 8 Feb 2007 22:34:17 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.63.0702082227170.22628@wbgn013.biozentrum.uni-wuerzburg.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0702061832020.8424@woody.linux-foundation.org>

Hi,

On Tue, 6 Feb 2007, Linus Torvalds wrote:

> [Talks about timestamps being in UTC, even if augmented by a timezone]
>
> And yes, for all I know we might get this wrong inside git too. It's 
> easy to get confused, because they really do mean different things.

FWIW I just grepped git for tz, and looked at the results. The place I had 
to think a bit more about was in builtin-blame.c:format_time(). Probably a 
special date format is needed to stay compatible with cvsserver, otherwise 
show_date() or even show_rfc2822_date() could be used.

The code actually adds the timezone in minutes to the timestamp, and then 
calls gmtime() to be able to format the date with strftime() (something 
similar, without strftime() is done in show_[rfc2822_]date()). The result 
is correct AFAICT, although it would be cleaner IMHO to add yet another 
function to date.c which formats the time according to cvsserver's wishes.

Post 1.5.0.

Ciao,
Dscho