From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: mingw, windows, crlf/lf, and git Date: Wed, 14 Feb 2007 12:10:08 +0100 (CET) Message-ID: References: <45CFA30C.6030202@verizon.net> <200702130932.51601.litvinov2004@gmail.com> <7v7iumx7hu.fsf@assigned-by-dhcp.cox.net> <7v8xf1uxme.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Junio C Hamano , Alexander Litvinov , Mark Levedahl , Git Mailing List To: Linus Torvalds X-From: git-owner@vger.kernel.org Wed Feb 14 12:10:17 2007 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1HHI1g-0005Ix-IT for gcvg-git@gmane.org; Wed, 14 Feb 2007 12:10:16 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750858AbXBNLKM (ORCPT ); Wed, 14 Feb 2007 06:10:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750892AbXBNLKM (ORCPT ); Wed, 14 Feb 2007 06:10:12 -0500 Received: from mail.gmx.net ([213.165.64.20]:51297 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750858AbXBNLKL (ORCPT ); Wed, 14 Feb 2007 06:10:11 -0500 Received: (qmail invoked by alias); 14 Feb 2007 11:10:09 -0000 X-Provags-ID: V01U2FsdGVkX19HXu0X5PVHqkahN1W74v5r2h6dlLY05SSxlNo52U boYQ== X-X-Sender: gene099@wbgn013.biozentrum.uni-wuerzburg.de In-Reply-To: X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Tue, 13 Feb 2007, Linus Torvalds wrote: > 0x00 - which is the only one mmfile_is_binart() uses - is arguably the > "most binary" one, of course, but it might be interesting to give > different weights to the whole range.. In particular, especially for > small files, the fact that there is no 0x00 byte in no way indicates > that it's not "binary". Last time I checked, the text files never had lines longer than 200 characters (I chose this intentionally large). So, it might be a good heuristic to check the maximal line length, and refuse to believe that it's text once a certain (configurable) threshold is reached. Ciao, Dscho