All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remove volatile from nmi.c
Date: Fri, 14 Jul 2006 10:41:58 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0607141040550.5623@g5.osdl.org> (raw)
In-Reply-To: <1152898699.27135.20.camel@localhost.localdomain>



On Fri, 14 Jul 2006, Steven Rostedt wrote:
> 
> > 	endflag = 1;
> > 	smp_wmb();
> 
> This was what I originally wrote, and then I saw the set_wmb which made
> me think that it was the proper way to do things (why else is it
> there?). So if it shouldn't be used, then we should get rid of it or at
> least mark it deprecated, otherwise you have people like me thinking
> that we should use it.

Yeah, we should probably get rid of it. No need to even mark it 
deprecated, since nobody uses it anyway. 

At a minimum, I think we should not document it in the locking 
documentation, making people incorrectly think it might be a good idea.

Hmm? Andrew?

		Linus

  reply	other threads:[~2006-07-14 17:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-14 13:04 [PATCH] remove volatile from nmi.c Steven Rostedt
2006-07-14 13:28 ` Nick Piggin
2006-07-14 15:23 ` Linus Torvalds
2006-07-14 16:32   ` Chase Venters
2006-07-14 16:47     ` Linus Torvalds
2006-07-14 17:00       ` Steven Rostedt
2006-07-14 17:28   ` Linus Torvalds
2006-07-14 17:38     ` Steven Rostedt
2006-07-14 17:41       ` Linus Torvalds [this message]
2006-07-14 17:58         ` Andrew Morton
2006-07-14 20:04           ` [PATCH 00/02] remove set_wmb Steven Rostedt
2006-07-14 20:05           ` [PATCH 01/02] remove set_wmb - doc update Steven Rostedt
2006-07-15  2:22             ` Matthew Wilcox
2006-07-15  2:35               ` Steven Rostedt
2006-07-14 20:05           ` [PATCH 02/02] remove set_wmb - arch removal Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0607141040550.5623@g5.osdl.org \
    --to=torvalds@osdl.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.